From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'mempool: fix leak if populate fails' has been queued to stable release 16.07.2
Date: Tue, 15 Nov 2016 19:40:32 +0800 [thread overview]
Message-ID: <1479210033-24775-12-git-send-email-yuanhan.liu@linux.intel.com> (raw)
In-Reply-To: <1479210033-24775-1-git-send-email-yuanhan.liu@linux.intel.com>
Hi,
FYI, your patch has been queued to stable release 16.07.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
yet. It will be pushed if I get no objections before 11/19/16.
So please shout if anyone has objections.
Thanks.
--yliu
---
>From c74cc134159f5d3b4e057cf768a4a7887ead645f Mon Sep 17 00:00:00 2001
From: Nipun Gupta <nipun.gupta@nxp.com>
Date: Fri, 11 Nov 2016 21:17:10 +0530
Subject: [PATCH] mempool: fix leak if populate fails
[ upstream commit f5e9ed5c4e35a4cc2db7c10cf855e701472af864 ]
This patch fixes the issue of memzone not being freed incase the
rte_mempool_populate_phys fails in the rte_mempool_populate_default
This issue was identified when testing with OVS ~2.6
- configure the system with low memory (e.g. < 500 MB)
- add bridge and dpdk interfaces
- delete brigde
- keep on repeating the above sequence.
Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by default")
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_mempool/rte_mempool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 411a332..ad7c470 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -579,8 +579,10 @@ rte_mempool_populate_default(struct rte_mempool *mp)
mz->len, pg_sz,
rte_mempool_memchunk_mz_free,
(void *)(uintptr_t)mz);
- if (ret < 0)
+ if (ret < 0) {
+ rte_memzone_free(mz);
goto fail;
+ }
}
return mp->size;
--
1.9.0
next prev parent reply other threads:[~2016-11-15 11:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 11:40 [dpdk-stable] patch 'eal/arm: fix file descriptor leak when getting CPU features' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'eal/ppc: " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'lpm: fix freeing memory' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'pci: fix probing error if no driver found' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/ixgbe: fix VF registers' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'app/testpmd: fix DCB configuration' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/i40e: " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/enic: fix max packet length check' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/mlx5: fix handling of small mbuf sizes' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/mlx5: fix Rx checksum macros' " Yuanhan Liu
2016-11-15 11:40 ` [dpdk-stable] patch 'net/vmxnet3: fix mbuf release on reset/stop' " Yuanhan Liu
2016-11-15 11:40 ` Yuanhan Liu [this message]
2016-11-15 11:40 ` [dpdk-stable] patch 'net/virtio: revert fix restart' " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479210033-24775-12-git-send-email-yuanhan.liu@linux.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).