* [dpdk-stable] [PATCH v6 26/27] net/i40e: fix segmentation fault in close
@ 2016-12-22 16:25 Bernard Iremonger
0 siblings, 0 replies; 2+ messages in thread
From: Bernard Iremonger @ 2016-12-22 16:25 UTC (permalink / raw)
To: ferruh.yigit; +Cc: Bernard Iremonger, stable
The vsi's have already been released, so the second call
to i40e_vsi_release results in a segmentation fault.
The second call to i40e_vsi_release has been removed.
Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing")
CC: stable@dpdk.org
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 06ee06d..d4d1547 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1883,7 +1883,6 @@ i40e_dev_close(struct rte_eth_dev *dev)
i40e_vsi_release(pf->main_vsi);
for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {
- i40e_vsi_release(pf->vmdq[i].vsi);
pf->vmdq[i].vsi = NULL;
}
@@ -4138,6 +4137,9 @@ i40e_vsi_release(struct i40e_vsi *vsi)
if (!vsi)
return I40E_SUCCESS;
+ if (!vsi->adapter)
+ return I40E_ERR_BAD_PTR;
+
user_param = vsi->user_param;
pf = I40E_VSI_TO_PF(vsi);
--
2.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH v6 26/27] net/i40e: fix segmentation fault in close
[not found] <1482414901-16700-1-git-send-email-bernard.iremonger@intel.com>
@ 2016-12-22 13:55 ` Bernard Iremonger
0 siblings, 0 replies; 2+ messages in thread
From: Bernard Iremonger @ 2016-12-22 13:55 UTC (permalink / raw)
To: wenzhuo.lu, qi.z.zhang
Cc: ferruh.yigit, helin.zhang, john.mcnamara, Bernard Iremonger, stable
The vsi's have already been released, so the second call
to i40e_vsi_release results in a segmentation fault.
The second call to i40e_vsi_release has been removed.
Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing")
CC: stable@dpdk.org
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 06ee06d..d4d1547 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1883,7 +1883,6 @@ i40e_dev_close(struct rte_eth_dev *dev)
i40e_vsi_release(pf->main_vsi);
for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {
- i40e_vsi_release(pf->vmdq[i].vsi);
pf->vmdq[i].vsi = NULL;
}
@@ -4138,6 +4137,9 @@ i40e_vsi_release(struct i40e_vsi *vsi)
if (!vsi)
return I40E_SUCCESS;
+ if (!vsi->adapter)
+ return I40E_ERR_BAD_PTR;
+
user_param = vsi->user_param;
pf = I40E_VSI_TO_PF(vsi);
--
2.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-22 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-22 16:25 [dpdk-stable] [PATCH v6 26/27] net/i40e: fix segmentation fault in close Bernard Iremonger
[not found] <1482414901-16700-1-git-send-email-bernard.iremonger@intel.com>
2016-12-22 13:55 ` Bernard Iremonger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).