From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E91D510C5C for ; Thu, 22 Dec 2016 17:25:35 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 22 Dec 2016 08:25:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,389,1477983600"; d="scan'208";a="1085564695" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2016 08:25:34 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id uBMGPXp7015838; Thu, 22 Dec 2016 16:25:33 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id uBMGPX7Q018088; Thu, 22 Dec 2016 16:25:33 GMT Received: (from bairemon@localhost) by sivswdev01.ir.intel.com with œ id uBMGPXQv018082; Thu, 22 Dec 2016 16:25:33 GMT From: Bernard Iremonger To: ferruh.yigit@intel.com Cc: Bernard Iremonger , stable@dpdk.org Date: Thu, 22 Dec 2016 16:25:30 +0000 Message-Id: <1482423930-17758-1-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-stable] [PATCH v6 26/27] net/i40e: fix segmentation fault in close X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 16:25:36 -0000 The vsi's have already been released, so the second call to i40e_vsi_release results in a segmentation fault. The second call to i40e_vsi_release has been removed. Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing") CC: stable@dpdk.org Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 06ee06d..d4d1547 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1883,7 +1883,6 @@ i40e_dev_close(struct rte_eth_dev *dev) i40e_vsi_release(pf->main_vsi); for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) { - i40e_vsi_release(pf->vmdq[i].vsi); pf->vmdq[i].vsi = NULL; } @@ -4138,6 +4137,9 @@ i40e_vsi_release(struct i40e_vsi *vsi) if (!vsi) return I40E_SUCCESS; + if (!vsi->adapter) + return I40E_ERR_BAD_PTR; + user_param = vsi->user_param; pf = I40E_VSI_TO_PF(vsi); -- 2.10.1