From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5106A2C57 for ; Mon, 23 Jan 2017 08:45:46 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP; 22 Jan 2017 23:45:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,273,1477983600"; d="scan'208";a="51485682" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga004.jf.intel.com with ESMTP; 22 Jan 2017 23:45:44 -0800 From: Yuanhan Liu To: Jerin Jacob Cc: Yuanhan Liu , dpdk stable Date: Mon, 23 Jan 2017 15:46:46 +0800 Message-Id: <1485157675-32114-11-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1485157675-32114-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1485157675-32114-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'app/testpmd: fix static build link ordering' has been queued to stable release 16.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 07:45:46 -0000 Hi, FYI, your patch has been queued to stable release 16.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/28/17. So please shout if anyone has objections. --- Note 16.11 is a LTS release. v16.11.1 is planned to be released shortly (about 2-3 weeks) after v17.02. --- Thanks. --yliu --- >>From 0c32990ad6faa6f977f1dcb5d73ad75d18be029a Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Thu, 12 Jan 2017 13:16:54 +0530 Subject: [PATCH] app/testpmd: fix static build link ordering [ upstream commit d74cbeca7596b3237fe5b823fb8a4bcfe8a7d979 ] By introducing explicit -lrte_pmd_ixgbe link request in testpmd Makefile,"-Wl,-lrte_pmd_ixgbe" provided twice, and linker removes the duplication by keeping only first occurrence. This moves "-Wl,-lrte_pmd_ixgbe" out of "-Wl,--whole-archive" flag and makes symbol generation totally different than previous version in case of static build. This patch fixes the static build linking order by introducing -lrte_pmd_ixgbe under the shared library config (CONFIG_RTE_BUILD_SHARED_LIB). Fixes: 425781ff5afe ("app/testpmd: add ixgbe VF management") Signed-off-by: Jerin Jacob --- app/test-pmd/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index 891b85a..92c0c1b 100644 --- a/app/test-pmd/Makefile +++ b/app/test-pmd/Makefile @@ -58,7 +58,9 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe +endif CFLAGS_cmdline.o := -D_GNU_SOURCE -- 1.9.0