From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Alan Dewar <adewar@brocade.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Jan Blunck <jblunck@infradead.org>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'sched: fix crash when freeing port' has been queued to stable release 16.11.1
Date: Wed, 15 Feb 2017 14:26:28 +0800 [thread overview]
Message-ID: <1487140012-13314-16-git-send-email-yuanhan.liu@linux.intel.com> (raw)
In-Reply-To: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com>
Hi,
FYI, your patch has been queued to stable release 16.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
yet. It will be pushed if I get no objections before 02/18/17.
So please shout if anyone has objections.
Thanks.
--yliu
---
>From bfc65d9c21c61be041dc4704759fa29c4bc68594 Mon Sep 17 00:00:00 2001
From: Alan Dewar <adewar@brocade.com>
Date: Mon, 6 Feb 2017 18:32:42 +0100
Subject: [PATCH] sched: fix crash when freeing port
[ upstream commit 3b780b9e9e9221725abbad9820704d05d7d2805e ]
Prevent a segmentation fault in rte_sched_port_free by only accessing
the port structure after the NULL pointer check has been made.
Fixes: 7b3c4f35 ("sched: fix releasing enqueued packets")
Signed-off-by: Alan Dewar <adewar@brocade.com>
Signed-off-by: Jan Blunck <jblunck@infradead.org>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/librte_sched/rte_sched.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index e6dace2..614705d 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -735,12 +735,14 @@ void
rte_sched_port_free(struct rte_sched_port *port)
{
uint32_t qindex;
- uint32_t n_queues_per_port = rte_sched_port_queues_per_port(port);
+ uint32_t n_queues_per_port;
/* Check user parameters */
if (port == NULL)
return;
+ n_queues_per_port = rte_sched_port_queues_per_port(port);
+
/* Free enqueued mbufs */
for (qindex = 0; qindex < n_queues_per_port; qindex++) {
struct rte_mbuf **mbufs = rte_sched_port_qbase(port, qindex);
--
1.9.0
next prev parent reply other threads:[~2017-02-15 6:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 6:26 [dpdk-stable] patch 'devargs: reset driver name pointer on parsing failure' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'vhost: fix dead loop in enqueue path' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'vhost: fix long stall of negotiation' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'vhost: do not GSO when no header is present' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: fix performance regression due to TSO' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: optimize header reset on any layout' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix Rx checksum flag' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/mlx5: fix memory leak when parsing device params' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/qede/base: fix FreeBSD build' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix deletion of all macvlan filters' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/bnx2x: fix Rx mode configuration' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/cxgbe/base: initialize variable before reading EEPROM' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix checksum flag in x86 vector Rx' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix crash in close' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'vfio: fix file descriptor leak in multi-process' " Yuanhan Liu
2017-02-15 6:26 ` Yuanhan Liu [this message]
2017-02-15 6:26 ` [dpdk-stable] patch 'net/enic: fix memory leak with oversized Tx packets' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/ena: fix setting host attributes' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix ethertype filter on X722' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40evf: fix reporting of imissed packets' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix link update delay' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/enic: fix hardcoding of some flow director masks' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/ixgbe: fix received packets number for ARM' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/ixgbe: fix received packets number for ARM NEON' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/i40e: fix TC bandwidth definition' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'drivers/crypto: fix different auth/cipher keys' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'examples/l2fwd-crypto: fix overflow' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'examples/l2fwd-crypto: fix padding' " Yuanhan Liu
2017-02-16 8:01 ` Yuanhan Liu
2017-02-16 9:10 ` De Lara Guarch, Pablo
2017-02-17 7:44 ` Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'vhost: allow many vhost-user ports' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'mempool: fix stack handler dequeue' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'ethdev: fix port data mismatched in multiple process model' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: fix wrong Rx/Tx method for secondary process' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: store PCI operators pointer locally' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: store IO port info " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: fix multiple process support' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: fix build without virtio-user' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/virtio: fix crash when number of virtio devices > 1' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'usertools: fix active interface detection when binding' " Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/vhost: fix unix socket not removed as closing' " Yuanhan Liu
2017-02-15 7:22 ` Tan, Jianfeng
2017-02-15 7:28 ` Yuanhan Liu
2017-02-15 6:26 ` [dpdk-stable] patch 'net/ixgbevf: fix max packet length' " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487140012-13314-16-git-send-email-yuanhan.liu@linux.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=adewar@brocade.com \
--cc=cristian.dumitrescu@intel.com \
--cc=jblunck@infradead.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).