From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 08BA69E7 for ; Wed, 15 Feb 2017 07:25:11 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2017 22:25:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,164,1484035200"; d="scan'208";a="1094927658" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 14 Feb 2017 22:25:11 -0800 From: Yuanhan Liu To: Yuanhan Liu Cc: dpdk stable Date: Wed, 15 Feb 2017 14:26:44 +0800 Message-Id: <1487140012-13314-32-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'net/virtio: fix wrong Rx/Tx method for secondary process' has been queued to stable release 16.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 06:25:12 -0000 Hi, FYI, your patch has been queued to stable release 16.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/18/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 5ddf76c864fa577d394067e85e493126a8a0ca1e Mon Sep 17 00:00:00 2001 From: Yuanhan Liu Date: Fri, 6 Jan 2017 18:16:16 +0800 Subject: [PATCH] net/virtio: fix wrong Rx/Tx method for secondary process [ upstream commit d4be35a91340b8474bd5f8b6bcaa26084bb30c9f ] If the primary enables the vector Rx/Tx path, the current code would let the secondary always choose the non vector Rx/Tx path. This results to a Rx/Tx method mismatch between primary and secondary process. Werid errors then may happen, something like: PMD: virtio_xmit_pkts() tx: virtqueue_enqueue error: -14 Fix it by choosing the correct Rx/Tx callbacks for the secondary process. That is, use vector path if it's given. Fixes: 8d8393fb1861 ("virtio: pick simple Rx/Tx") Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 85ae147..4047da5 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1306,7 +1306,12 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) eth_dev->tx_pkt_burst = &virtio_xmit_pkts; if (rte_eal_process_type() == RTE_PROC_SECONDARY) { - rx_func_get(eth_dev); + if (hw->use_simple_rxtx) { + eth_dev->tx_pkt_burst = virtio_xmit_pkts_simple; + eth_dev->rx_pkt_burst = virtio_recv_pkts_vec; + } else { + rx_func_get(eth_dev); + } return 0; } -- 1.9.0