From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 339E52C08 for ; Wed, 15 Feb 2017 07:25:18 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2017 22:25:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,164,1484035200"; d="scan'208";a="1094927685" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 14 Feb 2017 22:25:16 -0800 From: Yuanhan Liu To: Yoni Gilad Cc: Yuanhan Liu , Pablo de Lara , dpdk stable Date: Wed, 15 Feb 2017 14:26:50 +0800 Message-Id: <1487140012-13314-38-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1487140012-13314-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'usertools: fix active interface detection when binding' has been queued to stable release 16.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 06:25:18 -0000 Hi, FYI, your patch has been queued to stable release 16.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/18/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 2aca8654b0a35536078c5cb34bd3e2ceea2d3748 Mon Sep 17 00:00:00 2001 From: Yoni Gilad Date: Tue, 10 Jan 2017 17:14:21 +0000 Subject: [PATCH] usertools: fix active interface detection when binding [ backported from upstream commit 617d90527f8a72e9a1a258f2e6885b46ffb6fa46 ] When adding crypto devices, the "Active" and "Ssh_if" attributes of existing network devices were reset. This causes the following issues: - Network interfaces aren't marked as "*Active*" in the --status output. - Active network interfaces can be unbound without the --force option, causing loss of network connection. The reset was caused by the call to devices[d].update in get_crypto_details. This patch prevents the update on non-crypto devices. Fixes: cb4a1d14bf3e ("tools: bind crypto devices") Signed-off-by: Yoni Gilad Acked-by: Pablo de Lara --- tools/dpdk-devbind.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py index f1d374d..fef59c4 100755 --- a/tools/dpdk-devbind.py +++ b/tools/dpdk-devbind.py @@ -328,6 +328,9 @@ def get_crypto_details(): # based on the basic info, get extended text details for d in devices.keys(): + if devices[d]["Class"][0:2] != CRYPTO_BASE_CLASS: + continue + # get additional info and add it to existing data devices[d] = devices[d].copy() devices[d].update(get_pci_device_details(d).items()) -- 1.9.0