From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DB7661B53; Thu, 23 Mar 2017 06:46:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490247978; x=1521783978; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=kyXP88oRrO1l3mosrjf+X6IRqOFesphYjM4BgYBKpe0=; b=MVnivD49N5SS4cO+8BoiEaxycoLNvCDSpTJ4K5T9z9ewK+BhSuhimPRO j0kmWxxKYivIOht4ayxQ/fjzZLRhpw==; Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 22:46:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,208,1486454400"; d="scan'208";a="239402849" Received: from jeffguo-s2600wt2.sh.intel.com ([10.239.129.150]) by fmsmga004.fm.intel.com with ESMTP; 22 Mar 2017 22:46:10 -0700 From: Jeff Guo To: helin.zhang@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, jia.guo@intel.com, stable@dpdk.org Date: Thu, 23 Mar 2017 13:43:59 +0800 Message-Id: <1490247839-110341-3-git-send-email-jia.guo@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490247839-110341-1-git-send-email-jia.guo@intel.com> References: <1490003874-37766-2-git-send-email-jia.guo@intel.com> <1490247839-110341-1-git-send-email-jia.guo@intel.com> Subject: [dpdk-stable] [dpdk-dev v3 3/3] test: enable HW CRC strip by default X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 05:46:18 -0000 Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in test app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip to let VF launch successful. Signed-off-by: Jeff Guo Cc: stable@dpdk.org --- v3: fix comments error --- test/test-pipeline/init.c | 2 +- test/test/test_kni.c | 2 +- test/test/test_link_bonding.c | 4 ++-- test/test/test_link_bonding_mode4.c | 2 +- test/test/test_link_bonding_rssconf.c | 4 ++-- test/test/test_pmd_perf.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c index aef082f..00dbc27 100644 --- a/test/test-pipeline/init.c +++ b/test/test-pipeline/init.c @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf = { .hw_ip_checksum = 1, /* IP checksum offload enabled */ .hw_vlan_filter = 0, /* VLAN filtering disabled */ .jumbo_frame = 0, /* Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /* CRC stripped by hardware */ + .hw_strip_crc = 1, /* CRC stripped by hardware */ }, .rx_adv_conf = { .rss_conf = { diff --git a/test/test/test_kni.c b/test/test/test_kni.c index 309741c..db17fdf 100644 --- a/test/test/test_kni.c +++ b/test/test/test_kni.c @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf = { .hw_ip_checksum = 0, .hw_vlan_filter = 0, .jumbo_frame = 0, - .hw_strip_crc = 0, + .hw_strip_crc = 1, }, .txmode = { .mq_mode = ETH_DCB_NONE, diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c index 3229660..52d2d05 100644 --- a/test/test/test_link_bonding.c +++ b/test/test/test_link_bonding.c @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode = { .hw_vlan_strip = 1, /**< VLAN strip enabled. */ .hw_vlan_extend = 0, /**< Extended VLAN disabled. */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled. */ - .hw_strip_crc = 0, /**< CRC stripping by hardware disabled. */ + .hw_strip_crc = 1, /**< CRC stripping by hardware enabled. */ }; struct rte_fdir_conf fdir_conf = { @@ -191,7 +191,7 @@ static struct rte_eth_conf default_pmd_conf = { .hw_ip_checksum = 0, /**< IP checksum offload enabled */ .hw_vlan_filter = 0, /**< VLAN filtering disabled */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /**< CRC stripped by hardware */ + .hw_strip_crc = 1, /**< CRC stripped by hardware */ }, .txmode = { .mq_mode = ETH_MQ_TX_NONE, diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c index 53caa3e..dc33973 100644 --- a/test/test/test_link_bonding_mode4.c +++ b/test/test/test_link_bonding_mode4.c @@ -143,7 +143,7 @@ static struct rte_eth_conf default_pmd_conf = { .hw_ip_checksum = 0, /**< IP checksum offload enabled */ .hw_vlan_filter = 0, /**< VLAN filtering disabled */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /**< CRC stripped by hardware */ + .hw_strip_crc = 1, /**< CRC stripped by hardware */ }, .txmode = { .mq_mode = ETH_MQ_TX_NONE, diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c index 9034f62..ba7163e 100644 --- a/test/test/test_link_bonding_rssconf.c +++ b/test/test/test_link_bonding_rssconf.c @@ -116,7 +116,7 @@ static struct rte_eth_conf default_pmd_conf = { .hw_ip_checksum = 0, /**< IP checksum offload enabled */ .hw_vlan_filter = 0, /**< VLAN filtering disabled */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /**< CRC stripped by hardware */ + .hw_strip_crc = 1, /**< CRC stripped by hardware */ }, .txmode = { .mq_mode = ETH_MQ_TX_NONE, @@ -133,7 +133,7 @@ static struct rte_eth_conf rss_pmd_conf = { .hw_ip_checksum = 0, /**< IP checksum offload enabled */ .hw_vlan_filter = 0, /**< VLAN filtering disabled */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /**< CRC stripped by hardware */ + .hw_strip_crc = 1, /**< CRC stripped by hardware */ }, .txmode = { .mq_mode = ETH_MQ_TX_NONE, diff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c index e055aa0..1ffd65a 100644 --- a/test/test/test_pmd_perf.c +++ b/test/test/test_pmd_perf.c @@ -100,7 +100,7 @@ static struct rte_eth_conf port_conf = { .hw_vlan_strip = 0, /**< VLAN strip enabled. */ .hw_vlan_extend = 0, /**< Extended VLAN disabled. */ .jumbo_frame = 0, /**< Jumbo Frame Support disabled */ - .hw_strip_crc = 0, /**< CRC stripped by hardware */ + .hw_strip_crc = 1, /**< CRC stripped by hardware */ .enable_scatter = 0, /**< scatter rx disabled */ }, .txmode = { -- 2.7.4