From: Jianfeng Tan <jianfeng.tan@intel.com>
To: zhiyong.yang@intel.com
Cc: Jianfeng Tan <jianfeng.tan@intel.com>,
stable@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-stable] [PATCH] net/virtio: fix read isr as MSI is enabled
Date: Tue, 28 Mar 2017 06:46:51 +0000 [thread overview]
Message-ID: <1490683611-72221-1-git-send-email-jianfeng.tan@intel.com> (raw)
We should not always check isr to know if link status is changed.
Here is how driver should handle interrupt quoted from virtio spec,
If MSI-X capability is disabled:
– Read the ISR Status field, which will reset it to zero.
– If the lower bit is set: look through the used rings of all
virtqueues for the device, to see if any progress has been made
by the device which requires servicing.
– If the second lower bit is set: re-examine the configuration
space to see what changed.
If MSI-X capability is enabled:
– Look through the used rings of all virtqueues mapped to that
MSI-X vector for the device, to see if any progress has been
made by the device which requires servicing.
– If the MSI-X vector is equal to config_msix_vector, re-examine
the configuration space to see what changed
Fixes: 8d6d7e5cb3b1 ("virtio: support link state interrupt")
CC: stable@dpdk.org
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 3cf4102..cb30d11 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -36,6 +36,7 @@
#include <stdio.h>
#include <errno.h>
#include <unistd.h>
+#include <stdbool.h>
#include <rte_ethdev.h>
#include <rte_memcpy.h>
@@ -1197,20 +1198,23 @@ virtio_interrupt_handler(struct rte_intr_handle *handle,
struct rte_eth_dev *dev = param;
struct virtio_hw *hw = dev->data->dev_private;
uint8_t isr;
+ bool check_config;
- /* Read interrupt status which clears interrupt */
- isr = vtpci_isr(hw);
- PMD_DRV_LOG(INFO, "interrupt status = %#x", isr);
+ /* isr is used only when msix is not enabled */
+ if (!hw->modern && !hw->use_msix) {
+ isr = vtpci_isr(hw); /* Read to clears interrupt */
+ PMD_DRV_LOG(INFO, "interrupt status = %#x", isr);
+ check_config = (isr & VIRTIO_PCI_ISR_CONFIG) ? true : false;
+ } else {
+ check_config = true;
+ }
if (rte_intr_enable(handle) < 0)
PMD_DRV_LOG(ERR, "interrupt enable failed");
- if (isr & VIRTIO_PCI_ISR_CONFIG) {
- if (virtio_dev_link_update(dev, 0) == 0)
- _rte_eth_dev_callback_process(dev,
- RTE_ETH_EVENT_INTR_LSC, NULL);
- }
-
+ if (check_config && virtio_dev_link_update(dev, 0) == 0)
+ _rte_eth_dev_callback_process(dev,
+ RTE_ETH_EVENT_INTR_LSC, NULL);
}
static void
--
2.7.4
next reply other threads:[~2017-03-28 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:46 Jianfeng Tan [this message]
2017-04-06 5:19 ` Yuanhan Liu
2017-04-06 5:30 ` Tan, Jianfeng
2017-04-06 5:36 ` Yuanhan Liu
2017-04-06 5:40 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490683611-72221-1-git-send-email-jianfeng.tan@intel.com \
--to=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).