* [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed [not found] <1491433830-36092-1-git-send-email-qi.z.zhang@intel.com> @ 2017-04-05 23:10 ` Qi Zhang 2017-04-05 23:10 ` [dpdk-stable] [PATCH 3/3] net/i40e: add missing 25G " Qi Zhang 1 sibling, 0 replies; 4+ messages in thread From: Qi Zhang @ 2017-04-05 23:10 UTC (permalink / raw) To: qi.z.zhang; +Cc: stable When PF notify link speed to VF, encode of link speed need to be converted from ETH_SPEED_XXX to I40E_LINK_SPEED_XXX. Fixes: bb6722fb5c0e ("net/i40e: fix VF bonded device link down") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/i40e/i40e_pf.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 5dcda4d..f2b9fca 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -1188,8 +1188,33 @@ i40e_notify_vf_link_status(struct rte_eth_dev *dev, struct i40e_pf_vf *vf) event.event = I40E_VIRTCHNL_EVENT_LINK_CHANGE; event.event_data.link_event.link_status = dev->data->dev_link.link_status; - event.event_data.link_event.link_speed = - (enum i40e_aq_link_speed)dev->data->dev_link.link_speed; + + /* need to convert the ETH_SPEED_xxx into I40E_LINK_SPEED_xxx */ + switch (dev->data->dev_link.link_speed) + { + case ETH_SPEED_NUM_100M: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_100MB; + break; + case ETH_SPEED_NUM_1G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_1GB; + break; + case ETH_SPEED_NUM_10G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_10GB; + break; + case ETH_SPEED_NUM_20G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_20GB; + break; + case ETH_SPEED_NUM_25G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_25GB; + break; + case ETH_SPEED_NUM_40G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB; + break; + default: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_UNKNOWN; + break; + } + i40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_EVENT, I40E_SUCCESS, (uint8_t *)&event, sizeof(event)); } -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 3/3] net/i40e: add missing 25G link speed [not found] <1491433830-36092-1-git-send-email-qi.z.zhang@intel.com> 2017-04-05 23:10 ` [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed Qi Zhang @ 2017-04-05 23:10 ` Qi Zhang 1 sibling, 0 replies; 4+ messages in thread From: Qi Zhang @ 2017-04-05 23:10 UTC (permalink / raw) To: qi.z.zhang; +Cc: stable Add missing 25G link speed decode in i40evf_dev_link_update. Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/i40e/i40e_ethdev_vf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index d3659c9..caafa2d 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,6 +2163,9 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, case I40E_LINK_SPEED_20GB: new_link.link_speed = ETH_SPEED_NUM_20G; break; + case I40E_LINK_SPEED_25GB: + new_link.link_speed = ETH_SPEED_NUM_25G; + break; case I40E_LINK_SPEED_40GB: new_link.link_speed = ETH_SPEED_NUM_40G; break; -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1491433937-36182-1-git-send-email-qi.z.zhang@intel.com>]
* [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed [not found] <1491433937-36182-1-git-send-email-qi.z.zhang@intel.com> @ 2017-04-05 23:12 ` Qi Zhang 2017-04-07 14:29 ` Ferruh Yigit 0 siblings, 1 reply; 4+ messages in thread From: Qi Zhang @ 2017-04-05 23:12 UTC (permalink / raw) To: jingjing.wu, helin.zhang; +Cc: dev, Qi Zhang, stable When PF notify link speed to VF, encode of link speed need to be converted from ETH_SPEED_XXX to I40E_LINK_SPEED_XXX. Fixes: bb6722fb5c0e ("net/i40e: fix VF bonded device link down") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/i40e/i40e_pf.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 5dcda4d..f2b9fca 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -1188,8 +1188,33 @@ i40e_notify_vf_link_status(struct rte_eth_dev *dev, struct i40e_pf_vf *vf) event.event = I40E_VIRTCHNL_EVENT_LINK_CHANGE; event.event_data.link_event.link_status = dev->data->dev_link.link_status; - event.event_data.link_event.link_speed = - (enum i40e_aq_link_speed)dev->data->dev_link.link_speed; + + /* need to convert the ETH_SPEED_xxx into I40E_LINK_SPEED_xxx */ + switch (dev->data->dev_link.link_speed) + { + case ETH_SPEED_NUM_100M: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_100MB; + break; + case ETH_SPEED_NUM_1G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_1GB; + break; + case ETH_SPEED_NUM_10G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_10GB; + break; + case ETH_SPEED_NUM_20G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_20GB; + break; + case ETH_SPEED_NUM_25G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_25GB; + break; + case ETH_SPEED_NUM_40G: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB; + break; + default: + event.event_data.link_event.link_speed = I40E_LINK_SPEED_UNKNOWN; + break; + } + i40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_EVENT, I40E_SUCCESS, (uint8_t *)&event, sizeof(event)); } -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed 2017-04-05 23:12 ` [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF " Qi Zhang @ 2017-04-07 14:29 ` Ferruh Yigit 0 siblings, 0 replies; 4+ messages in thread From: Ferruh Yigit @ 2017-04-07 14:29 UTC (permalink / raw) To: Qi Zhang, jingjing.wu, helin.zhang; +Cc: dev, stable On 4/6/2017 12:12 AM, Qi Zhang wrote: > When PF notify link speed to VF, encode of link speed need to > be converted from ETH_SPEED_XXX to I40E_LINK_SPEED_XXX. > > Fixes: bb6722fb5c0e ("net/i40e: fix VF bonded device link down") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> Hi Qi, There are some checkpatch warnings for this patch. Can you please address them and send a new version of the set? Thanks, ferruh ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-07 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1491433830-36092-1-git-send-email-qi.z.zhang@intel.com>
2017-04-05 23:10 ` [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF link speed Qi Zhang
2017-04-05 23:10 ` [dpdk-stable] [PATCH 3/3] net/i40e: add missing 25G " Qi Zhang
[not found] <1491433937-36182-1-git-send-email-qi.z.zhang@intel.com>
2017-04-05 23:12 ` [dpdk-stable] [PATCH 2/3] net/i40e: fix wrong VF " Qi Zhang
2017-04-07 14:29 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).