From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 469922BAE for ; Fri, 7 Apr 2017 10:15:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491552909; x=1523088909; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=2iPV4LIhnLGejK1dyhsdyIpBT+mThs5/6bf1a6qnO+A=; b=l2c0ocsToPqjN9898YBwEspKyPWYgm04OkxDhL85ClE1vxP/P22av404 c8cw0bXoeHEUdxu7YgwVFfMtLrdRJQ==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 01:15:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,164,1488873600"; d="scan'208";a="953273454" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 07 Apr 2017 01:15:08 -0700 From: Yuanhan Liu To: Ido Barnea Cc: Yuanhan Liu , dpdk stable Date: Fri, 7 Apr 2017 16:11:39 +0800 Message-Id: <1491552724-3034-22-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1491552724-3034-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1491552724-3034-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'net/ixgbevf: set xstats id values' has been queued to LTS release 16.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 08:15:09 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 0da62ba8dc47d9637ed6435a2477d523144c2c81 Mon Sep 17 00:00:00 2001 From: Ido Barnea Date: Thu, 9 Mar 2017 16:59:28 +0000 Subject: [PATCH] net/ixgbevf: set xstats id values [ upstream commit 09deb982228ce70439976c8d4c2b92b0d0fb4172 ] Without setting the id, calling xstats_get twice with same array causes memory corruption. Also, if IXGBEVF_NB_XSTATS will be different than 1 in the future, this will cause issues. Fixes: 156712ba40d3 ("ixgbevf: add extending stats") Signed-off-by: Ido Barnea --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index bac36e0..5fe357d 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2991,6 +2991,7 @@ ixgbevf_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, /* Extended stats */ for (i = 0; i < IXGBEVF_NB_XSTATS; i++) { + xstats[i].id = i; xstats[i].value = *(uint64_t *)(((char *)hw_stats) + rte_ixgbevf_stats_strings[i].offset); } -- 1.9.0