From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A3CC737B4 for ; Fri, 7 Apr 2017 10:15:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491552936; x=1523088936; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=5KxLUmKsqJOk7cLFKGLBfxkgxTDqPqzeHdnI9uKXBtM=; b=MJv5RywqLvLqN7JH4o4vjWOoQaUvCINyhsWc9BozGBGkFldukSUrHbYT drmqrihKnSt8ESarqQullBTcLT7pwg==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 01:15:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,164,1488873600"; d="scan'208";a="953273677" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 07 Apr 2017 01:15:35 -0700 From: Yuanhan Liu To: Matt Peters Cc: Yuanhan Liu , Allain Legacy , dpdk stable Date: Fri, 7 Apr 2017 16:12:04 +0800 Message-Id: <1491552724-3034-47-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1491552724-3034-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1491552724-3034-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'net/virtio: disable LSC interrupt if MSIX not enabled' has been queued to LTS release 16.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 08:15:37 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/17. So please shout if anyone has objections. Thanks. --yliu --- >>From eee42f85b779dfc55352f73f91fc1cde1e6ff132 Mon Sep 17 00:00:00 2001 From: Matt Peters Date: Thu, 9 Mar 2017 15:28:02 -0500 Subject: [PATCH] net/virtio: disable LSC interrupt if MSIX not enabled [ upstream commit a5ed844846aefeefb1df3df15e6588c265452f19 ] The link state change interrupt can only be configured if the virtio device supports MSIX. Prior to this change the writing of the vector to the PCI config space was causing it to overwrite the initial part of the MAC address since the MSIX vector is not in the config space and is occupied by the MAC address. This has been reproduced in Virtual Box (v5.0.30.r112061) in Windows 7. Fixes: 954ea11540b6 ("virtio: do not report link state feature unless available") Signed-off-by: Matt Peters Signed-off-by: Allain Legacy --- drivers/net/virtio/virtio_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index f5961ab..ff3f781 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1210,11 +1210,11 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features) rte_eth_copy_pci_info(eth_dev, pci_dev); - /* If host does not support status then disable LSC */ - if (!vtpci_with_feature(hw, VIRTIO_NET_F_STATUS)) - eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; - else + /* If host does not support both status and MSI-X then disable LSC */ + if (vtpci_with_feature(hw, VIRTIO_NET_F_STATUS) && hw->use_msix) eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC; + else + eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; rx_func_get(eth_dev); -- 1.9.0