Hi, FYI, your patch has been queued to LTS release 16.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/17. So please shout if anyone has objections. Thanks. --yliu --- >From 454ad884f2a76daa5517019a82d36a137c551b02 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Mon, 3 Apr 2017 14:05:14 +0530 Subject: [PATCH] eal/linux: fix build with glibc 2.25 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 9256eed78a2ddd54c363241568a744ff65051f13 ] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit glibc 2.25 is warning about if applications depend on sys/types.h for makedev macro, it expects to be included from Found this error while testing with GCC 6.3.1 on archlinux. lib/librte_eal/linuxapp/eal/eal_pci_uio.c: In function ‘pci_mknod_uio_dev’: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:134:13: error: In the GNU C Library, "makedev" is defined by . For historical compatibility, it is currently defined by as well, but we plan to remove this soon. To use "makedev", include directly. If you did not intend to use a system-defined macro "makedev", you should undefine it after including . [-Werror] dev = makedev(major, minor); ^~~~~~~~~~~~~~~~~ Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 3e4ffb5..aac05d7 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #if defined(RTE_ARCH_X86) -- 1.9.0