* [dpdk-stable] [PATCH v2] net/i40e: fix to ensure vector mode is not used [not found] <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> @ 2017-04-12 15:28 ` Bernard Iremonger 2017-04-13 9:53 ` [dpdk-stable] [PATCH v3] " Bernard Iremonger 0 siblings, 1 reply; 5+ messages in thread From: Bernard Iremonger @ 2017-04-12 15:28 UTC (permalink / raw) To: dev; +Cc: beilei.xing, wenzhuo.lu, qi.zhang, Bernard Iremonger, stable In rx vector mode, the QinQ VLAN tag is not stripped. When hw_vlan_extend is set for QinQ ensure that rx vector mode is not selected. Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") Cc: stable@dpdk.org Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> --- Changes in v2: Rebased to latest dpdk-next-net Updated Fixes line. Added Cc: line drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h index 952fd4b63..692096684 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_common.h +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h @@ -234,6 +234,10 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) if (rxmode->header_split == 1) return -1; + /* no QinQ support */ + if (rxmode->hw_vlan_extend == 1) + return -1; + return 0; #else RTE_SET_USED(dev); -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] [PATCH v3] net/i40e: fix to ensure vector mode is not used 2017-04-12 15:28 ` [dpdk-stable] [PATCH v2] net/i40e: fix to ensure vector mode is not used Bernard Iremonger @ 2017-04-13 9:53 ` Bernard Iremonger 2017-04-18 9:58 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin 0 siblings, 1 reply; 5+ messages in thread From: Bernard Iremonger @ 2017-04-13 9:53 UTC (permalink / raw) To: dev; +Cc: beilei.xing, wenzhuo.lu, qi.zhang, Bernard Iremonger, stable In rx vector mode, QinQ is not supported. When hw_vlan_extend is set for QinQ ensure that rx vector mode is not selected. Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") Cc: stable@dpdk.org Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> --- Changes in v3: Rebased to latest dpdk-next-net Revised commit message. Changes in v2: Rebased to latest dpdk-next-net Updated Fixes line. Added Cc: line drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h index 952fd4b63..692096684 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_common.h +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h @@ -234,6 +234,10 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) if (rxmode->header_split == 1) return -1; + /* no QinQ support */ + if (rxmode->hw_vlan_extend == 1) + return -1; + return 0; #else RTE_SET_USED(dev); -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used 2017-04-13 9:53 ` [dpdk-stable] [PATCH v3] " Bernard Iremonger @ 2017-04-18 9:58 ` Ananyev, Konstantin 2017-04-18 10:04 ` Ferruh Yigit 0 siblings, 1 reply; 5+ messages in thread From: Ananyev, Konstantin @ 2017-04-18 9:58 UTC (permalink / raw) To: Iremonger, Bernard, dev Cc: Xing, Beilei, Lu, Wenzhuo, Zhang, Qi, Iremonger, Bernard, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, April 13, 2017 10:53 AM > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>; Iremonger, Bernard > <bernard.iremonger@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used > > In rx vector mode, QinQ is not supported. > When hw_vlan_extend is set for QinQ ensure that > rx vector mode is not selected. > > Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") > Cc: stable@dpdk.org > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > --- > Changes in v3: > Rebased to latest dpdk-next-net > Revised commit message. > > Changes in v2: > Rebased to latest dpdk-next-net > Updated Fixes line. > Added Cc: line > > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used 2017-04-18 9:58 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin @ 2017-04-18 10:04 ` Ferruh Yigit 2017-04-19 13:10 ` Ferruh Yigit 0 siblings, 1 reply; 5+ messages in thread From: Ferruh Yigit @ 2017-04-18 10:04 UTC (permalink / raw) To: Ananyev, Konstantin, Iremonger, Bernard, dev Cc: Xing, Beilei, Lu, Wenzhuo, Zhang, Qi, stable On 4/18/2017 10:58 AM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger >> Sent: Thursday, April 13, 2017 10:53 AM >> To: dev@dpdk.org >> Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>; Iremonger, Bernard >> <bernard.iremonger@intel.com>; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used >> >> In rx vector mode, QinQ is not supported. >> When hw_vlan_extend is set for QinQ ensure that >> rx vector mode is not selected. >> >> Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") >> Cc: stable@dpdk.org >> >> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used 2017-04-18 10:04 ` Ferruh Yigit @ 2017-04-19 13:10 ` Ferruh Yigit 0 siblings, 0 replies; 5+ messages in thread From: Ferruh Yigit @ 2017-04-19 13:10 UTC (permalink / raw) To: Ananyev, Konstantin, Iremonger, Bernard, dev Cc: Xing, Beilei, Lu, Wenzhuo, Zhang, Qi, stable On 4/18/2017 11:04 AM, Ferruh Yigit wrote: > On 4/18/2017 10:58 AM, Ananyev, Konstantin wrote: >> >> >>> -----Original Message----- >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger >>> Sent: Thursday, April 13, 2017 10:53 AM >>> To: dev@dpdk.org >>> Cc: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi <qi.zhang@intel.com>; Iremonger, Bernard >>> <bernard.iremonger@intel.com>; stable@dpdk.org >>> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix to ensure vector mode is not used >>> >>> In rx vector mode, QinQ is not supported. >>> When hw_vlan_extend is set for QinQ ensure that >>> rx vector mode is not selected. >>> >>> Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > Applied to dpdk-next-net/master, thanks. > Updated Fixes line to: Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-19 13:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com>
2017-04-12 15:28 ` [dpdk-stable] [PATCH v2] net/i40e: fix to ensure vector mode is not used Bernard Iremonger
2017-04-13 9:53 ` [dpdk-stable] [PATCH v3] " Bernard Iremonger
2017-04-18 9:58 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2017-04-18 10:04 ` Ferruh Yigit
2017-04-19 13:10 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).