From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from netronome.com (host-79-78-33-110.static.as9105.net [79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 72B592C01; Wed, 26 Apr 2017 12:27:08 +0200 (CEST) Received: from netronome.com (localhost [127.0.0.1]) by netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v3QAR8Uk025116; Wed, 26 Apr 2017 11:27:08 +0100 Received: (from alucero@localhost) by netronome.com (8.14.4/8.14.4/Submit) id v3QAR7su025115; Wed, 26 Apr 2017 11:27:07 +0100 From: Alejandro Lucero To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 26 Apr 2017 11:27:07 +0100 Message-Id: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-stable] [PATCH] nfp: fix mbuf releasing when segments X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 10:27:09 -0000 If segments are used, just mbufs previously linked to head descriptor of a mbuf chain are released. Other tx descriptor are used for the mbuf chain but they keep their linked mbufs without releasing them. It is not a fatal issue because sooner or later those descriptors will be head descriptors or just used for a single mbuf packet, then those linked mbufs will be released. However, this leads to apps needing bigger mbufs pools and some confusion about memory requeriments. Indeed, because larget pools, some performance impact could also be exptected due to cache misses. With this patch all tx descriptors will release linked mbufs inside the xmit function, and rte_pktmbuf_seg_free is used instead of rte_pktmbuf_free. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index eda87a5..5c5cba1 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2096,18 +2096,20 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq) */ pkt_size = pkt->pkt_len; - /* Releasing mbuf which was prefetched above */ - if (*lmbuf) - rte_pktmbuf_free(*lmbuf); - /* - * Linking mbuf with descriptor for being released - * next time descriptor is used - */ - *lmbuf = pkt; - while (pkt_size) { /* Copying TSO, VLAN and cksum info */ *txds = txd; + + /* Releasing mbuf used by this descriptor previously*/ + if (*lmbuf) + rte_pktmbuf_free_seg(*lmbuf); + + /* + * Linking mbuf with descriptor for being released + * next time descriptor is used + */ + *lmbuf = pkt; + dma_size = pkt->data_len; dma_addr = rte_mbuf_data_dma_addr(pkt); PMD_TX_LOG(DEBUG, "Working with mbuf at dma address:" @@ -2135,6 +2137,7 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq) } /* Referencing next free TX descriptor */ txds = &txq->txds[txq->wr_p]; + lmbuf = &txq->txbufs[txq->wr_p].mbuf; issued_descs++; } i++; -- 1.9.1