* [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup [not found] <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> @ 2017-04-27 9:41 ` Zhiyong Yang 2017-04-27 10:00 ` Maxime Coquelin 0 siblings, 1 reply; 4+ messages in thread From: Zhiyong Yang @ 2017-04-27 9:41 UTC (permalink / raw) To: dev; +Cc: yuanhan.liu, ciara.loftus, maxime.coquelin, stable, Zhiyong Yang vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed doesn't send the messge (The message needs to be sent only once)but still will be waiting for dpdk's reply ack, then, qemu is always freezing. DPDK code indeed works in the right way. The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by default at the dpdk side in order to avoid the feature support of DPDK + qemu at the same time. if doing like that, MQ can works well. Cc: stable@dpdk.org Reported-by: Ciara Loftus <ciara.loftus@intel.com> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> Tested-by: Ciara Loftus <ciara.loftus@intel.com> --- changes in V2 1. modify "workaround" instead of "fix" in the title. 2. add a simple comment suggested by yuanhan lib/librte_vhost/vhost_user.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h index 2ba22db..35ebd71 100644 --- a/lib/librte_vhost/vhost_user.h +++ b/lib/librte_vhost/vhost_user.h @@ -49,10 +49,14 @@ #define VHOST_USER_PROTOCOL_F_REPLY_ACK 3 #define VHOST_USER_PROTOCOL_F_NET_MTU 4 +/* + * disable REPLY_ACK feature to workaround the buggy QEMU implementation. + * Proved buggy QEMU includes v2.7 - v2.9. + */ #define VHOST_USER_PROTOCOL_FEATURES ((1ULL << VHOST_USER_PROTOCOL_F_MQ) | \ (1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD) |\ (1ULL << VHOST_USER_PROTOCOL_F_RARP) | \ - (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ + (0ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ (1ULL << VHOST_USER_PROTOCOL_F_NET_MTU)) typedef enum VhostUserRequest { -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup 2017-04-27 9:41 ` [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup Zhiyong Yang @ 2017-04-27 10:00 ` Maxime Coquelin 2017-04-28 4:29 ` Yuanhan Liu 0 siblings, 1 reply; 4+ messages in thread From: Maxime Coquelin @ 2017-04-27 10:00 UTC (permalink / raw) To: Zhiyong Yang, dev; +Cc: yuanhan.liu, ciara.loftus, stable On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > new connection when negotiating to set MQ. (one queue pair works > well). > Because there exist some bugs in qemu code when introducing > VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost > message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > doesn't send the messge (The message needs to be sent only once)but > still will be waiting for dpdk's reply ack, then, qemu is always > freezing. DPDK code indeed works in the right way. > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled > by default at the dpdk side in order to avoid the feature support of > DPDK + qemu at the same time. if doing like that, MQ can works well. > > Cc: stable@dpdk.org > > Reported-by: Ciara Loftus <ciara.loftus@intel.com> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > Tested-by: Ciara Loftus <ciara.loftus@intel.com> > --- > > changes in V2 > 1. modify "workaround" instead of "fix" in the title. > 2. add a simple comment suggested by yuanhan > > lib/librte_vhost/vhost_user.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup 2017-04-27 10:00 ` Maxime Coquelin @ 2017-04-28 4:29 ` Yuanhan Liu 2017-05-10 2:07 ` Yang, Zhiyong 0 siblings, 1 reply; 4+ messages in thread From: Yuanhan Liu @ 2017-04-28 4:29 UTC (permalink / raw) To: Maxime Coquelin; +Cc: Zhiyong Yang, dev, ciara.loftus, stable On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote: > > > On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > >new connection when negotiating to set MQ. (one queue pair works > >well). > > Because there exist some bugs in qemu code when introducing > >VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost > >message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > >doesn't send the messge (The message needs to be sent only once)but > >still will be waiting for dpdk's reply ack, then, qemu is always > >freezing. DPDK code indeed works in the right way. > > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled > >by default at the dpdk side in order to avoid the feature support of > >DPDK + qemu at the same time. if doing like that, MQ can works well. > > > >Cc: stable@dpdk.org > > > >Reported-by: Ciara Loftus <ciara.loftus@intel.com> > >Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > >Tested-by: Ciara Loftus <ciara.loftus@intel.com> > >--- > > > >changes in V2 > >1. modify "workaround" instead of "fix" in the title. > >2. add a simple comment suggested by yuanhan > > > > lib/librte_vhost/vhost_user.h | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Applied to dpdk-next-virtio. Thanks. --yliu ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup 2017-04-28 4:29 ` Yuanhan Liu @ 2017-05-10 2:07 ` Yang, Zhiyong 0 siblings, 0 replies; 4+ messages in thread From: Yang, Zhiyong @ 2017-05-10 2:07 UTC (permalink / raw) To: Yuanhan Liu, Maxime Coquelin; +Cc: dev, Loftus, Ciara, stable Hi, all: The patch which is used to fix the Qemu bug has been accepted in qemu community. http://patchwork.ozlabs.org/patch/760118/ Thanks Zhiyong > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Friday, April 28, 2017 12:29 PM > To: Maxime Coquelin <maxime.coquelin@redhat.com> > Cc: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org; Loftus, Ciara > <ciara.loftus@intel.com>; stable@dpdk.org > Subject: Re: [PATCH v2] vhost: workaround MQ fails to startup > > On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote: > > > > > > On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > > >new connection when negotiating to set MQ. (one queue pair works > > >well). > > > Because there exist some bugs in qemu code when introducing > > >VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the > vhost > > >message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > > >doesn't send the messge (The message needs to be sent only once)but > > >still will be waiting for dpdk's reply ack, then, qemu is always > > >freezing. DPDK code indeed works in the right way. > > > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by > > >default at the dpdk side in order to avoid the feature support of > > >DPDK + qemu at the same time. if doing like that, MQ can works well. > > > > > >Cc: stable@dpdk.org > > > > > >Reported-by: Ciara Loftus <ciara.loftus@intel.com> > > >Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > > >Tested-by: Ciara Loftus <ciara.loftus@intel.com> > > >--- > > > > > >changes in V2 > > >1. modify "workaround" instead of "fix" in the title. > > >2. add a simple comment suggested by yuanhan > > > > > > lib/librte_vhost/vhost_user.h | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Applied to dpdk-next-virtio. > > Thanks. > > --yliu ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-10 2:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com>
2017-04-27 9:41 ` [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup Zhiyong Yang
2017-04-27 10:00 ` Maxime Coquelin
2017-04-28 4:29 ` Yuanhan Liu
2017-05-10 2:07 ` Yang, Zhiyong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).