From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DEA2A567F for ; Tue, 2 May 2017 11:36:38 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2017 02:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,404,1488873600"; d="scan'208";a="1163483235" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2017 02:36:37 -0700 From: Yuanhan Liu To: Pablo de Lara Cc: Yuanhan Liu , Lei Yao , dpdk stable Date: Tue, 2 May 2017 17:32:23 +0800 Message-Id: <1493717548-12434-22-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1493717548-12434-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1493717548-12434-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'examples/l3fwd-power: fix Rx descriptor size' has been queued to LTS release 16.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 09:36:39 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/07/17. So please shout if anyone has objections. Thanks. --yliu --- >>From c71be06310edd9b7e54a986c62ea4701da648077 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Wed, 26 Apr 2017 12:29:52 +0100 Subject: [PATCH] examples/l3fwd-power: fix Rx descriptor size [ upstream commit 4175729d012914e1c10e5f54e5a59169be020124 ] L3fwd power app monitors the RX queues to see if the polling frequency should be adjusted (the busier the queue, the higher the frequency). The app uses several thresholds in the ring to determine the frequency, being 96 the highest one, when frequency should be highest. The problem is that the difference between this value and the ring size is not big enough (128 - 96 = 32 descriptors), which means that if the descriptors are not replenished quick enough, queue might not be busy, but the app would think that it is, because 96th descriptor is set. Therefore, by increasing this gap (increasing the RX ring size), we make sure that this false measurement will not happen. Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX queue count") Signed-off-by: Pablo de Lara Tested-by: Lei Yao --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f9a8c52..920a9fc 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -147,7 +147,7 @@ /* * Configurable number of RX/TX ring descriptors */ -#define RTE_TEST_RX_DESC_DEFAULT 128 +#define RTE_TEST_RX_DESC_DEFAULT 512 #define RTE_TEST_TX_DESC_DEFAULT 512 static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; -- 1.9.0