* [dpdk-stable] [PATCH] net/e1000: fix vf received problem
@ 2017-04-27 5:07 Qiming Yang
2017-04-27 5:41 ` Lu, Wenzhuo
2017-05-03 5:51 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
0 siblings, 2 replies; 5+ messages in thread
From: Qiming Yang @ 2017-04-27 5:07 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, stable, Qiming Yang
VF default MAC address be added in PF Mac address list
instead of VF MAC address list, makes VF can't recieve
packets. This patch fixes this issue.
Fixes: be2d648a2dd3 ("igb: add PF support")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/e1000/igb_pf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
index 67da3c2..1a70ad5 100644
--- a/drivers/net/e1000/igb_pf.c
+++ b/drivers/net/e1000/igb_pf.c
@@ -338,6 +338,9 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
sizeof(vfinfo[vf].vf_mac_addresses));
hw->mac.ops.rar_set(hw, new_mac, rar_entry);
+ int rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
+ rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
+ E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
return 0;
}
return -1;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] net/e1000: fix vf received problem
2017-04-27 5:07 [dpdk-stable] [PATCH] net/e1000: fix vf received problem Qiming Yang
@ 2017-04-27 5:41 ` Lu, Wenzhuo
2017-05-03 5:51 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
1 sibling, 0 replies; 5+ messages in thread
From: Lu, Wenzhuo @ 2017-04-27 5:41 UTC (permalink / raw)
To: Yang, Qiming, dev; +Cc: stable
Hi Qiming,
> -----Original Message-----
> From: Yang, Qiming
> Sent: Thursday, April 27, 2017 1:07 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming
> Subject: [PATCH] net/e1000: fix vf received problem
>
> VF default MAC address be added in PF Mac address list instead of VF MAC
> address list, makes VF can't recieve packets. This patch fixes this issue.
>
> Fixes: be2d648a2dd3 ("igb: add PF support")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/e1000/igb_pf.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index
> 67da3c2..1a70ad5 100644
> --- a/drivers/net/e1000/igb_pf.c
> +++ b/drivers/net/e1000/igb_pf.c
> @@ -338,6 +338,9 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev,
> uint32_t vf, uint32_t *msgbuf)
> rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
> sizeof(vfinfo[vf].vf_mac_addresses));
> hw->mac.ops.rar_set(hw, new_mac, rar_entry);
> + int rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
Looks a little weird to define rah here. Would you like to move it to the beginning? Thanks.
> + rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
> + E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
> return 0;
> }
> return -1;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-stable] [PATCH v2] net/e1000: fix VF received problem
2017-04-27 5:07 [dpdk-stable] [PATCH] net/e1000: fix vf received problem Qiming Yang
2017-04-27 5:41 ` Lu, Wenzhuo
@ 2017-05-03 5:51 ` Qiming Yang
2017-05-03 7:12 ` Lu, Wenzhuo
1 sibling, 1 reply; 5+ messages in thread
From: Qiming Yang @ 2017-05-03 5:51 UTC (permalink / raw)
To: dev; +Cc: stable, wenzhuo.lu, Qiming Yang
VF default MAC address be added in PF Mac address list
instead of VF MAC address list, makes VF can't receive
packets. This patch fixes this issue.
Fixes: be2d648a2dd3 ("igb: add PF support")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/e1000/igb_pf.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
index 67da3c2..923c78a 100644
--- a/drivers/net/e1000/igb_pf.c
+++ b/drivers/net/e1000/igb_pf.c
@@ -332,12 +332,16 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
*(E1000_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private));
int rar_entry = hw->mac.rar_entry_count - (vf + 1);
uint8_t *new_mac = (uint8_t *)(&msgbuf[1]);
+ int rah;
if (is_unicast_ether_addr((struct ether_addr *)new_mac)) {
if (!is_zero_ether_addr((struct ether_addr *)new_mac))
rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,
sizeof(vfinfo[vf].vf_mac_addresses));
hw->mac.ops.rar_set(hw, new_mac, rar_entry);
+ rah = E1000_READ_REG(hw, E1000_RAH(rar_entry));
+ rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));
+ E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah);
return 0;
}
return -1;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH v2] net/e1000: fix VF received problem
2017-05-03 5:51 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
@ 2017-05-03 7:12 ` Lu, Wenzhuo
2017-05-05 14:56 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Lu, Wenzhuo @ 2017-05-03 7:12 UTC (permalink / raw)
To: Yang, Qiming, dev; +Cc: stable
Hi,
> -----Original Message-----
> From: Yang, Qiming
> Sent: Wednesday, May 3, 2017 1:52 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo; Yang, Qiming
> Subject: [PATCH v2] net/e1000: fix VF received problem
>
> VF default MAC address be added in PF Mac address list instead of VF MAC
> address list, makes VF can't receive packets. This patch fixes this issue.
>
> Fixes: be2d648a2dd3 ("igb: add PF support")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH v2] net/e1000: fix VF received problem
2017-05-03 7:12 ` Lu, Wenzhuo
@ 2017-05-05 14:56 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-05-05 14:56 UTC (permalink / raw)
To: Yang, Qiming; +Cc: stable, Lu, Wenzhuo, dev
03/05/2017 09:12, Lu, Wenzhuo:
> Hi,
>
> > VF default MAC address be added in PF Mac address list instead of VF MAC
> > address list, makes VF can't receive packets. This patch fixes this issue.
> >
> > Fixes: be2d648a2dd3 ("igb: add PF support")
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-05 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 5:07 [dpdk-stable] [PATCH] net/e1000: fix vf received problem Qiming Yang
2017-04-27 5:41 ` Lu, Wenzhuo
2017-05-03 5:51 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
2017-05-03 7:12 ` Lu, Wenzhuo
2017-05-05 14:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).