From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AF7D899DE for ; Thu, 25 May 2017 11:52:21 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2017 02:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,391,1491289200"; d="scan'208";a="91624734" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 25 May 2017 02:52:20 -0700 From: Yuanhan Liu To: Olivier Matz Cc: Yuanhan Liu , Jingjing Wu , dpdk stable Date: Thu, 25 May 2017 17:49:41 +0800 Message-Id: <1495705809-21416-129-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'app/testpmd: fix crash at mbuf pool creation' has been queued to stable release 17.02.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 09:52:22 -0000 Hi, FYI, your patch has been queued to stable release 17.02.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/28/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 177d64aa560f71b9c18ff4c8a4500a0cafc21382 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 24 Apr 2017 14:33:57 +0200 Subject: [PATCH] app/testpmd: fix crash at mbuf pool creation [ upstream commit 3c1a5444d47c6c3e34c5c1a991c4a80835ba4f43 ] Since commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"), testpmd is started with numa enabled by default. This highlights a floating point exception when started with --total-num-mbufs without any port (division by 0). This bug was already triggered before this commit if the --no-numa option was given. This commit adds a check of the nb_ports value before doing the division. By looking at this code, it appears that the creation of the mbuf pool is not consistent for the number of mbufs depending on the configuration. This is fixed in the next commit. Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") Signed-off-by: Olivier Matz Acked-by: Jingjing Wu --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index fa19f8f..44611b2 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -573,7 +573,7 @@ init_config(void) uint8_t i; unsigned int nb_mbuf; - if (param_total_num_mbufs) + if (param_total_num_mbufs && nb_ports != 0) nb_mbuf_per_pool = nb_mbuf_per_pool/nb_ports; for (i = 0; i < max_socket; i++) { -- 1.9.0