From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 23ADC9A14 for ; Thu, 25 May 2017 11:52:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2017 02:52:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,391,1491289200"; d="scan'208";a="91624841" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 25 May 2017 02:52:40 -0700 From: Yuanhan Liu To: Adrien Mazarguil Cc: Yuanhan Liu , dpdk stable Date: Thu, 25 May 2017 17:50:02 +0800 Message-Id: <1495705809-21416-150-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'app/testpmd: fix stack overwriting by flow command' has been queued to stable release 17.02.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 09:52:42 -0000 Hi, FYI, your patch has been queued to stable release 17.02.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/28/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 8862cf4004ce706cb81f78aac1aa0912a53f11cb Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 4 May 2017 19:08:22 +0200 Subject: [PATCH] app/testpmd: fix stack overwriting by flow command [ upstream commit 138ae2481e437d7d1549cc59e5ad7129cd87a6a2 ] The parameter type parser function stores a stack-local address in the global parser context when parsing a "prefix" keyword. This usually translates to "Bad arguments" errors even for correct flow rules as stack gets overwritten by subsequent function calls. Fixes: d3f61b7bad20 ("app/testpmd: add flow item spec prefix length") Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index ff98690..12712fd 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -1715,6 +1715,8 @@ parse_vc_spec(struct context *ctx, const struct token *token, return -1; /* Parse parameter types. */ switch (ctx->curr) { + static const enum index prefix[] = NEXT_ENTRY(PREFIX); + case ITEM_PARAM_IS: index = 0; objmask = 1; @@ -1729,7 +1731,7 @@ parse_vc_spec(struct context *ctx, const struct token *token, /* Modify next token to expect a prefix. */ if (ctx->next_num < 2) return -1; - ctx->next[ctx->next_num - 2] = NEXT_ENTRY(PREFIX); + ctx->next[ctx->next_num - 2] = prefix; /* Fall through. */ case ITEM_PARAM_MASK: index = 2; -- 1.9.0