From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 620D99173 for ; Thu, 25 May 2017 11:50:46 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2017 02:50:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,390,1491289200"; d="scan'208";a="91624172" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 25 May 2017 02:50:45 -0700 From: Yuanhan Liu To: Alejandro Lucero Cc: Yuanhan Liu , dpdk stable Date: Thu, 25 May 2017 17:48:10 +0800 Message-Id: <1495705809-21416-38-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'net/nfp: clean Tx descriptor flags' has been queued to stable release 17.02.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 09:50:46 -0000 Hi, FYI, your patch has been queued to stable release 17.02.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/28/17. So please shout if anyone has objections. Thanks. --yliu --- >>From e0199f5a5e911916ebdff3b7357f0cc96aca7c12 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Tue, 21 Mar 2017 10:43:19 +0000 Subject: [PATCH] net/nfp: clean Tx descriptor flags [ upstream commit 2dfcada3eba1c1f5ddb275a48dd044476ac53825 ] When LSO, not doing this can led to firmware disruption. It does not show as error because TCP ends up sending data again later on. Fixes: 9ba3d0ae2090 ("net/nfp: add TSO support") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index d79f262..7b9b274 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -1665,16 +1665,22 @@ nfp_net_tx_tso(struct nfp_net_txq *txq, struct nfp_net_tx_desc *txd, struct nfp_net_hw *hw = txq->hw; if (!(hw->cap & NFP_NET_CFG_CTRL_LSO)) - return; + goto clean_txd; ol_flags = mb->ol_flags; if (!(ol_flags & PKT_TX_TCP_SEG)) - return; + goto clean_txd; txd->l4_offset = mb->l2_len + mb->l3_len + mb->l4_len; txd->lso = rte_cpu_to_le_16(mb->tso_segsz); - txd->flags |= PCIE_DESC_TX_LSO; + txd->flags = PCIE_DESC_TX_LSO; + return; + +clean_txd: + txd->flags = 0; + txd->l4_offset = 0; + txd->lso = 0; } /* nfp_net_tx_cksum - Set TX CSUM offload flags in TX descriptor */ -- 1.9.0