From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CDF0D9189 for ; Thu, 25 May 2017 11:51:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2017 02:51:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,391,1491289200"; d="scan'208";a="91624508" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 25 May 2017 02:51:40 -0700 From: Yuanhan Liu To: Ilya Maximets Cc: Yuanhan Liu , Eric Kinzie , Declan Doherty , dpdk stable Date: Thu, 25 May 2017 17:49:00 +0800 Message-Id: <1495705809-21416-88-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1495705809-21416-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-stable] patch 'net/bonding: allow configuring jumbo frames without slaves' has been queued to stable release 17.02.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 09:51:42 -0000 Hi, FYI, your patch has been queued to stable release 17.02.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/28/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 2fec0ef48c4ed30f4431cf0cb32f38cea3ddd788 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Fri, 7 Apr 2017 18:07:12 +0300 Subject: [PATCH] net/bonding: allow configuring jumbo frames without slaves [ upstream commit c32c2c06bc82b3977b7d16d50a5d7cdcfc7b7e76 ] Currently, 'rte_eth_dev_configure' fails on attempt to setup max_rx_pkt_len > 2048 if no slaves was added to bonded device. For example: rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id) conf.rxmode.jumbo_frame = 1; conf.rxmode.max_rx_pkt_len = 9000; rte_eth_dev_configure(id, 1, 1, &conf) Result: EAL: Initializing pmd_bond for eth_bond0 EAL: Create bonded device eth_bond0 on port 4 in mode 2 on socket 0. rte_eth_dev_configure: ethdev port_id=4 \ max_rx_pkt_len 9018 > max valid value 2048 It's expected that slaves will be added to bonded device inside 'rte_eth_dev_configure' and proper 'max_rx_pktlen' configured for all of them. Failure happens because of hardcoded low value of 'max_rx_pktlen'. Increasing of this value to ETHER_MAX_JUMBO_FRAME_LEN will allow above scenario (attach + configure). It is important because it is the way OVS wants to work with all DPDK devices (including virtual). Changing the default hardcoded value makes no harm because all the slaves' related code uses only 'candidate_max_rx_pktlen' variable. Fixes: 6cfc6a4f0d61 ("net/bonding: inherit maximum Rx packet length") Signed-off-by: Ilya Maximets Reviewed-by: Eric Kinzie Acked-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index f3ac9e2..8abcd07 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1664,8 +1664,9 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_mac_addrs = 1; - dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen ? - internals->candidate_max_rx_pktlen : 2048; + dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen + ? internals->candidate_max_rx_pktlen + : ETHER_MAX_JUMBO_FRAME_LEN; dev_info->max_rx_queues = (uint16_t)128; dev_info->max_tx_queues = (uint16_t)512; -- 1.9.0