From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 2351C2C8 for ; Tue, 20 Jun 2017 13:37:40 +0200 (CEST) Received: by mail-pg0-f66.google.com with SMTP id f127so20674532pgc.2 for ; Tue, 20 Jun 2017 04:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tZe1xjKUdgrkDdBTPLs9rBjO53i6/N8AQfEcfc6ItmU=; b=1FdeTlok3lqnt9/Mo1ZFe4IaQKxdmXDFs1CBOyuj+JP3mmQ8tAET91zdKkGVbReifE JVton+IWEbnADCGgElFHONvVKrLUTivJpNqGa8KvHlSg+on2HOk/IP1a1yeTBbGtYKFi rEHPHfI2pJv5l1iynVxFb+CSLLy4O/4J3arIKzTC29tPy1JPzKqBnBMJppincZrpwe4K ZzqovrR4VgS5K+C/uM4+c+icUlO9Lrsh+iFlmN8BeRn/7Jqp3w8aCYpeAANviSkP0mrI 1hF2Q86Xb4KDtMtAXcOhAfjN0hBegVVLNdXj2I3+k/2krRPM1FVvAiyaNiHWB4fE+AJa zGdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tZe1xjKUdgrkDdBTPLs9rBjO53i6/N8AQfEcfc6ItmU=; b=ib5/kxeHSBwQP5H3Ve7NcyAhffAe+9RcSr7JZFp7SPUesUMB0mrZooEJ6KvAroaFKI 8I2VapZQw6pvNkY61URQuX2zENAu+plf6fjMJqih32G+TubsqSn5EjmbPGRf+98g8rht Npri9i3ewjz+V2iNwnTZ+KqW3QdSSBTPGZFO593Uwp/sIZOrlQ/yjzqbk1mE7KsjX1Z3 5xDwWV63KKekVTdD90NWCHSQzudqgJjpdy8hTJAqYk71ZqG+9KeVw8XKMibGbE2e3G8B +j7rgQ59t2avlzjE2QVd3oJ8j1fFDJk1zOEw/QKYQdWFufLhum+ylElYsMMpsV9QvW5p e63Q== X-Gm-Message-State: AKS2vOxgBXEypAH3yWChVDCvP6kBMp/NKXugFzZR2ebGYXkBPmbIaGh4 f/97eh62jhcizajWdvLfVw== X-Received: by 10.99.48.7 with SMTP id w7mr10899619pgw.244.1497958660302; Tue, 20 Jun 2017 04:37:40 -0700 (PDT) Received: from yliu-home.localdomain ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id 25sm6104783pfj.59.2017.06.20.04.37.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 04:37:39 -0700 (PDT) From: Yuanhan Liu To: Yongseok Koh Cc: Nelio Laranjeiro , dpdk stable Date: Tue, 20 Jun 2017 19:35:35 +0800 Message-Id: <1497958550-13600-23-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497958550-13600-1-git-send-email-yliu@fridaylinux.org> References: <1497958550-13600-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix redundant free of Tx buffer' has been queued to stable release 17.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 11:37:41 -0000 Hi, FYI, your patch has been queued to stable release 17.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/22/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 39ea3ea6e718267b7c2520f6641b6cf6f5d0637e Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Wed, 31 May 2017 10:48:45 -0700 Subject: [PATCH] net/mlx5: fix redundant free of Tx buffer [ upstream commit c80711c3fbfdae1449ad1cbc6b31067087bd9561 ] SW completion ring of Tx (txq->elts) stores individual mbufs even if a multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when cleaning up the completion ring. Otherwise, chained mbufs are redundantly freed and finally it would cause a crash. Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 6c1387e..bf72468 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -117,7 +117,7 @@ txq_free_elts(struct txq_ctrl *txq_ctrl) struct rte_mbuf *elt = (*elts)[elts_tail]; assert(elt != NULL); - rte_pktmbuf_free(elt); + rte_pktmbuf_free_seg(elt); #ifndef NDEBUG /* Poisoning. */ memset(&(*elts)[elts_tail], -- 2.7.4