From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yliu@fridaylinux.org>
Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66])
by dpdk.org (Postfix) with ESMTP id 590EB9E3
for <stable@dpdk.org>; Tue, 20 Jun 2017 13:38:16 +0200 (CEST)
Received: by mail-pg0-f66.google.com with SMTP id f127so20678000pgc.2
for <stable@dpdk.org>; Tue, 20 Jun 2017 04:38:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=fridaylinux-org.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=XnszOIC90Lik5jZUXi2cEku19h3wjNwcLnnMJhqFAwM=;
b=y/qHZY6ITrIszY14fR/VHEluxBLjclKDW5grDUwf4nJ+7yRyjKsz1ChDLj/piwyiAC
5H5PTMKTf0Zhb2t0uHsTpuCTU8qBL2PDG1g1PhhAyR+nnDHiOxI5g4BRIJB+YxZ7jTyv
GpDiiQPOk/sAsc4O+Dw2bgIlDwVb5qzQh2Tyu6AJrzeJ36wMentCDEJTTcxXaGyIkVF/
Z6gokPNgcFPzbvtFk14qJITR9YuhMJDqJ+mCeq2jI/iYSquMfyFUsvluUezPH8uhaDuE
ZqdyWzXG2HkncJU0oMKrsfPYZYdV8HxheOuQRum1RI6+Mo/KnOibn6ZK6pBQV8lx/CkY
IO2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=XnszOIC90Lik5jZUXi2cEku19h3wjNwcLnnMJhqFAwM=;
b=QuiqcISBfWFtdAVYAHM7N6lGsjNNNWZjykX1fMTx4tpkLyMXP32bKbDcvoFR+NZjrD
ottnF1tLiPlJLOq63df4YpwLCg/51WowILSouekTAojnrEknI9WcGwSVt1sLvR41Kdsz
3bOOSC21Fra39i0Q/bnBaOQASfW1OXB+mOSYfwAfXk0ihgSfeJtRFXhUB4mE85d4zgdI
Xkm8ki54QegEn8cIrtr3AHf9STq/J/csq3rRpROupWwKXc+Vsl0b71pOQuZ5w4sxNfUM
2bOqq4cDBw6lIfbYbVAioRODeYwv8+splOqQYhbAXJHn2LvdnBK5vuQquyIftvei5Vsj
zBNw==
X-Gm-Message-State: AKS2vOxGS3J4HRhBMnmSWH9Ccxj0MM20+gAYk+ZvSDsazD4OaLlP/8Xs
8tZtqAFBdWfSY8k8sSt8qA==
X-Received: by 10.99.52.75 with SMTP id b72mr9185376pga.89.1497958695681;
Tue, 20 Jun 2017 04:38:15 -0700 (PDT)
Received: from yliu-home.localdomain ([45.63.61.64])
by smtp.gmail.com with ESMTPSA id 25sm6104783pfj.59.2017.06.20.04.38.07
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 20 Jun 2017 04:38:14 -0700 (PDT)
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Nirmoy Das <ndas@suse.de>, Markos Chandras <mchandras@suse.de>,
dpdk stable <stable@dpdk.org>
Date: Tue, 20 Jun 2017 19:35:43 +0800
Message-Id: <1497958550-13600-31-git-send-email-yliu@fridaylinux.org>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1497958550-13600-1-git-send-email-yliu@fridaylinux.org>
References: <1497958550-13600-1-git-send-email-yliu@fridaylinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] patch 'kni: fix build with gcc 7.1' has been queued
to stable release 17.05.1
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 11:38:16 -0000
Hi,
FYI, your patch has been queued to stable release 17.05.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/22/17. So please
shout if anyone has objections.
Thanks.
--yliu
---
>>From ee19232d41d6bc5b0e69484068396696446f265f Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tue, 13 Jun 2017 17:42:08 +0100
Subject: [PATCH] kni: fix build with gcc 7.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ upstream commit c3698192940ca9786cb2871272a585638c50d194 ]
build error:
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:
In function ‘igb_kni_probe’:
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:30:
error: ‘%d’ directive output may be truncated writing between 1 and 5
bytes into a region of size between 0 and 11
[-Werror=format-truncation=]
"%d.%d, 0x%08x, %d.%d.%d",
^~
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:8:
note: directive argument in the range [0, 65535]
"%d.%d, 0x%08x, %d.%d.%d",
^~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2481:4:
note: ‘snprintf’ output between 23 and 43 bytes into a destination of
size 32
snprintf(adapter->fw_version,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sizeof(adapter->fw_version),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%d.%d, 0x%08x, %d.%d.%d",
~~~~~~~~~~~~~~~~~~~~~~~~~~
fw.eep_major, fw.eep_minor, fw.etrack_id,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fw.or_major, fw.or_build, fw.or_patch);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixed by increasing buffer size to 43 as suggested in compiler log.
Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline")
Reported-by: Nirmoy Das <ndas@suse.de>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Markos Chandras <mchandras@suse.de>
---
lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
index d077b49..8667f29 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
@@ -607,7 +607,7 @@ struct igb_adapter {
int int_mode;
u32 rss_queues;
u32 vmdq_pools;
- char fw_version[32];
+ char fw_version[43];
u32 wvbr;
struct igb_mac_addr *mac_table;
#ifdef CONFIG_IGB_VMDQ_NETDEV
--
2.7.4