patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'vfio: fix array bounds check' has been queued to stable release 17.05.1
Date: Tue, 20 Jun 2017 19:35:16 +0800	[thread overview]
Message-ID: <1497958550-13600-4-git-send-email-yliu@fridaylinux.org> (raw)
In-Reply-To: <1497958550-13600-1-git-send-email-yliu@fridaylinux.org>

Hi,

FYI, your patch has been queued to stable release 17.05.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/22/17. So please
shout if anyone has objections.

Thanks.

	--yliu

---
>From 7b6546c7fd42c24a569ffdc4dfc7fe5b7d706a11 Mon Sep 17 00:00:00 2001
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Fri, 12 May 2017 11:18:25 +0100
Subject: [PATCH] vfio: fix array bounds check

[ upstream commit 4af00fb1a2449f23a7c0fc32159207ae68b0fbbb ]

Checking against VFIO_MAX_GROUPS goes beyond the maximum array
index which should be (VFIO_MAX_GROUPS - 1).

Coverity issue: 144555, 144556, 144557
Fixes: 94c0776b1bad ("support hotplug")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_vfio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c
index 53ac725..946df7e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
@@ -189,7 +189,7 @@ vfio_group_device_get(int vfio_group_fd)
 	int i;
 
 	i = get_vfio_group_idx(vfio_group_fd);
-	if (i < 0 || i > VFIO_MAX_GROUPS)
+	if (i < 0 || i > (VFIO_MAX_GROUPS - 1))
 		RTE_LOG(ERR, EAL, "  wrong vfio_group index (%d)\n", i);
 	else
 		vfio_cfg.vfio_groups[i].devices++;
@@ -201,7 +201,7 @@ vfio_group_device_put(int vfio_group_fd)
 	int i;
 
 	i = get_vfio_group_idx(vfio_group_fd);
-	if (i < 0 || i > VFIO_MAX_GROUPS)
+	if (i < 0 || i > (VFIO_MAX_GROUPS - 1))
 		RTE_LOG(ERR, EAL, "  wrong vfio_group index (%d)\n", i);
 	else
 		vfio_cfg.vfio_groups[i].devices--;
@@ -213,7 +213,7 @@ vfio_group_device_count(int vfio_group_fd)
 	int i;
 
 	i = get_vfio_group_idx(vfio_group_fd);
-	if (i < 0 || i > VFIO_MAX_GROUPS) {
+	if (i < 0 || i > (VFIO_MAX_GROUPS - 1)) {
 		RTE_LOG(ERR, EAL, "  wrong vfio_group index (%d)\n", i);
 		return -1;
 	}
-- 
2.7.4

  parent reply	other threads:[~2017-06-20 11:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 11:35 [dpdk-stable] patch 'examples/vhost: fix uninitialized descriptor indexes' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'kni: fix build on RHEL 7.4' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'drivers/net: fix vfio kmod dependency' " Yuanhan Liu
2017-06-20 11:35 ` Yuanhan Liu [this message]
2017-06-20 11:35 ` [dpdk-stable] patch 'app/testpmd: fix creating E-Tag and NVGRE flow rules' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ark: fix buffer not null terminated' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ark: fix return code not checked' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ark: fix null pointer dereference' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ark: fix return value of null not checked' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/i40e/base: fix Tx error stats on VF' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/af_packet: handle possible null pointer' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/af_packet: fix packet bytes counting' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/mlx5: fix completion buffer size' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/igb: fix add/delete of flex filters' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/tap: fix some flow collision' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/cxgbe: fix port statistics' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/cxgbe: fix rxq default params for ports under same PF' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/sfc/base: fix error code usage in common code' " Yuanhan Liu
2017-06-20 16:26   ` Andrew Rybchenko
2017-06-22  2:19     ` Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/sfc: add Tx queue flush failed flag for sanity' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/mlx5: fix flow application order on stop/start' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ring: fix adding MAC addresses' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/mlx5: fix exception handling' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/mlx5: fix redundant free of Tx buffer' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/igb: fix checksum valid flags' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/ixgbe: fix fdir mask not be reset' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/i40e: exclude internal packet's byte count' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/i40e: fix VF statistics' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/qede: fix VXLAN tunnel Tx offload flag setting' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/liquidio: fix MTU calculation from port configuration' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/bnxt: fix reporting of link status' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'kni: fix build with gcc 7.1' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/enic: " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/mlx5: " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'vhost: fix malloc size too small' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'vhost: fix guest pages memory leak' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'vhost: fix crash on NUMA' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'net/virtio: zero the whole memory zone' " Yuanhan Liu
2017-06-20 11:35 ` [dpdk-stable] patch 'lpm: fix index of tbl8' " Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497958550-13600-4-git-send-email-yliu@fridaylinux.org \
    --to=yliu@fridaylinux.org \
    --cc=alejandro.lucero@netronome.com \
    --cc=anatoly.burakov@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).