From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 1BBEA2C2B for ; Fri, 14 Jul 2017 12:35:21 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id z6so10578274pfk.3 for ; Fri, 14 Jul 2017 03:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mHMYr7oFlb7ENPqG3a83D/44112PRIHRwC2qRgCLHFw=; b=cM+QNKqDrjozxY3f0FJvCnlAbf/g/GiFFrNHXPVVU3xpnBC5Q9bhZU8fLRzmMnSVtJ Yq7q8VHfY8faDVslsgg4RThGdSUsd/pf9uuP/iddQydKSLKSBwmbxiDdJejkVoOVBO+R 98wqVDRRwpUZu2FWcvSMWajfIGaJVODiTUYonZLAc3scTg1XaAOsOJTOFso774hLKM8o N/FH57zjqKzUP/ynbRWdDNjwNNh59hyld2KJ0ae4D9diKRByFlbTMKTuTJdC9wvGn/Jy liMWz8EDHCZR/17RgOJekb/IN60+VSqveBtOml6srNE9ptH2d8DoWrmQAe1LA/OadHz8 toxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mHMYr7oFlb7ENPqG3a83D/44112PRIHRwC2qRgCLHFw=; b=M+NbzSOk+27cPO85DvLkOUFdwS6mZfoaTAFVSwysIhDoQ23VULRvRDrbxVVaY4sMjI qdMqIvDlYVPy9n+xAI4/BDYRlHE+ixwX1gxjhuzRh14xluBAU8w9UXn1mv7vQD5CajM/ N/esXYMJniBG3AW9G5Bul6Ql8TzM2rydEeM4x9QQKSlV2seRN1Og+lb4sbgX+hZiRGfS XFSrrbuHThOyHt3vCgTwavo5ecz2BihUT3RWY/IXooTxp5dqzjyANQ8Si7bCSsyFQh5J 0cC66e8yv7Lv5qIl8nUuGddtTvyqohMql/og0HM8hEoOTl4JyZtCV4BziUSu8QGYYmTQ IEhQ== X-Gm-Message-State: AIVw110mUraQZmd7q4SbIuKkMi5J8GcgRQaQZyVrmp+K4MTzpF5v0mFo FvQSv5opIm1UNTBL X-Received: by 10.84.132.2 with SMTP id 2mr15526391ple.190.1500028520443; Fri, 14 Jul 2017 03:35:20 -0700 (PDT) Received: from localhost.localdomain ([180.158.48.171]) by smtp.gmail.com with ESMTPSA id y205sm15273553pfb.124.2017.07.14.03.35.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 03:35:19 -0700 (PDT) From: Yuanhan Liu To: Ajit Khaparde Cc: Stephen Hurd , dpdk stable Date: Fri, 14 Jul 2017 18:33:35 +0800 Message-Id: <1500028450-25989-11-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> References: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix reporting of link status' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 10:35:21 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From fc8eecb2a34fe50654d62073e559d20a2790674e Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 8 Jun 2017 23:24:48 -0500 Subject: [PATCH] net/bnxt: fix reporting of link status [ upstream commit bc8ee8572e8e5f82e4cd695c107f3fbcc42a5674 ] This patch fixes incorrect reporting of link status 1) When link is down, set speed to zero. Otherwise a wrong non-zero speed will be displayed. 2) DAC cables can detect there is a signal, but it necessarily does not mean link is up. Code previously treated this as link up. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 07e7124..e7ae5c7 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -534,7 +534,7 @@ static int bnxt_hwrm_port_phy_qcfg(struct bnxt *bp, HWRM_CHECK_RESULT; link_info->phy_link_status = resp->link; - if (link_info->phy_link_status != HWRM_PORT_PHY_QCFG_OUTPUT_LINK_NO_LINK) { + if (link_info->phy_link_status == HWRM_PORT_PHY_QCFG_OUTPUT_LINK_LINK) { link_info->link_up = 1; link_info->link_speed = rte_le_to_cpu_16(resp->link_speed); } else { @@ -1436,7 +1436,7 @@ int bnxt_get_hwrm_link_config(struct bnxt *bp, struct rte_eth_link *link) link->link_speed = bnxt_parse_hw_link_speed(link_info->link_speed); else - link->link_speed = ETH_LINK_SPEED_10M; + link->link_speed = ETH_SPEED_NUM_NONE; link->link_duplex = bnxt_parse_hw_link_duplex(link_info->duplex); link->link_status = link_info->link_up; link->link_autoneg = link_info->auto_mode == -- 2.7.4