From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 538EC29CB for ; Fri, 14 Jul 2017 12:36:34 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id z6so10581739pfk.3 for ; Fri, 14 Jul 2017 03:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dIt89kqS4uWmfuv0UiVh3IW3gdzOFxczE6MsYs6CnrI=; b=jnpbDKmL5bca5S/1Qht1hKNxiOTJdhgvfN3f7qDqK9YLYcXBBe1KNiOiPDM8Eg27U7 fw/ltWo65UCMeCjaIYr0iygDfVmoEnCv8fqzg2bfuAsEiAnHM3efMqp7WzSRHZ9ftZYi PjiVA0GR5fgbtE3Xu9PL2H6x9duHNbQA47wmprYLSqb3orPzmUkdghAbz6JF5ce2HwIV kRu5aptRhUwEp/c7U/RBKctS17K2isWFR5+gqEjaBwHbK4EgJatkScS2DvcrcRYe+pvv yfhxWHUeuTpByQLh6GGuOmz6J8A6yHobrHeKnXYHNi1afaTu5CgZGnYkJSbXPGqhr7ck 5Ixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dIt89kqS4uWmfuv0UiVh3IW3gdzOFxczE6MsYs6CnrI=; b=JGH0BzKv/YdV8zBkez5rJ2KdQvsRyDe54mBnwoPP1RgFEwZRmXBoYo3Yb62u+22AqP xB5/teS6zkWrMmLAbsVNheJSzUHU2fv+yqwyK6gRyCWh0AsVnH3LU7S28xryGtchE85x qzuk1rgWHRJQ2IyaOfrsnfv19A9fBvETKBIVUuxVKoIC6F9yVHkBss3Oa3+ZMkt5ezxl XSKTELk3l2bP6k5h8UOwUrOX/iKNNNN0XAw+2X9nC6nR39lfyeTXjiJsuwYL0JWgoTQQ kzYNP9EeQP6og06VdEG/1lcZUQmiexGxwtdt+7qbePAz7ozhTxfduvNnmft/UgrVIWJw OCqQ== X-Gm-Message-State: AIVw111neGWEX9xfbjUZPI7hrPcyG3qdIjNHaElTZyt+jrdz7OGZDwlR VhThF5CHlaDKgH73txBRP4/H X-Received: by 10.99.150.2 with SMTP id c2mr13889742pge.166.1500028593667; Fri, 14 Jul 2017 03:36:33 -0700 (PDT) Received: from localhost.localdomain ([180.158.48.171]) by smtp.gmail.com with ESMTPSA id y205sm15273553pfb.124.2017.07.14.03.36.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 03:36:32 -0700 (PDT) From: Yuanhan Liu To: Ajit Khaparde Cc: Stephen Hurd , dpdk stable Date: Fri, 14 Jul 2017 18:33:58 +0800 Message-Id: <1500028450-25989-34-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> References: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix get link config' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 10:36:34 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From f573b96b45558a4b1df01ea73d4128096cdca4df Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Fri, 30 Jun 2017 09:20:18 -0500 Subject: [PATCH] net/bnxt: fix get link config [ upstream commit 3bf11d86deed48e3a51092e778e845c963ac4792 ] This patch fixes the get link configuration code. bnxt_get_hwrm_link_config was using wrong macros and wrongly deriving link speed based on link status which was causing incorrect link information to be displayed in few scenarios. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index e7ae5c7..c8a87c8 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -534,13 +534,10 @@ static int bnxt_hwrm_port_phy_qcfg(struct bnxt *bp, HWRM_CHECK_RESULT; link_info->phy_link_status = resp->link; - if (link_info->phy_link_status == HWRM_PORT_PHY_QCFG_OUTPUT_LINK_LINK) { - link_info->link_up = 1; - link_info->link_speed = rte_le_to_cpu_16(resp->link_speed); - } else { - link_info->link_up = 0; - link_info->link_speed = 0; - } + link_info->link_up = + (link_info->phy_link_status == + HWRM_PORT_PHY_QCFG_OUTPUT_LINK_LINK) ? 1 : 0; + link_info->link_speed = rte_le_to_cpu_16(resp->link_speed); link_info->duplex = resp->duplex; link_info->pause = resp->pause; link_info->auto_pause = resp->auto_pause; @@ -1432,7 +1429,7 @@ int bnxt_get_hwrm_link_config(struct bnxt *bp, struct rte_eth_link *link) "Get link config failed with rc %d\n", rc); goto exit; } - if (link_info->link_up) + if (link_info->link_speed) link->link_speed = bnxt_parse_hw_link_speed(link_info->link_speed); else @@ -1441,7 +1438,7 @@ int bnxt_get_hwrm_link_config(struct bnxt *bp, struct rte_eth_link *link) link->link_status = link_info->link_up; link->link_autoneg = link_info->auto_mode == HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_NONE ? - ETH_LINK_SPEED_FIXED : ETH_LINK_SPEED_AUTONEG; + ETH_LINK_FIXED : ETH_LINK_AUTONEG; exit: return rc; } -- 2.7.4