From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id DCA5729CB for ; Fri, 14 Jul 2017 12:36:41 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id e199so10571928pfh.0 for ; Fri, 14 Jul 2017 03:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tebvui9R956kKzLYSjSAc3VjaXT/4upJShdxu1zt4vk=; b=MyM91pyOblHSW1QvbYh+NBpTKAghSyl+xC/VmZNIRPHauI0kwDij7juhn6GKyPnP5u /LYl7HEPOvEoAiSu09ugGaD0LyoMIL8M/nv8hjsxYIxX0Ii2As9QqNIBUEZCkk4hCOUo 3OKKZ5ayd/iYoNIlEjoU6Frlc5rjsCYpPfKYIOxpv2bHGMfi0XBBUDEgO3Mp6znzTjt9 DCyDfKuDnldSNBftenJCGjZDN5O0rq8iESpF7UbxqbbWJ1t0Am2SKfcUJwcbvgB1GCba 7WHzBhSLRhh1d6jTtibzfSCF6xtMRmjG7A2SY09Y9e/M4zDE1JzcEktq8FCzKaFUhu7v Mn5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tebvui9R956kKzLYSjSAc3VjaXT/4upJShdxu1zt4vk=; b=CsFp1jSQl/CFdQRjZgITyA/jbKa6P/MSl5+ZdO9e219IsCdfvGYOivmSE0wX7SiA3s sUUWSJANQOAIPZJF4tQhBBrEMxIBZTNDhk0osQ+K8o7FSzvUflrwcsAnhBIaLFq8zQiD Qipuj8jH3hc48r6EGjCeAksO9GIzZqWdbdnT+S+ozXfhTvqEYimWeG1CcUM9fdmw0VRr bDvE1hVL1J4rqArCgfYFWFMA9B/CcAYaE+Iakz6310SSpeZytdhqglIBifRAajE3+gjD RNj3Y9VuBghKihH2Bsl1L934IKIpe3ru8IensRdB+8XVH3ime38c2IRj6YiSjuS46XkZ TbEQ== X-Gm-Message-State: AIVw1125YgSB8Ghtz4b15NSf25pMyk/PMuKryIm7j4v2JEk6Ra7nI5No 6go14d/tpClX1uv8 X-Received: by 10.101.90.3 with SMTP id y3mr13932547pgs.185.1500028601234; Fri, 14 Jul 2017 03:36:41 -0700 (PDT) Received: from localhost.localdomain ([180.158.48.171]) by smtp.gmail.com with ESMTPSA id y205sm15273553pfb.124.2017.07.14.03.36.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 03:36:40 -0700 (PDT) From: Yuanhan Liu To: Ajit Khaparde Cc: Stephen Hurd , dpdk stable Date: Fri, 14 Jul 2017 18:34:00 +0800 Message-Id: <1500028450-25989-36-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> References: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix set link config' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 10:36:42 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 30746283838f1b9d6b96493d2fbd0b20883f56fa Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Fri, 30 Jun 2017 09:20:20 -0500 Subject: [PATCH] net/bnxt: fix set link config [ upstream commit 63d499f0c4ad4f02d8c7bbd0e36b57a97307ba71 ] bnxt_hwrm_port_phy_cfg() was not setting enables appropriately. This was causing undesired issues with link config. This patch takes care of that. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index c26837c..fef010f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -476,6 +476,8 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf) struct hwrm_port_phy_cfg_input req = {0}; struct hwrm_port_phy_cfg_output *resp = bp->hwrm_cmd_resp_addr; uint32_t enables = 0; + uint32_t link_speed_mask = + HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_LINK_SPEED_MASK; HWRM_PREP(req, PORT_PHY_CFG, -1, resp); @@ -487,14 +489,20 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf) * any auto mode, even "none". */ if (!conf->link_speed) { - req.auto_mode |= conf->auto_mode; - enables = HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_MODE; - req.auto_link_speed_mask = conf->auto_link_speed_mask; - enables |= - HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_LINK_SPEED_MASK; - req.auto_link_speed = bp->link_info.auto_link_speed; - enables |= + req.auto_mode = conf->auto_mode; + enables |= HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_MODE; + if (conf->auto_mode == + HWRM_PORT_PHY_CFG_INPUT_AUTO_MODE_SPEED_MASK) { + req.auto_link_speed_mask = + conf->auto_link_speed_mask; + enables |= link_speed_mask; + } + if (bp->link_info.auto_link_speed) { + req.auto_link_speed = + bp->link_info.auto_link_speed; + enables |= HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_LINK_SPEED; + } } req.auto_duplex = conf->duplex; enables |= HWRM_PORT_PHY_CFG_INPUT_ENABLES_AUTO_DUPLEX; -- 2.7.4