From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id EA7162935 for ; Fri, 14 Jul 2017 12:37:09 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id q85so10558521pfq.2 for ; Fri, 14 Jul 2017 03:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CxsrhSjmr1wvg96lOtRJFExKn78SH7toklJffwFeynU=; b=GWMM0SVSUb1rX8XXzLS8yguj8RLuG9nFiN+Yz3ieW9H4jb2DmBm62yQ32gMxBixLm2 8tOMLlrExy4q3ZtqZRA4qDTVxiVobSMK3OJhVN45NlMntBAAKJ0jTNlp4ffX3J9r6D37 m+mknKhoHdoPjSEPhFM5KzSbCbU6G58urWurO9o+uYDneGx6dJ9k+PjLp+6H+pHaX5Cf cae52ylTGOM6pLO8ZU6ZmOnAZ0YjGz51tLvayNEyU07rrK2CJrGNIDR5H6vszxrMM/GG LaroaDzjQDkHI08q5TZEtJ27DO+cGGiIOz+nE/nzF5PVXQOO9uzvDHwDxIQTgzcXRi52 +LMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CxsrhSjmr1wvg96lOtRJFExKn78SH7toklJffwFeynU=; b=ovInX5ZrPC2dqMan2dsgZXSi8baUIbO9uAQHEEKc3g25kT90EzyPZfhBLa3WPB2mlE YkBR12YpXsB6xw5zw6qJjwaDdKF1S85FUKsKca5u+xFZb2ypWS3aTHxopz+apQvxj4cV SCKoZqU+XQ8ENTmkYSPWTLlWVHbrgGTwR7fyE3k4121erdQaiRnAiejAE6U5/HwD1kDY p+AobshNg3BaTaIJWEyufYoBCw9Mqw+SCfPQDNV5xvVh9AFMlr/VpWqvMVz3MTYl9P2P FrU3JNaijbrmM5kRtaFPnIELh5J3KKF2PW84HUZMzwRQmov+d9k393L5PrYdQbBWb68+ mAhA== X-Gm-Message-State: AIVw1131XMzhW2FrQIAj3GyRaCGAGN3sN0iyB0oF91MBKjZFusfOySyB GASGgVycDLYOMjJB X-Received: by 10.98.10.153 with SMTP id 25mr4574057pfk.200.1500028629287; Fri, 14 Jul 2017 03:37:09 -0700 (PDT) Received: from localhost.localdomain ([180.158.48.171]) by smtp.gmail.com with ESMTPSA id y205sm15273553pfb.124.2017.07.14.03.37.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 03:37:08 -0700 (PDT) From: Yuanhan Liu To: Allain Legacy Cc: Yuanhan Liu , dpdk stable Date: Fri, 14 Jul 2017 18:34:08 +0800 Message-Id: <1500028450-25989-44-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> References: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/virtio-user: fix crash when detaching device' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 10:37:10 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 3408bd4476dba421003947c950b98690738f26d7 Mon Sep 17 00:00:00 2001 From: Allain Legacy Date: Fri, 23 Jun 2017 08:41:37 -0400 Subject: [PATCH] net/virtio-user: fix crash when detaching device [ upstream commit 2a7b7d837ff70b6a58221924aa885eb0daf7f2c9 ] The rte_eth_dev.data pointer is set to a reference to a static table. Attempting to rte_free() it leads to a panic. For example, the following commands result in a panic if run in testpmd testpmd> port attach virtio_user0,path=/dev/vhost-net,iface=test0 testpmd> port stop 2 testpmd> port close 2 testpmd> port detach 2 Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Signed-off-by: Allain Legacy Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_user_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index f018724..b1bd623 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -479,7 +479,6 @@ virtio_user_pmd_remove(const char *name) virtio_user_dev_uninit(dev); rte_free(eth_dev->data->dev_private); - rte_free(eth_dev->data); rte_eth_dev_release_port(eth_dev); return 0; -- 2.7.4