From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id 6DEC529CB for ; Fri, 14 Jul 2017 12:35:08 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id c24so10584246pfe.1 for ; Fri, 14 Jul 2017 03:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mrvH+ClhgAeb0ZukEHoOLV0g8DGQpQheOid1qOlG2Ic=; b=dfRea21x0IRCnP5ePU57NtWkUsEY8VZg90/NgQqp4ieaI0V+nwRMkST0624zmCvUb6 9LRTgWnu9OuoX+CY6QfgsShX9k6l+V/kzP9DgFbruFozJD9y9ifgIueZEExafoSbbjTA TC1FbYzsFXng0rFQryDZYGeqa1JXnQ8XkkDuD9h3iiO4JvZ5PVLZKIECOmltkCZMncsk v86Aah3Q4DDOOkPWDwFh+6iR/JT+UUT+hHMH8G/iq1enO6g4LZ/h34ZC7bb4i7tXbaTW 5O+OOxVhPzQ3OWKuq3J6fkhlwaCFy6FWm4V+qHjqq9imexJwRBb2DXFB+f2N69F3ilSR p8Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mrvH+ClhgAeb0ZukEHoOLV0g8DGQpQheOid1qOlG2Ic=; b=lTX2D76raVz66Wf/h01WhC4IldQ7nU0AIHU8VGBZLyqjWw4p59qRW9XMpQD58t9z2g NoL8hDijSn9rIAGBMQve/fSJGMbrcF3MvXK8nT19Xox/FitSIWGxcoAMviU1b6Rbm0J6 +n0fIpgaKHD2u7MwXps5xNYrjfJI6Z2PsSk7c49JpwRsmJJaWz6hj1CvAPL16VMoIGtF aff2uMPoyEP0xqdwY2MxSf6CfPpFc5TDjsyZjce+p5PZGhf67htaVcFlNFxfjUOfQvyG +gbAp1kXdbDCkF1pvktjn20KofW/Mzh/5iI4y9aByxh9UjbZcsEhiUXlyhvMtM7wJ/jM N2Pw== X-Gm-Message-State: AIVw111CrjZpS3EVF0o+sZZPI2lF5pbZtlnoavy30Or8DYQWPfDzszUf a7kTWXPdod/CpORo X-Received: by 10.98.25.8 with SMTP id 8mr4524335pfz.80.1500028507758; Fri, 14 Jul 2017 03:35:07 -0700 (PDT) Received: from localhost.localdomain ([180.158.48.171]) by smtp.gmail.com with ESMTPSA id y205sm15273553pfb.124.2017.07.14.03.35.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Jul 2017 03:35:06 -0700 (PDT) From: Yuanhan Liu To: Yongseok Koh Cc: Nelio Laranjeiro , dpdk stable Date: Fri, 14 Jul 2017 18:33:31 +0800 Message-Id: <1500028450-25989-7-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> References: <1500028450-25989-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix redundant free of Tx buffer' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 10:35:08 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 5990e4c0b48e1e3e1dbbf4bd087b0b65891cf73f Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Wed, 31 May 2017 10:48:45 -0700 Subject: [PATCH] net/mlx5: fix redundant free of Tx buffer [ upstream commit c80711c3fbfdae1449ad1cbc6b31067087bd9561 ] SW completion ring of Tx (txq->elts) stores individual mbufs even if a multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when cleaning up the completion ring. Otherwise, chained mbufs are redundantly freed and finally it would cause a crash. Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index a31e4e5..d0c4dce 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -115,7 +115,7 @@ txq_free_elts(struct txq_ctrl *txq_ctrl) struct rte_mbuf *elt = (*elts)[elts_tail]; assert(elt != NULL); - rte_pktmbuf_free(elt); + rte_pktmbuf_free_seg(elt); #ifndef NDEBUG /* Poisoning. */ memset(&(*elts)[elts_tail], -- 2.7.4