From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id CB181276C for ; Sat, 15 Jul 2017 13:18:22 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id q85so13896020pfq.2 for ; Sat, 15 Jul 2017 04:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5tfrU01qTpwUXSb6aLZndbszqU/c8PdY1vb5XDEREdM=; b=un+n6HGOugY8up1Tbx3EN2ibrHT04UMtSpV3nCp/a4u2t0Bj/sx7jUemmIB4jLXW71 hs0ebyGSgvz5j/64S0kWzLaauju5zDojYybDsunUEzLWCFVZEWblvGjYTNGK3ZKWRHSa 6KIftDKS8GNnGHR5V/2MAtGHr+Jeu5BU/PuZld6SCp+1MErU8vTfm9weB7AqTMSf6Gq0 fo5Fs7F+wbsGOW6rn50eg+qD6Agr2ja6s835aeHInp/fkFKerBL3mN5xilWDjoqxFYrv Tzct6BaHQkxSM79d4AVyaNi55B0W8TCWi7+u/3T5m9tGY+B9wORuWOX5ic0lFnfAKLBq I9+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5tfrU01qTpwUXSb6aLZndbszqU/c8PdY1vb5XDEREdM=; b=n/8Qh52PEVAYaDBVfS4hxwoanw2pB2/xyz9FFuZboj7vJS+ZGzsXnQmky93XV7DsPO tM+R9iobt56cq1ZQfDNQ4fwSYwotun87QddGVDS89D0NhpDr0g5kx7ADbZmU0z3Ci/kX Np88De4+nzQ8mtxQQ/d3wIkn1kkzf7S1heQaT8KA10Sdm1XUPJQqmTgfF2yDwUhlZ69j H3QV3747voU/GDjDxLr02j4OXixzUoPaVuQPhsaIHaVrU/+e6b5BSpDS3YwDgjBtFNyo mFTBEB0T07vtB4G7MohbBaej/QzSP64Ksvzw3aFjSpFyuApuSGkQ18T4QHUZasZjraHo e6GA== X-Gm-Message-State: AIVw113jvpuRiR0y9LWMl4AlRVKiTXmCBaaNwSX+h3PlZLLqf6yHz+Im CI3+Zhb+L1jVj9q5XmjHIQ== X-Received: by 10.84.133.73 with SMTP id 67mr21130341plf.125.1500117502163; Sat, 15 Jul 2017 04:18:22 -0700 (PDT) Received: from localhost.localdomain ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id k194sm19000874pgc.31.2017.07.15.04.18.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 15 Jul 2017 04:18:21 -0700 (PDT) From: Yuanhan Liu To: Stephen Hemminger Cc: dpdk stable Date: Sat, 15 Jul 2017 19:17:13 +0800 Message-Id: <1500117433-28932-7-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500117433-28932-1-git-send-email-yliu@fridaylinux.org> References: <1500117433-28932-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/virtio: do not claim to support LRO' has been queued to LTS release 16.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 11:18:23 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/19/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 0bf3bae65540f7fd662630722986d9a3e356498d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 7 Jul 2017 12:52:50 -0700 Subject: [PATCH] net/virtio: do not claim to support LRO [ backported from upstream commit 701a64622c2653c0736042d2f790081db79afdc7 ] The current virtio supports Transmit Segmentation Offload, but does not really support Large Receive Offload. The driver was confusing the two offloads. Fixes: 86d59b21468a ("net/virtio: support LRO") Signed-off-by: Stephen Hemminger Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index e86d12e..67ebb1e 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1477,11 +1477,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) { const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; struct virtio_hw *hw = dev->data->dev_private; - uint64_t req_features; - int ret; PMD_INIT_LOG(DEBUG, "configure"); - req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; /* Virtio does L4 checksum but not L3! */ if (rxmode->hw_ip_checksum) { @@ -1489,23 +1486,10 @@ virtio_dev_configure(struct rte_eth_dev *dev) "virtio does not support IP checksum"); return -ENOTSUP; } - if (rxmode->enable_lro) - req_features |= - (1ULL << VIRTIO_NET_F_GUEST_TSO4) | - (1ULL << VIRTIO_NET_F_GUEST_TSO6); - - /* if request features changed, reinit the device */ - if (req_features != hw->req_guest_features) { - ret = virtio_init_device(dev, req_features); - if (ret < 0) - return ret; - } - if (rxmode->enable_lro && - (!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4) || - !vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4))) { + if (rxmode->enable_lro) { PMD_DRV_LOG(NOTICE, - "lro not available on this host"); + "virtio does not support Large Receive Offload"); return -ENOTSUP; } @@ -1712,8 +1696,8 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) }; dev_info->rx_offload_capa = DEV_RX_OFFLOAD_TCP_CKSUM | - DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_LRO; + DEV_RX_OFFLOAD_UDP_CKSUM; + dev_info->tx_offload_capa = 0; if (hw->guest_features & (1ULL << VIRTIO_NET_F_CSUM)) { -- 2.7.4