From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f47.google.com (mail-pg0-f47.google.com [74.125.83.47]) by dpdk.org (Postfix) with ESMTP id 5BEC82BA1 for ; Mon, 21 Aug 2017 11:33:07 +0200 (CEST) Received: by mail-pg0-f47.google.com with SMTP id u191so22441216pgc.2 for ; Mon, 21 Aug 2017 02:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=wkJyxCUc3Qp50XL1ZYyBxR7W+1sVlW3qvL3DjUhucLs=; b=mN91R00RmdoIaTBuBIKzjqRX4eWfOIFPSsDrgpnY9izyd1F9lRjwN2J3CXnfEHTSID Sdl5Xw/F2yly07gziwaGIHhoitB35r09/FAVYGleRbRVNCf40CM5FbMucLCnfDFnFCNN LoLLY6IH23NM1iBHU6mkxzRdqUr2g4OGQ7rlT6bvGqonzBIYzZJR/p9koz7KTxpCwJfs YFDd0zPYw3WpP59n316zqZDfwarJdppxx17uaY/8MbxUASxHp7OQ3KgEkMyScU3X0nL5 +bxg6Hpun2V90TeRFYFFkE6INpiglo8Vfh6R1ztcSOH8jcd7PBKWcm6I/HX30Xjb6Dru 7cOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wkJyxCUc3Qp50XL1ZYyBxR7W+1sVlW3qvL3DjUhucLs=; b=IecogJCuCZr6LkOHaQ97TY0jSexsttM1ofGiRpF8Dq3F14CB7W34NbMmxrC79rpLHe UXVfITiTUNK9UMKVKCsyRttSufx+ppRckC0DrVnWPlk0sI/nEpyNfN0w5isB+C9616Tp qZGf8pZlPKhuXkL8HaupJwDgO9CjjZ04zzEfK+CcTy3N2e1GG73g9/MwlJRiQb8fTOrw BEgm3KXFeZRr4E7OobxpAs7+zasl6slee/pFQoYBubazfXfmSFO6wr7sj5REVz6aXaZL Q8NoRiuGLbbjiyIuRtxMUVQwqWzODnb2AXoxgr9QtOuhYA6a0rVvd6RakTcBv+R07Ahk lVUw== X-Gm-Message-State: AHYfb5iAQWpJ2deJskjxbuQRB/BGv97HlasgDgAflVVeqUg8pshDvYYU 070CU0jJch3ElyituVahPQ== X-Received: by 10.84.224.142 with SMTP id s14mr1877761plj.189.1503307986540; Mon, 21 Aug 2017 02:33:06 -0700 (PDT) Received: from localhost.localdomain ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id 69sm23355087pfh.186.2017.08.21.02.33.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Aug 2017 02:33:05 -0700 (PDT) From: Yuanhan Liu To: Stephen Hemminger Cc: Yuanhan Liu , dpdk stable , Yuanhan Liu Date: Mon, 21 Aug 2017 17:30:15 +0800 Message-Id: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-stable] patch 'net/virtio: do not claim to support LRO' has been queued to stable release 17.05.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 09:33:07 -0000 Hi, FYI, your patch has been queued to stable release 17.05.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 6de4d8eee1aafaf8eb8316501aa87d9874cf83bc Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 7 Jul 2017 12:52:50 -0700 Subject: [PATCH] net/virtio: do not claim to support LRO [ upstream commit 701a64622c2653c0736042d2f790081db79afdc7 ] The current virtio supports Transmit Segmentation Offload, but does not really support Large Receive Offload. The driver was confusing the two offloads. Fixes: 86d59b21468a ("net/virtio: support LRO") Signed-off-by: Stephen Hemminger Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 1651c59..d65667c 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1659,11 +1659,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) { const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; struct virtio_hw *hw = dev->data->dev_private; - uint64_t req_features; - int ret; PMD_INIT_LOG(DEBUG, "configure"); - req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; /* Virtio does L4 checksum but not L3! */ if (rxmode->hw_ip_checksum) { @@ -1671,23 +1668,10 @@ virtio_dev_configure(struct rte_eth_dev *dev) "virtio does not support IP checksum"); return -ENOTSUP; } - if (rxmode->enable_lro) - req_features |= - (1ULL << VIRTIO_NET_F_GUEST_TSO4) | - (1ULL << VIRTIO_NET_F_GUEST_TSO6); - - /* if request features changed, reinit the device */ - if (req_features != hw->req_guest_features) { - ret = virtio_init_device(dev, req_features); - if (ret < 0) - return ret; - } - if (rxmode->enable_lro && - (!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4) || - !vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4))) { + if (rxmode->enable_lro) { PMD_DRV_LOG(NOTICE, - "lro not available on this host"); + "virtio does not support Large Receive Offload"); return -ENOTSUP; } @@ -1913,8 +1897,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) } tso_mask = (1ULL << VIRTIO_NET_F_GUEST_TSO4) | (1ULL << VIRTIO_NET_F_GUEST_TSO6); - if ((host_features & tso_mask) == tso_mask) - dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO; dev_info->tx_offload_capa = 0; if (hw->guest_features & (1ULL << VIRTIO_NET_F_CSUM)) { -- 2.7.4