From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f42.google.com (mail-pg0-f42.google.com [74.125.83.42]) by dpdk.org (Postfix) with ESMTP id 47B577D7A for ; Mon, 21 Aug 2017 11:34:00 +0200 (CEST) Received: by mail-pg0-f42.google.com with SMTP id t3so68808082pgt.0 for ; Mon, 21 Aug 2017 02:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8IDz8CAHZsaPjd3y7SFRSibK7ohlLsphVSG+25B/ZpY=; b=0qp5tGSfggrnLH/SPyFWEtTfWYXgYedV4cNUouJkcwvxFBVGvaUX/H4lwWzjoo1ize 3sNG1JpAvlJkG8vUlazyCtHOexsRqkQ4oJHhpCLkIUuTEpfuNa4sYJf0fzjPQhhBddcw uRkSag+q7hzIJwfUfohBAkK4+unKO6C2F0BGO7nO1+jnpjoH6GgEM1aEJbFaDRkthaQF ilBONK5N/bkQRiJP6mEf3l0xWt0uFAjC9do/fxGt02FBVz+q0F8dHiVT7n3AgTqCA3wf fbLCOvWIu0Bh7xM9/OeBShl5dQfRCets//a9FvV+P5MsI69otEHvb/VJzy8arenGjHNO 1jtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8IDz8CAHZsaPjd3y7SFRSibK7ohlLsphVSG+25B/ZpY=; b=oBRjYQ+rlznGsQdTZSg8Fx++uB4ZrtaRNnOaFmvWHLhyCqKS0mXkTu08X7MSCZaD3J WF9EPxUHaRseVPGk6zGmj0zs4dhO/g87GLQJXTotGUdTVcQDrjDS8VhWQIkHs+4JPnSE xvSMbfBfgI33lFCsH+h4CJFTWqK6syp6GPsvZyk6wKy+vVKVN1pR1A+r7a7CGdiSEKYD cLJns31AAxg8ZmagexXxoRu5WDUO7350mnfPkYFb9tRjo6LvEvwFqXRLCCvsvCvgyH4Y 3sJrfa6wai1QO94eBDDAx5avnpRjvznao3bXL+fWnq4v496Kvuv4/GdiLoMT3gFGobQo XA7w== X-Gm-Message-State: AHYfb5gfMdpefVL4wNmAhlE8gYvSo/MnF3pjh6ZETopE/hxJeBweoA+T f30kzrxT7X9KPOYwSQvWTA== X-Received: by 10.84.236.77 with SMTP id h13mr14240827pln.349.1503308039507; Mon, 21 Aug 2017 02:33:59 -0700 (PDT) Received: from localhost.localdomain ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id 69sm23355087pfh.186.2017.08.21.02.33.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Aug 2017 02:33:58 -0700 (PDT) From: Yuanhan Liu To: Jingjing Wu Cc: Wenzhuo Lu , dpdk stable , Yuanhan Liu Date: Mon, 21 Aug 2017 17:30:25 +0800 Message-Id: <1503307878-16728-11-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> References: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/e1000: fix LSC interrupt' has been queued to stable release 17.05.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 09:34:00 -0000 Hi, FYI, your patch has been queued to stable release 17.05.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 8ce9a4b56cb535a4bb9666d9dd7a37918c650b86 Mon Sep 17 00:00:00 2001 From: Jingjing Wu Date: Thu, 13 Jul 2017 17:43:23 +0800 Subject: [PATCH] net/e1000: fix LSC interrupt [ upstream commit 5ed76cd749ae90206e3e58444c76faae6aa7deae ] If LSC flag is changed to off at last device start, the enable flag is not cleared in HW. This patch fixes it. Fixes: c3cd3de0ab50 ("igb: enable Rx queue interrupts for PF") Signed-off-by: Jingjing Wu Acked-by: Wenzhuo Lu --- drivers/net/e1000/igb_ethdev.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index d18dd48..3474793 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -138,7 +138,7 @@ static int eth_igb_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf); static int eth_igb_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf); -static int eth_igb_lsc_interrupt_setup(struct rte_eth_dev *dev); +static int eth_igb_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on); static int eth_igb_rxq_interrupt_setup(struct rte_eth_dev *dev); static int eth_igb_interrupt_get_status(struct rte_eth_dev *dev); static int eth_igb_interrupt_action(struct rte_eth_dev *dev, @@ -1417,7 +1417,9 @@ eth_igb_start(struct rte_eth_dev *dev) if (rte_intr_allow_others(intr_handle)) { /* check if lsc interrupt is enabled */ if (dev->data->dev_conf.intr_conf.lsc != 0) - eth_igb_lsc_interrupt_setup(dev); + eth_igb_lsc_interrupt_setup(dev, TRUE); + else + eth_igb_lsc_interrupt_setup(dev, FALSE); } else { rte_intr_callback_unregister(intr_handle, eth_igb_interrupt_handler, @@ -2716,18 +2718,23 @@ eth_igb_vlan_offload_set(struct rte_eth_dev *dev, int mask) * * @param dev * Pointer to struct rte_eth_dev. + * @param on + * Enable or Disable * * @return * - On success, zero. * - On failure, a negative value. */ static int -eth_igb_lsc_interrupt_setup(struct rte_eth_dev *dev) +eth_igb_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on) { struct e1000_interrupt *intr = E1000_DEV_PRIVATE_TO_INTR(dev->data->dev_private); - intr->mask |= E1000_ICR_LSC; + if (on) + intr->mask |= E1000_ICR_LSC; + else + intr->mask &= ~E1000_ICR_LSC; return 0; } -- 2.7.4