From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id 4D8167D4B for ; Mon, 21 Aug 2017 11:33:50 +0200 (CEST) Received: by mail-pg0-f44.google.com with SMTP id m133so14694796pga.5 for ; Mon, 21 Aug 2017 02:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QAPqOVhfZT+P0Bupw/mshkOjPchTMOqg1pvXB4jYlQE=; b=OiF2D5GQkdw5IpQSmxE0Id5/rXFYU0ushUShJ1C4XQq/vIn0cJzAkOv2hWpCmvxzbF uE/lzV0BPT7mnMU0ufE/GbWjUyOBTmhsLG+cQKEJq4EvBp4HAd21nEpke/k1dUa+tZu3 QBCUChNoNA8t4R5oU0+TfuQFRVVZz9P2OMMSXz7YFEwqnqevuhPwr4ovM/TTFhC7xhNY cC3qMX+0UOOhowHMDc5Fh/pT53Um1AIehD1NdkIw0emFugfR5k3HydbhN45vdK9rM4ne 59ilNX8r8dNlFElR9fq6ROJ7PzO65tdDz7JXaG6jAKSl5AfMtno6cumhViJShmNKvwmD ax6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QAPqOVhfZT+P0Bupw/mshkOjPchTMOqg1pvXB4jYlQE=; b=XRI0c0CO4AmWsRtZ2myICmdjuJcnJejilFv6AgIzANC5zYLkDtviRj22lMNXbyZ60V 24LzN1R5Ays9+Dh11aCx9vnUfRU8lafLHT9oZ9IOGR92+3Y9Q+WhOVYmEyym7X0sCZR0 HCyathe3fJd2Sr4gRjzBchc942+xDA/QsoYXOogQbR19HyqUJGoVu5DQrCNv0hFvHzdz zoBOdyIgNLKmRVz+c2zdfqYkH9yNSFOC6pb4nDnFVeVZ+rqgm1RAtyKjmPlW+qld/QRn QcI7yo2jCPmoBneiQnUHZgKQxReQojXaHN5Ie89BdA8iOp1t6yskJ5xUXA1pJUYu7eWl i/NA== X-Gm-Message-State: AHYfb5jVrVtkr4Cf76Y+z54oLxBRcEhTdgiWk42iqGkLMKhRbH4hVofp NBesnLZR3NCsoZVSxVBtGA== X-Received: by 10.99.113.86 with SMTP id b22mr2276013pgn.58.1503308029570; Mon, 21 Aug 2017 02:33:49 -0700 (PDT) Received: from localhost.localdomain ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id 69sm23355087pfh.186.2017.08.21.02.33.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Aug 2017 02:33:48 -0700 (PDT) From: Yuanhan Liu To: Jingjing Wu Cc: Wenzhuo Lu , dpdk stable , Yuanhan Liu Date: Mon, 21 Aug 2017 17:30:23 +0800 Message-Id: <1503307878-16728-9-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> References: <1503307878-16728-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/ixgbe: fix LSC interrupt' has been queued to stable release 17.05.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 09:33:50 -0000 Hi, FYI, your patch has been queued to stable release 17.05.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From a2a9d8797dc4a46a5faf6811a276ae83ea176f78 Mon Sep 17 00:00:00 2001 From: Jingjing Wu Date: Thu, 13 Jul 2017 17:43:21 +0800 Subject: [PATCH] net/ixgbe: fix LSC interrupt [ upstream commit 53d49d8d4717185a053953352ed4c153d63e7f4e ] If LSC flag is changed to off at last device start, the enable flag is not cleared in HW. This patch fixes it. Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") Signed-off-by: Jingjing Wu Acked-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index aeaa432..78355db 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -240,7 +240,7 @@ static int ixgbe_dev_rss_reta_query(struct rte_eth_dev *dev, struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size); static void ixgbe_dev_link_status_print(struct rte_eth_dev *dev); -static int ixgbe_dev_lsc_interrupt_setup(struct rte_eth_dev *dev); +static int ixgbe_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on); static int ixgbe_dev_macsec_interrupt_setup(struct rte_eth_dev *dev); static int ixgbe_dev_rxq_interrupt_setup(struct rte_eth_dev *dev); static int ixgbe_dev_interrupt_get_status(struct rte_eth_dev *dev); @@ -2672,7 +2672,9 @@ skip_link_setup: if (rte_intr_allow_others(intr_handle)) { /* check if lsc interrupt is enabled */ if (dev->data->dev_conf.intr_conf.lsc != 0) - ixgbe_dev_lsc_interrupt_setup(dev); + ixgbe_dev_lsc_interrupt_setup(dev, TRUE); + else + ixgbe_dev_lsc_interrupt_setup(dev, FALSE); ixgbe_dev_macsec_interrupt_setup(dev); } else { rte_intr_callback_unregister(intr_handle, @@ -3916,19 +3918,24 @@ ixgbe_dev_allmulticast_disable(struct rte_eth_dev *dev) * * @param dev * Pointer to struct rte_eth_dev. + * @param on + * Enable or Disable. * * @return * - On success, zero. * - On failure, a negative value. */ static int -ixgbe_dev_lsc_interrupt_setup(struct rte_eth_dev *dev) +ixgbe_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on) { struct ixgbe_interrupt *intr = IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private); ixgbe_dev_link_status_print(dev); - intr->mask |= IXGBE_EICR_LSC; + if (on) + intr->mask |= IXGBE_EICR_LSC; + else + intr->mask &= ~IXGBE_EICR_LSC; return 0; } -- 2.7.4