From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40048.outbound.protection.outlook.com [40.107.4.48]) by dpdk.org (Postfix) with ESMTP id 6E05511D4; Tue, 29 Aug 2017 16:59:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OMSLpo2scjiX4cOn8/1Noa8DMwysSaa6yq/fWcoaD3w=; b=hmwth2hZuzukvUoJnCpJuFXXcZjyj8Sz+Qq8IKT+h8k3qb94EhbM+RmMyNTc4duq/PJuqSg4L8qe2BCVoBUfZHGpPuluYpje7eoAuk2Vyas2hIQQpAv2gEZIvTcnQnTTpOU6s9dxBRusNipzS3e+NwbvtpsN/mOkkA/76D3IwEo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Tue, 29 Aug 2017 14:59:27 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, Raslan Darawsheh , stable@dpdk.org Date: Tue, 29 Aug 2017 17:59:08 +0300 Message-Id: <1504018748-4766-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P193CA0015.EURP193.PROD.OUTLOOK.COM (2603:10a6:800:bd::25) To DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9aba900-0f78-43f5-f5e0-08d4eeee8bde X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0502MB3048; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 3:inr+UaqMl8sCexaytZ/heA+/i0LcK6OQNneXoYollISFkfDeDLytQNmbWn2S6bkmIA3OuK/FLKCtAu5+R0YZw3sIMIhhprBwrTJ/FRTGWeymW5Mrhxd47nM1ab5pL6+A2K0e++kVlufpzrAO2eJyI3FCiROy4rOzqPYOziCZuASaw6NvKtoMtPWlfql0C3KfGqnWkbRfyqq1nvJ0Js+GTRKCElX8bEXE7ZRqaJgw2zr+WKIY8xxw16quMfzbqTgF; 25:JJ2byuWaZCwHkuKn6LEVt1CQsRhTcUP0qc+FRxGtEPZp+gKzp+aw6JGrAoUEfs7NGUXAd7S3t48eUNVl0rYg4zs1EM3fNT7TnsUeKtmTyJPE/+nBFodctfugI/r0VfypFy2QOoDGv4XhFAizt4B1c3bno6d0WjmSjATE3wbbrPasDDhKY5pgnnEKHkQdBS0/5rM42VNuruwpmSH2Iq1xYgt/hnVLJ26yUUJQn0n/DppXQtU1mrV9fsl9gk2dOyyc6M+/+WUAcF53A3IeTW0ogxc1shUjA8rdEkQOCfqx/kgVKn09ajVCtkMaWCT0rowvV/EujvDuamsffK1BqiQHOw==; 31:P6vBAZVHFWuuY0Pox4qpNYzepj05hhQxH5U8FxUxbzrPSzPZukfOktebZLvsms1/zRbyJeICMYUFm5nJLOJPvYWWNkmuqn06xQEHiGHAgRQZ9dvX7s92zUAi7WszMtUnfDgHqddAVIxojt/kxWM+byjlbMkRNwtgDS6QI2rDn3Rd/S+5EnqjwLRYDa8OoB8hMllNKnxzPCkSbN9yPJl36/C3tb4Vx4zqx5miQSKVC6c= X-MS-TrafficTypeDiagnostic: DB6PR0502MB3048: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 20:B5ztRm5N0P57Bp5senhuCF8Deaulcp4qXdPGlxgegY+5XfSNG1cLIJnf+kqft5b48alpp66BvQPc/+h6z0fovelMvRL2KuAyBIlUCKhhsVlV7EC9eu9HIenVwam/PtBnqDrX7Xt7laiFa77RZUeG5NqEQTt6bBxI0PmxTehh9hK7zZwd3lfklnPZhA+EbFwYc2HqvrprubKQoEYF58pTM/cTkPQ4rKUOThcgkA9rJx2HAyVbHzjZG597K5glfHyB/QOa0PduXL8Uub+LtYKUkXi7LGhg/mJe5bXwwW0057S1PdhMGK98aSFqL5nSeCJKKJHHOb9VmF9Xj6JPsFS7A8VMdDCr4UpsSViKBD0Q1mh8PZKE0r/1/rJYP8UNybIzueumKmwYIKKzpp+nL22i5xgVd0eQJ2i11FEmUVk2k1XPjR99BhP/rU3n2KhGpHD6hn7suhTL2KHnWqbG/t+XyQhH0Vc08QXeX+hPOxcRhlB7TRS0oy6oMLiNJDxTQppq; 4:CMsAReiP9oyq5+vTJ4JyfumhR7wL4+3GH0sDK02nYl+Km0g4JNTPXrdp/V2s53CSaPnsNGHgecxm2Fc5QhjUmwckf3PlqW2PeJBAsRJJlMACfYqPvvv79A+yktHGHxq5KNVi4CscpbEHrS9mX8SDqCtMETIettxcD+uSa+q958WvVtILsKI5YhYjqiFXWtI+E11tSpCsXWB0ynMhOZYh/8thn/R2zw0TP+YRAtBjmjt66DEF/dRAP8DMuAl2YXYm X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB3048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB3048; X-Forefront-PRVS: 0414DF926F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(199003)(189002)(6916009)(6666003)(305945005)(33646002)(97736004)(7736002)(189998001)(81156014)(50986999)(48376002)(55016002)(5003940100001)(8676002)(101416001)(68736007)(53936002)(50466002)(50226002)(105586002)(47776003)(110136004)(66066001)(25786009)(81166006)(36756003)(42186005)(478600001)(69596002)(33026002)(3846002)(7350300001)(21086003)(6116002)(2906002)(86362001)(4326008)(5660300001)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB3048; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0502MB3048; 23:iWs3Dxvhqgs+C2IgYCVQeRRS2mJw4gsxE1w36ry?= =?us-ascii?Q?DWyxvUTh2Opw68SfB2Yv4GTolvPPkkNhL7gZ1krie3XSwbbb3fTdV7IBO/cU?= =?us-ascii?Q?85jUW6DlmQq8zYbwF8yWjvQ7GYMCQbMByPv/0Py2jmeYlgzu+T0nAmxpAxge?= =?us-ascii?Q?4S/Slss148IPcRz755sJ9QOY1DpQgohDpsAEs6pdO10MxxhFvE8qadQufLSA?= =?us-ascii?Q?ox4lgb+Y5EV1xHeD4c74mqlIDh86hdzOrmepX1i7lof8DFaQ7UcKEM7tBkV8?= =?us-ascii?Q?ijXPogZB7IBTF8cXcslubpNKjXuTIeh5Aie1qx4rMOxbe97qoQGF/rgj7vPk?= =?us-ascii?Q?4B0EdFNx2rj2wUIheRXJthFmYO/vJuK2VyryAbTATTw1v33LQVYM87iNuOsZ?= =?us-ascii?Q?lt8LILNrWaHIzRE7CLitdh7CRyOJyRueqJYG0/59dOsqcNxRWVV3SIASIJgT?= =?us-ascii?Q?jr3cOehLZezna8A8wfw60y3zJ6LtLxX9zv00HCq6WIYLBz/gkM819pz9NYC8?= =?us-ascii?Q?8GmdF4FRqbbAJmSmiV9IpTVccRF6ZJDgm1o1mPtgZS8eZGrr3xSIaUX4ZDtr?= =?us-ascii?Q?Dtgi7g89KfPSyVebY2+cJ8Qty+YtDRbNKgl6GYXkjhfrhe7dVmGqjtLmjBJO?= =?us-ascii?Q?vNgHqiQsT8ObMB9rk3CtwysD2U/5gAbSpttnvMKD+E2F5msv/DMOQLw0V6xD?= =?us-ascii?Q?3szKuH4sDrsqKxUZe1ofJOirHTjROOcDSz4fjHEDAWNqfofPgUJ/X2+7nRBv?= =?us-ascii?Q?BpZDJfd3stP3lBfEnUpQ0+zuy1bfbhpFpFXoKmpumWK7cYiOUoyLL4vtMWt9?= =?us-ascii?Q?oSWMfxQkO4FDf4eUc5LxbomA+Z0djCgC1bT1DrNLz8FxUE/bFOFPK+aB4HlQ?= =?us-ascii?Q?sIGP5PVeNA9I5H2iTDo35d32TKJOiATn1KZzb18EAp5tppKV/jwp3q7vrvrv?= =?us-ascii?Q?/Q5MXessoSNJsvRJjooTYMgVFs3v49YrJ57r7faF4mYUj1YWfS6JhG3Ditzp?= =?us-ascii?Q?QJFWm5QcWHBkd9Z+wfQd/RkRzN57vcjK1EJjU68PmbQAhyNISCVglgMpU7ya?= =?us-ascii?Q?akY6exErFcXBsSsknGZoxYSvHGZdHmBH/UIXwwsrTYz8Y9Kuj8Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 6:NAQrHZqrHVk3s81dTAdNd8ckgZM/h4B4PExd6HfMmjMlJu2Wd5a9XOq33stxO/K6/rqFtMSC6oPQiN7UxfoVnDr+vfFz+k8AUpQm8lNzPxfKsGejTkaLCqjiNIHK9BCHF+s4lSo4XR0Vw9bF+Zt95lSp5jqTTBPVzB+XZNuBpTmkpqi+UAGprn015rrazT5VrflgY90bou5/pFiv5ZE0bo7Ft+aAzySS3buWuO3XfH+whC4K7M/PPx1v1nl0SGKk4hic+sf+bSfBaX8KuBRb2WbH3HaT2SnjuvmagKCr0pFuxgzeZhVODiEJHoMIelbR5P+ak12qxVqboZSokWZ9MA==; 5:yuj7h44x6oW+MFxjHisy89s6QcIB1st46Y/AMLxL121WMCD6hNcn8/zMog7ajk7zTyhccghPdeCX+27SwKYO9VRyByN8ORyQSCGntJYF/0EGsEqRPyNtFIcczhPo5BuZiobo8O3r1lnBpSdvG9AyqQ==; 24:mzPD/h66ZKrvWdHPcVInPdOK8ho0J4ya3CYLmy6FIJMSD6i26318YSEcb4hA+7Ze5UhL3Dwc3hizxND2kwWzAhG5S3peJMzCyxZYlhuCevI=; 7:jEFOOI3mD12a+Xe+tcSTOcKo8s80zEUMtokgRRO4+pk4D+R5r38RKBgQqCPsPWmIZOW9wk+fR+tWdtxB6u8gkAkL3XzovsGKuA4UjN32wpj1nvZg0p91FLO3WnSss4+cNudk8EOjb6SVZxfO73opOEkXAgWqSv5E5/Zm6CRc3/QRbYp9xgy9P3A3xXHYt1yl72Y2Uoaw6TgiG1/lMBD49i5QfkmXURazgizMgOMKd0M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 14:59:27.3135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB3048 Subject: [dpdk-stable] [PATCH] net/failsafe: fix exec parameter parsing error flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 14:59:29 -0000 The corrupted code returns success value in case of the execution process output stream is empty(EOF). It causes to segmentation fault while failsafe polls this command line again, than gets success and tries to do hotplug add to the sub device by uninitialized pointer dereferencing. Morever, when the output is not empty but uncorrect, failsafe returns error for its probe function while the expected behavior is to do polling until the output is correct. The fix changes the return value to be -ENODEV for this sub device in the two cases. By this way, failsafe tries to parse this sub device parameter by exec method until the output is correct. Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Fixes: 35ffe4208140 ("net/failsafe: fix missing pclose after popen") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_args.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index 645c885..61c55df 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -157,12 +157,16 @@ fs_execute_cmd(struct sub_device *sdev, char *cmdline) ret = fs_parse_device(sdev, output); if (ret) { ERROR("Parsing device '%s' failed", output); + ret = -ENODEV; goto ret_pclose; } ret_pclose: pclose_ret = pclose(fp); if (pclose_ret) { - pclose_ret = errno; + if (errno == 0) + errno = -(pclose_ret = ret); + else + pclose_ret = errno; ERROR("pclose: %s", strerror(errno)); errno = old_err; return pclose_ret; -- 2.7.4