From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0083.outbound.protection.outlook.com [104.47.32.83]) by dpdk.org (Postfix) with ESMTP id B78C51E34; Tue, 19 Sep 2017 12:25:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vMZHsEIpw6ugFUUpZ0uwPM4gpIAf5p2NOWqyXWYRJyo=; b=DlOICuLPDr9RPOTrLLS8I00x2dvglMnzq/xK0za7aKH0Adb3THC/vJCoyIfHPtosQHqTYJfWHNCPTjri2sRLLDSe/pcmKDKOs4CRWgzKtiI2vM3ZA6TFkRcgYNU63hhJoLsP2/cHZYiU19N5mFGPx7Uyu4RaZVtJPO4lil+c2L8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from lio357.in.caveonetworks.com (14.140.2.178) by BN6PR07MB3060.namprd07.prod.outlook.com (10.172.106.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 10:25:02 +0000 From: Shijith Thotton To: dev@dpdk.org Cc: Ferruh Yigit , "Thomas Monjalon" , "Yang, Qiming" , "Patil, Harish" , "Zhang, Helin" , "Gregory Etelson" , "Tan, Jianfeng" , "Hu, Xuekun" , "Li, Xiaoyun" , "Thotton, Shijith" , stable@dpdk.org Date: Tue, 19 Sep 2017 15:54:13 +0530 Message-Id: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (10.174.208.18) To BN6PR07MB3060.namprd07.prod.outlook.com (10.172.106.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cec38333-873f-4cab-e083-08d4ff48b211 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR07MB3060; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3060; 3:WrPCOCEiGPzmlb7uW/zGYhiqvkO03ZJEWyKLMItM9xZ34hvQ3Bb2xmPjNFEZmIvII32Lq2ynz/Qg4EWaRl1r8VTeyUcNnaqwYfuRgtpg57nh2tNSNRPKrljoTFFK6YOFQCD55+kmxvS4vachyKSLw/yw1QQEIJGYtr9gd9MqcA9loPPT+8nX+alWSb5PEHPavYoWqgS//yLy9wJH8ohCV3NOffMnBSeF1PCpRmr6JUczmJO9x5xTFgvBJYp56ayJ; 25:y2cz5Y0ZVDELz7BnsRSwkfHn6Mih0/XMNoIkLfNI4qwUB4jfieg2WRWkBmZ/7hSdzdkZDCl+iRldBxB2hYtr4ITImML47zU7mxYKTP5WHZOYX2twuwC3jN2CyqNKMs+N5QGX6DIORh6OlrUqgcQehQT5Ela+hTl2/iasRmpU5XL7c0B2TDCQzmQ3GMrMMe7azXDYUCgSBe5Bj/viIkqV2vxyfWjucakBL6OXsBLm7lUyr7XHKL3mufJEPbvcgCKSQvbWqyb2v714mYHvTIVJfbLdG1JsYdlRd6hoDe/hmrWPfjW9cMdvRM8gWvJmGmFwh5x4Y+qhnh0LmQ9j/VQkBA==; 31:WkAZzFf3Gjh2yySC/rAozAJZOCSAL872HpnwXIxxUCtOfQTMasDERXuWRQE/T5TYWBDWi6udlW9qqCvK9r35uZzqXs7DMgrie6ip9dVeVuzNF070Hj8lmtS02oK3Rg/6l0FJ4mDPN+85oZ8QBcdbwmh2lGQys4e/3My/WDxCbjbDJozkUrGNX8F2mRfUBtCklgq7p+dW7yeB9QRGtleW//zOMHaf6CkUqeYQv0Eu+RI= X-MS-TrafficTypeDiagnostic: BN6PR07MB3060: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3060; 20:/BAZ5GPTMTH5MvtlA4R8CAc4xL9ewp3Da5WzunOEwbyMTHrYnLShsK+WY6tFTDm/8NFf+ufV61JjabZgTXlRu74JXNMloUYp7YqjeBZgvz8NEZiZYbV1ztL5rKIrOpr0Nc8VzP1pFssM3iDJQqUzreb8OVYRATGRH5PDaU+Q7w1JtNtRbVBsEesYi0TiA5o+F43ogjeZ9+HD6yxfelqp4AAnIWEXRcjTyGqWqcJ0nOFnsztLPz2DDN/O7TZ0nMI4zQOTwXfCUDDODDREIIXl1qK5ArzfpOTd46zu50pCEnr1AHUjLGA1TsWc2nf0lRSOEFDzoWqWrkIhK17bJg67aiyVFUGdS1fSOm8IzU4frt12yWlNe7OMOBJUUth8wFeuEyUWZVFEfQR6q5LrF66RSGzZs0pn9VmIpj4YzaOmzCwEA28eMsiColHBB+Jeiy2Q23ZqkV9F01Stl1BRc4Pddgou9Gv8hipeaPsfLC8MIC5gnS6ooTXGjGjRuVZZanogg0S+URmUZ3RxOUfmy7Muo3a5LshvmwabyrbPmrD5i31ukNRGKUaL84Otfp4Q6qywvV38twkYHlucb6REtafy+0XRHrv073soWna9J2bzk5s=; 4:1L6CJO3kVavcG5ajyVfRoKe6GjRpqIeK5V7XnPD98Je4ClnYQbbM3sUG1cMig1dHsA2nX1d3tb9Y0MbAFi2EuJwxQhpmN8161RVypt6odWtrE2MV2qjl4bsMjgkEoa8U5arpBn/ru/ATLx3g7FLuC5Bv0m7ARhpVuVHtwjjZ99M8TJ/X+//AWalWySu4A0QI08yirO8nzZq99hiJg9ESlf4myx09bEq3rU/s829McsU44fFE21MJ5ALj1xa6s4rh X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3060; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3060; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(50226002)(105586002)(50466002)(6512007)(5003940100001)(2950100002)(2361001)(6916009)(42882006)(66066001)(47776003)(25786009)(33646002)(478600001)(72206003)(54906002)(76176999)(48376002)(4326008)(50986999)(2351001)(101416001)(53936002)(106356001)(6116002)(3846002)(6666003)(5009440100003)(189998001)(4720700003)(8936002)(81166006)(6486002)(7416002)(2906002)(6506006)(5660300001)(316002)(68736007)(305945005)(8676002)(16586007)(7736002)(16526017)(97736004)(36756003)(81156014)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3060; H:lio357.in.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3060; 23:miWN/Ik+a2mXJMioIF7NqMXICscBd5DwOvfmi0NRV?= =?us-ascii?Q?ClEJk6QrgEQL9MxeFCdCR5+roArGU6mUjswLfnh5u/VNETyQSpyfuGUJ2BqA?= =?us-ascii?Q?fbtLXtv1gfOI1OrgbWa6V5Md4O74WYgYeJ4Ttrr6/pEnsk9gWJZJYqjmRFYG?= =?us-ascii?Q?1eV6hW6EkX4CqMbzhqhuF2DRm6E/R9FXF1p9hV5fR0GW+DE9mAi8xUocDSlz?= =?us-ascii?Q?TWyZAS7LFM9DlAHHTeGBtKNVInaneVEH1J6v0bG4iKyvm+f2TyxHSeoJolUG?= =?us-ascii?Q?FPWV+ttl+k8xEQ1JSxv0r044cqYvdW39TBZzu4n2IChDg0u2WafKI1MnUoEj?= =?us-ascii?Q?VLynIvc9iXMcFfxlJgZAmBIAz/qmuwvGTEnjvNvsqKed49GJ4U/IOJaD7sip?= =?us-ascii?Q?0ppmEQIlI55P7i0FOXRrFHxVPVURY012p+WEr8TTfbc6RulMTY3J2YwWU0Ts?= =?us-ascii?Q?59miQnhg5ZbUo7pDveoPcrnqNdTI/09RmTDTbOIyS7IfeluCTSufS9xGHvbC?= =?us-ascii?Q?MaqAnn02eQAp4dI2CzXL1v9aCytwJrYwNvwDJpCCNpk7K9vNmVYHDq2C2i0J?= =?us-ascii?Q?09jKDU8lm8rWLoqLonX+AFbqY5qit0bgdoSl/RS/z7MDJ3CbIitTkAKWfqlN?= =?us-ascii?Q?sLyILxZGr7Eqn25UasnqvU0wm5kh1zsXwE/DMc0sSl4gf3n5tJmk2ibsFOVK?= =?us-ascii?Q?LHgUzD4ZAXWb2W9aKle90iEwjvENIMxGbXA12D1ZIG1K1WUdPxQy4/9sIjdt?= =?us-ascii?Q?C5UxPelQtdRAIhVcfiDImHvSCuaa+vnEx9D7HTyKMYEDMcJlCMSfNKmUqzmW?= =?us-ascii?Q?mC0W9wFJpRdiSSWIcGIqybyhwgHwdPyy2T+UOOdwZQm9LpBhrQ+ONBL4ryAF?= =?us-ascii?Q?y3uzj+oauRfJ+DSAJ/FNbGL1sLjnY/nBbbNGCpb9Rgw5au6tRA6r76SVapc4?= =?us-ascii?Q?dwSOEMvLsLZ4JehYkod0HlcuQeKeIMHfskAJ30tg3sCG8oSpkBKPRgoHJ8ge?= =?us-ascii?Q?Y4qujOID1uu18gyuyrzsdwmIMqyFLgyLV/uof3CDgnEyZIG2xf17IlygnZtc?= =?us-ascii?Q?TezHhKjyU4dpjyz98L2T3Vq1ifCdelTg9Ffk1Fip/66AjL0zOn3RBJE/+ctu?= =?us-ascii?Q?FbmBj6/KN8WUsheu8oargBGX9h636IdtbcxXK370C/Cy544s7pIlhtQsNv2v?= =?us-ascii?Q?mPjm9/EbJSc/6pjGYtjTq6Kx6cPln9q9gaezCClDVKCUGdBGm21pkj++5zTY?= =?us-ascii?Q?F5E/Qbm97F2PW0bthY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3060; 6:U5cikJmW8zrwtV3QT5JCnyO9FQ7peZf9OWW6TAx0Ut1jIAAdW5d5MgDR5CT6a4em79NAQP9p0wA04UGPzZi2ktzLd3sfUdMqalfnhG2/W1Qdql3RGWihfVHKv+vG68fx/2nKpbfJVKMuv4zeH1eH8YqZv/N8vDVWKtrX5oeuIpAZFfmoCpku1Be0YGr9vWT14GpPRxT3/3w13ealxPowIFHXhu0DGhRhlywNrfWE9yZGZklosVgxuwhhmkWNfAB3/vHv5kq/+hS6i7A1EG54wkf7afStUK8rqO5A42jCGVv4nJQEEO8XAFRSQnCu366+I9dCFU8eWZSkOekOB1YwoQ==; 5:x8eLHMmYBtawD++7saGvUgYET1uxl4FiDjeioz7YIKiU06AFPJOdKUczCcPRKR3b0N6NRZgAdf7uSKnu7nn70mJfPAFFCt6v+Urj1Jy2sQPr92RR8gX++2Padu/6gsXbjpiodHf0c8OSrv/YQ3YA/Q==; 24:MxCOdOfAEz3WVay14DwVAME34UtvOPgJjHD+D+4NwfQLleH0T+8H6hYVZ3Y0ykpzlK7Hgz8gDtx+3ZM5rz66pEta+flcCSA+er11k2/78TM=; 7:N2cA/G0RrVxDtj+MdMA/gAVlJpBpe0yxGgAbB6MJsq21sSzNqMqzI84bHdf2qreCioKfUeknhVTZuJZS8Sm/mIxTBWOe/7AMT0T+JxmoNORIhuCAj33LFzLJjPij3++QJfcleP35jmDrmXnarb8WYj2kd4ciJ7tZLf/FERH4UOaU4cxTehG13g1RZ3vsL2YdbkcBAgbtVjBnJELmonHoXFWE4t6s5EQdWrLlW983xgw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 10:25:02.4620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3060 Subject: [dpdk-stable] [PATCH] igb_uio: remove PCI reset during uio device open X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 10:25:08 -0000 Issuing reset during uio device open caused PMD init failure for some NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed. Bus master enable is kept as part of open since we disable it in uio device release. Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") Cc: stable@dpdk.org Signed-off-by: Shijith Thotton --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 07a19a3..a6c2996 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -179,9 +179,7 @@ struct rte_uio_pci_dev { struct rte_uio_pci_dev *udev = info->priv; struct pci_dev *dev = udev->pdev; - pci_reset_function(dev); - - /* set bus master, which was cleared by the reset function */ + /* enable bus mastering on the device */ pci_set_master(dev); return 0; -- 1.8.3.1