patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] vhost: fix unchecked return value
@ 2017-09-22 12:17 Kuba Kozak
  2017-10-02 14:18 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
  2017-10-09  3:10 ` [dpdk-stable] " Yuanhan Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Kuba Kozak @ 2017-09-22 12:17 UTC (permalink / raw)
  To: yliu, maxime.coquelin; +Cc: dev, Kuba Kozak, jan.wickbom, stable

Add return value check for poll() call.

Coverity issue: 140740
Fixes: 59317cef249c ("vhost: allow many vhost-user ports")
Cc: jan.wickbom@ericsson.com
Cc: stable@dpdk.org

Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
---
 lib/librte_vhost/fd_man.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c
index 2ceacc9..4c6fed4 100644
--- a/lib/librte_vhost/fd_man.c
+++ b/lib/librte_vhost/fd_man.c
@@ -222,6 +222,7 @@ fdset_event_dispatch(void *arg)
 	int remove1, remove2;
 	int need_shrink;
 	struct fdset *pfdset = arg;
+	int val;
 
 	if (pfdset == NULL)
 		return NULL;
@@ -239,7 +240,9 @@ fdset_event_dispatch(void *arg)
 		numfds = pfdset->num;
 		pthread_mutex_unlock(&pfdset->fd_mutex);
 
-		poll(pfdset->rwfds, numfds, 1000 /* millisecs */);
+		val = poll(pfdset->rwfds, numfds, 1000 /* millisecs */);
+		if (val < 0)
+			continue;
 
 		need_shrink = 0;
 		for (i = 0; i < numfds; i++) {
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] vhost: fix unchecked return value
  2017-09-22 12:17 [dpdk-stable] [PATCH] vhost: fix unchecked return value Kuba Kozak
@ 2017-10-02 14:18 ` Jastrzebski, MichalX K
  2017-10-09  3:10 ` [dpdk-stable] " Yuanhan Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Jastrzebski, MichalX K @ 2017-10-02 14:18 UTC (permalink / raw)
  To: Kozak, KubaX, yliu, maxime.coquelin
  Cc: dev, Kozak, KubaX, jan.wickbom, stable

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> Sent: Friday, September 22, 2017 2:18 PM
> To: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>;
> jan.wickbom@ericsson.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] vhost: fix unchecked return value
> 
> Add return value check for poll() call.
> 
> Coverity issue: 140740
> Fixes: 59317cef249c ("vhost: allow many vhost-user ports")
> Cc: jan.wickbom@ericsson.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> ---
>  lib/librte_vhost/fd_man.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c
> index 2ceacc9..4c6fed4 100644
> --- a/lib/librte_vhost/fd_man.c
> +++ b/lib/librte_vhost/fd_man.c
> @@ -222,6 +222,7 @@ fdset_event_dispatch(void *arg)
>  	int remove1, remove2;
>  	int need_shrink;
>  	struct fdset *pfdset = arg;
> +	int val;
> 
>  	if (pfdset == NULL)
>  		return NULL;
> @@ -239,7 +240,9 @@ fdset_event_dispatch(void *arg)
>  		numfds = pfdset->num;
>  		pthread_mutex_unlock(&pfdset->fd_mutex);
> 
> -		poll(pfdset->rwfds, numfds, 1000 /* millisecs */);
> +		val = poll(pfdset->rwfds, numfds, 1000 /* millisecs */);
> +		if (val < 0)
> +			continue;
> 
>  		need_shrink = 0;
>  		for (i = 0; i < numfds; i++) {
> --
> 2.7.4

Hi Yu / Maxime,
I would like to ask for a feedback regarding proposed fix.
If everything is ok with it, please send acked-by.

Best regards
Michal.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] vhost: fix unchecked return value
  2017-09-22 12:17 [dpdk-stable] [PATCH] vhost: fix unchecked return value Kuba Kozak
  2017-10-02 14:18 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
@ 2017-10-09  3:10 ` Yuanhan Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Yuanhan Liu @ 2017-10-09  3:10 UTC (permalink / raw)
  To: Kuba Kozak; +Cc: maxime.coquelin, dev, jan.wickbom, stable

On Fri, Sep 22, 2017 at 02:17:40PM +0200, Kuba Kozak wrote:
> Add return value check for poll() call.
> 
> Coverity issue: 140740
> Fixes: 59317cef249c ("vhost: allow many vhost-user ports")
> Cc: jan.wickbom@ericsson.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-09  3:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 12:17 [dpdk-stable] [PATCH] vhost: fix unchecked return value Kuba Kozak
2017-10-02 14:18 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
2017-10-09  3:10 ` [dpdk-stable] " Yuanhan Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).