From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50082.outbound.protection.outlook.com [40.107.5.82]) by dpdk.org (Postfix) with ESMTP id 9D7201B2C2 for ; Mon, 6 Nov 2017 15:17:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+TaVRQAKkbvL2QG6Fjk0fDFaO/OGSH69Mfd2yJ6c8jw=; b=t5YCdEWvAPtC3/PGegxhYfx1mBR0lC9Nc+DKdlLzn+6x1BAbKVg8i9vVCzkihNy9BxZl9UV3b1RgL3YHykh873ErCA7WxVOMlgSpwJnGpuTW1G2/37H9ORL4ua3qWHkIwXU7f0oqEGy3TbiliD81yd68TTwMRcWBh4TTdK14iQ8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM3PR05MB1251.eurprd05.prod.outlook.com (2a01:111:e400:586f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Mon, 6 Nov 2017 14:17:56 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org, Raslan Darawsheh Date: Mon, 6 Nov 2017 14:17:45 +0000 Message-Id: <1509977865-4202-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: AM5PR0701CA0012.eurprd07.prod.outlook.com (2603:10a6:203:51::22) To AM3PR05MB1251.eurprd05.prod.outlook.com (2a01:111:e400:586f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 896f3562-114a-4946-7dc0-08d525212d42 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:AM3PR05MB1251; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1251; 3:ha0Gth4Wwpz5w+KgKWIVyVhNIVP/fTxVFf9ueu9c1D9reuR6YqjrVqzcvtNIxbbyVriRExeb3k5NYrXH2z1WL13sAxp44It0ct+w7IR18DzBuj5IT3ply8sKTH5QeKOolKcOGJ3rYnozmSiREJ3C6wth1z0MPPWKzZA3nIN5lBS58yMLnHxSEIRaXGRs0CvPjIP/DqwknTkPrVnU56M5lo2zfNGrclCV9KHaAs62xvjuIReFm3dCSazKCGl8dP5d; 25:f6OgCET120cPxMZr4fSFzdBaK+viagY3nS5ZtFSuYIExD3ttyXVLnBBX21rflqvwTOCRzBDjqEeb3TnELD4p2NqziBKBzDr3MrJm+Ms3AtEItK4/rKmlXM5ti2O4W5nOoUGov6X9oLmut16gwsEFTCO9KwIcLJnMbY1+eUDT4gG4CcLW6gDLiOo2LFR3SusWcegNO7PSgVgmiBubdiip1NS9O8hzIL8DAFaHpLItGz6GI4GIlAqQ/FWcOvcRio08V3OUJhU+i2VS0mebpVQ38wbLkBGUHGWesVJFGy3/veiM3MPXSmYfBSz/WOPKqBuEr7WVIEIqRF46lXCGCfPYXw==; 31:K/SJSiNHgP4S9o5xzj2IdOVrzBuwk6hKGlbMy30VwtafdgzrYiWOJn93/sSMAeq23GXAXfHfL8gChQ2ZNUej+LNmt4A4nZFD5Wi3YnTu2Hi0z0aMEp8e+Ciqu5nt++XyXRq/RVDrvthvearydFRz7okzuXZGOTQ+mPv6THNAQvqaJi1x4Uqj2sVSeNV4WPpm5vDK9zJpLj2ID/tXipRutMSzqtLUv4a83DHZkMSgbto= X-MS-TrafficTypeDiagnostic: AM3PR05MB1251: X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1251; 20:BeeT0GmshT9K/gvtgOpEy64yYaxxoWOzs+jjxehugTPW7qUe0ypleGWBM4s6j5JWkp1VgxNZIcHLRdHw2UhT2daUBU4AN1kZ9HGI09U7qjz5KBfcKDAC9g4DzXbpierz39M7pOYAyzvrvV+5AoCNnXTVleyRw65DmNo0te3+JwygZ3HuCaFxmrycw9Z5yFkgqJfFYTEBSPRiIYTqH+bptW6Xnm9FrzW+MCyWdlzihGzXCTHncBTF6eGMxDnXxwEpN28iZPninbN0WoOA6BAeY7kcA8id6XS049R9g3OmEGKacrqQCg5K9gF+fAPgit9Yz6fAxDaiwuDp+XL8FOj385XAoJyrlJlpyQbCQo4S4jQ05n8FdZhEkmIvyyoxkCk+ej6eLf01SSFhU22QZC77BDm04bBIA08g0tVkyK3YUoMbOzZ1/pwjkaMY2vaNr96HTXh6gc7F7XPCiJq7QTvsqhQITWv7L7D53vUoGkdeAhEyc4T6vDqVlXY/GsRHhus1; 4:4FXrcF+9zL91d5GHUqMJ9gIjLqesTgbm2aBsMgEl0wWaxP76+gA+fiobThEEGmrUPB6jC0Xn/vxjoZoiw0OOy6QSZjtBXPPDzUYx/vdFM9cTbZGwoEvJLl+JuhB1XMe7Fme56RkjC9FTo+eAZnFIBG0UHmZPQxEv02RilL8vxEZsK+xm2Uae6RpuBUhlsaDi5bBeUnRzZiVbeUHiXFRoSoM7XlCTfEr8W3lijJeECawLrvHKWAR95IMuKTXlw58eWTHYsplKBItW5HJzgvm1wg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3231021)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR05MB1251; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR05MB1251; X-Forefront-PRVS: 048396AFA0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(199003)(33646002)(69596002)(50466002)(55016002)(48376002)(6116002)(6862004)(5003940100001)(53936002)(478600001)(7049001)(6200100001)(5660300001)(86362001)(47776003)(21086003)(25786009)(3846002)(66066001)(33026002)(50226002)(2906002)(106356001)(50986999)(16586007)(7736002)(105586002)(97736004)(4720700003)(81166006)(107886003)(8676002)(81156014)(6666003)(68736007)(189998001)(16526018)(4326008)(37006003)(36756003)(101416001)(316002)(305945005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB1251; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR05MB1251; 23:WjaP7N+COVCbqEQAtoCCoFuTilGAFbpKn1XI/Rr2+?= =?us-ascii?Q?V3Z0ljbRdgwItXt6RatSVBdWej3gT07wkjbrUq+XHDP7RjsPuZfuMCe0s0J/?= =?us-ascii?Q?IpW33iRTGzZyuihMD+47Tkq3TNLgTX4GuS+gPeMK0vJgoQcU1Od/11tVYi3D?= =?us-ascii?Q?Grcma3pLDeIbJQsQEBMMDrhYR0vkmDWCHlskSSscjj7E0akrvefUGguHF8kF?= =?us-ascii?Q?EWTRmgbKoTi+3GonhtKUTBqh+nBR7wGnqTteCuo2V1ffWOrzDT37BXS3Ss80?= =?us-ascii?Q?+L34NmamlnHt5zfm+mIUBuFmbmgkjNskVa/mvNF04Msp/MiNHy2v1xoQpskW?= =?us-ascii?Q?TgRpuxygKIPQ0M4HeTT1EDg1IwfiSWKXFTboNG9SBuXlbJq9yW0evwirCZEP?= =?us-ascii?Q?Zn/XzUloQnvf/iYZrRR3hCIR0EtZHRgxPCyipF5SxNFiPlXtfDcpISkGBKDU?= =?us-ascii?Q?5U8S2hQdaM8g58NAw/hE3YGCiWhRvMfHkc4fNevAP+77+JM/IsIDcYk+/TDj?= =?us-ascii?Q?i10eFJmzjzGr11VmQMoCwhoDVAJzhjmwqwuzwIV9aWrQSTc96N01U3BVtKMO?= =?us-ascii?Q?sPRW0OkpagsA79WW7AFNbe7qE/CTSpP1LAPyqGwZQjm4LhSdl70mcNg62Q+w?= =?us-ascii?Q?zE82aqPWn9MQSJ23KLKyzd2241Lxbv7ICFoHet12D2yO6VLaPyPgrqXoryvv?= =?us-ascii?Q?JZrxFPbW7GzR6lpkEqupiDDxITLAp1HGbdK+Sti+EbEHXeIyYI/Ch6pVY3fQ?= =?us-ascii?Q?KJGVEiW1WDuvZeIPCKGE5iYzKh0IgmU2rqXzPPm5xl3XkxojSTeCqwExCXnm?= =?us-ascii?Q?U0FlVTFmFDSKOQEAJJn09ULReSjjRCg+yf3WNcLatdPMZ2nbxoi5XNeIuUPo?= =?us-ascii?Q?5Wxv+rBp8MVXHKJVaV26L19E8fHfTlH9RfOGOUP0w6B+V6FK8JFzRotLkBeY?= =?us-ascii?Q?NP4AmcX6YxietiYMaSUvrytmtJ08DwTXdcfAN9n+hC1lQoCeTdGWvl5eei9y?= =?us-ascii?Q?9Jiex4glA3oskafFPGpMaiJRk7zVK6f8Nj1SqK4bpgYyjfbgIxkWinXdtHJ1?= =?us-ascii?Q?uGg9SOr7rU+dAoYi/yXAqOJVTs2wcVNWW6SPI12cK5W791qouFnfx7Ab2Get?= =?us-ascii?Q?NLDbrAjUtCzgCPTt0bO2IWJtu5BiPxxAxuq2aPEsu7GVRmmKBvzeGRcTj8ES?= =?us-ascii?Q?x5BNPhi/X8f6lg=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1251; 6:csqJd5p6ovVO+dIHdvkockAPSWpgtg3JrxqIKeHHJDdMUfrNi0QOkcQWNInYVicyp3M9zBwYWdLF3MVW0LihXCBxkJwBllapahI/B5DFjp/iz9BJlKmPZcVpr/vlF0teL6Ocbr7F91i2oYQJ4qvJj/n/m1lTEyLKdkSFYrPYbZY1dqDI42Vy1Ma3jS4ubqc2Yfh4S9l072vIkrRQv3YFVa2tCjIIheFSrhrDmBtX1G+AoAZn1sdLCGRdZ9yncb0fb25WisGtLlA1jjCmtTbf//JCG3Zt/jXravpwf3Cqyy6cZFualHn6qBwkkGpvdJy8cN/OiN+hOD0H4pOWCeHs6Q5YDrvkPbIXi9P0urf3wK8=; 5:QktHiapLrlZjhxChxFOzYTxduZ6sIM4SwRei1OVhFgeSPDBO9xqcEThJfkoiC3xFDhNdjEV9EX35ktaklZYQou0NG1fXImqjNgERmiy49Nk1YRkv93pFRlAyr00pkVAc7rQYBLE57BTR9SJSQ4wP/G03cICeMKYmAfYwPDTkfg0=; 24:0zX/7O88ORX8TRHfiE+fryDcj4as7kNHJr3UzGKbJ4trU4YJxPvAPvtYr69w6RIuSIZeVJ0sP4FtlCLTLfoukjbNqW7BJdEet5BCv/YrEhQ=; 7:gpx3uCroamHTS2zqyhhyo6i4w23npEkRcUwuvxsfczD9BboL0sK69GWHyMfPNCjdM6o8fGdEwHJHu07AZDcWpV+oGQ0MP+Wb/Nmu3moaRcG/VLsNCxMHZ+TG7iR+JFbUD/ZTfPaG3AOGb9vRwuOJEs6A15bcIQHMWocw4LYVdRCgNhbM2o0EVlHPAFlw1gFy728A2lbF6zRpjz2x0Lp3/8bJaFjC7i7vto6jN4OgFH4nZeKVZdbpcTU8dx5eGUPP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2017 14:17:56.0805 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 896f3562-114a-4946-7dc0-08d525212d42 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB1251 Subject: [dpdk-stable] [PATCH v1] app/testpmd: fix fwd between two failsafe devices X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 14:17:58 -0000 When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 device Port 3 - failsafe #2 device Port 4 - PCI #2 device Port 5 - TAP #2 device If forwarding is defined between the failsafe devices including a peer address the forwarding should be between peer addresses of ports 0 and 3. Instead testpmd establishes forwarding between peer addresses of adjacent ports 0 and 1. This commit fixes this bug. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Ophir Munk Signed-off-by: Raslan Darawsheh --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 7bc721f..cd2ac11 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1905,7 +1905,7 @@ simple_fwd_config_setup(void) fwd_streams[i]->rx_queue = 0; fwd_streams[i]->tx_port = fwd_ports_ids[j]; fwd_streams[i]->tx_queue = 0; - fwd_streams[i]->peer_addr = j; + fwd_streams[i]->peer_addr = fwd_streams[i]->tx_port; fwd_streams[i]->retry_enabled = retry_enabled; if (port_topology == PORT_TOPOLOGY_PAIRED) { @@ -1913,7 +1913,7 @@ simple_fwd_config_setup(void) fwd_streams[j]->rx_queue = 0; fwd_streams[j]->tx_port = fwd_ports_ids[i]; fwd_streams[j]->tx_queue = 0; - fwd_streams[j]->peer_addr = i; + fwd_streams[j]->peer_addr = fwd_streams[j]->tx_port; fwd_streams[j]->retry_enabled = retry_enabled; } } -- 2.7.4