* [dpdk-stable] [PATCH 1/2] net/sfc: avoid Rx queue setup failure if thresholds are set [not found] <1510659155-22088-1-git-send-email-arybchenko@solarflare.com> @ 2017-11-14 11:32 ` Andrew Rybchenko 2017-11-14 11:32 ` [dpdk-stable] [PATCH 2/2] net/sfc: avoid Tx " Andrew Rybchenko 1 sibling, 0 replies; 2+ messages in thread From: Andrew Rybchenko @ 2017-11-14 11:32 UTC (permalink / raw) To: dev; +Cc: stable Rx queue prefetch, host and writeback thresholds are used for performance fine-tuning and not applicable to Solarflare NICs. It is safe to just log warning and do not fail Rx queue setup to be more friendly to DPDK applications which hardcode it. Fixes: ce35b05c635e ("net/sfc: implement Rx queue setup release operations") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- drivers/net/sfc/sfc_rx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 2ae095b..7816393 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -780,9 +780,8 @@ sfc_rx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_rx_desc, if (rx_conf->rx_thresh.pthresh != 0 || rx_conf->rx_thresh.hthresh != 0 || rx_conf->rx_thresh.wthresh != 0) { - sfc_err(sa, + sfc_warn(sa, "RxQ prefetch/host/writeback thresholds are not supported"); - rc = EINVAL; } if (rx_conf->rx_free_thresh > rx_free_thresh_max) { -- 2.7.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH 2/2] net/sfc: avoid Tx queue setup failure if thresholds are set [not found] <1510659155-22088-1-git-send-email-arybchenko@solarflare.com> 2017-11-14 11:32 ` [dpdk-stable] [PATCH 1/2] net/sfc: avoid Rx queue setup failure if thresholds are set Andrew Rybchenko @ 2017-11-14 11:32 ` Andrew Rybchenko 1 sibling, 0 replies; 2+ messages in thread From: Andrew Rybchenko @ 2017-11-14 11:32 UTC (permalink / raw) To: dev; +Cc: stable Tx queue prefetch, host and writeback thresholds are used for performance fine-tuning and not applicable to Solarflare NICs. It is safe to just log warning and do not fail Tx queue setup to be more friendly to DPDK applications which hardcode it. Fixes: b1b7ad933b39 ("net/sfc: set up and release Tx queues") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- drivers/net/sfc/sfc_tx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c index 127d59e..d1320f4 100644 --- a/drivers/net/sfc/sfc_tx.c +++ b/drivers/net/sfc/sfc_tx.c @@ -79,9 +79,8 @@ sfc_tx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_tx_desc, if (tx_conf->tx_thresh.pthresh != 0 || tx_conf->tx_thresh.hthresh != 0 || tx_conf->tx_thresh.wthresh != 0) { - sfc_err(sa, + sfc_warn(sa, "prefetch/host/writeback thresholds are not supported"); - rc = EINVAL; } if (((flags & ETH_TXQ_FLAGS_NOMULTSEGS) == 0) && -- 2.7.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-14 11:32 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1510659155-22088-1-git-send-email-arybchenko@solarflare.com> 2017-11-14 11:32 ` [dpdk-stable] [PATCH 1/2] net/sfc: avoid Rx queue setup failure if thresholds are set Andrew Rybchenko 2017-11-14 11:32 ` [dpdk-stable] [PATCH 2/2] net/sfc: avoid Tx " Andrew Rybchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).