* [dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang
@ 2017-11-20 3:26 Wenzhuo Lu
2017-11-20 12:12 ` Luca Boccassi
0 siblings, 1 reply; 2+ messages in thread
From: Wenzhuo Lu @ 2017-11-20 3:26 UTC (permalink / raw)
To: qabuild; +Cc: Wenzhuo Lu, stable
The datasheet says, if using MSI-X mode, the PBA support
bit of the GPIE register must be set to 1.
DPDK uses polling mode, we cannot hit this issue in the
scenario DPDK PF + DPDK VF. If we use DPDK PF + kernel VF,
as the kernel driver uses interrpt mode, VF may hit RX hang
after running hours.
Fixes: 00e30184daa0 ("ixgbe: add PF support")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ixgbe/ixgbe_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index 676e92c..0114694 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -273,7 +273,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)
gpie = IXGBE_READ_REG(hw, IXGBE_GPIE);
gpie &= ~IXGBE_GPIE_VTMODE_MASK;
- gpie |= IXGBE_GPIE_MSIX_MODE;
+ gpie |= IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT;
switch (RTE_ETH_DEV_SRIOV(eth_dev).active) {
case ETH_64_POOLS:
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang
2017-11-20 3:26 [dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang Wenzhuo Lu
@ 2017-11-20 12:12 ` Luca Boccassi
0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2017-11-20 12:12 UTC (permalink / raw)
To: Wenzhuo Lu; +Cc: stable
On Mon, 2017-11-20 at 11:26 +0800, Wenzhuo Lu wrote:
> The datasheet says, if using MSI-X mode, the PBA support
> bit of the GPIE register must be set to 1.
> DPDK uses polling mode, we cannot hit this issue in the
> scenario DPDK PF + DPDK VF. If we use DPDK PF + kernel VF,
> as the kernel driver uses interrpt mode, VF may hit RX hang
> after running hours.
>
> Fixes: 00e30184daa0 ("ixgbe: add PF support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_pf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c
> b/drivers/net/ixgbe/ixgbe_pf.c
> index 676e92c..0114694 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -273,7 +273,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev
> *eth_dev)
>
> gpie = IXGBE_READ_REG(hw, IXGBE_GPIE);
> gpie &= ~IXGBE_GPIE_VTMODE_MASK;
> - gpie |= IXGBE_GPIE_MSIX_MODE;
> + gpie |= IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT;
>
> switch (RTE_ETH_DEV_SRIOV(eth_dev).active) {
> case ETH_64_POOLS:
Thanks, merged in dpdk-stable/16.11
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-20 3:26 [dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang Wenzhuo Lu
2017-11-20 12:12 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).