[dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang

[dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang

[Wenzhuo Lu]

The datasheet says, if using MSI-X mode, the PBA support
bit of the GPIE register must be set to 1.
DPDK uses polling mode, we cannot hit this issue in the
scenario DPDK PF + DPDK VF. If we use DPDK PF + kernel VF,
as the kernel driver uses interrpt mode, VF may hit RX hang
after running hours.

Fixes: 00e30184daa0 ("ixgbe: add PF support")
Cc: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ixgbe/ixgbe_pf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index 676e92c..0114694 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -273,7 +273,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)
 
 	gpie = IXGBE_READ_REG(hw, IXGBE_GPIE);
 	gpie &= ~IXGBE_GPIE_VTMODE_MASK;
-	gpie |= IXGBE_GPIE_MSIX_MODE;
+	gpie |= IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT;
 
 	switch (RTE_ETH_DEV_SRIOV(eth_dev).active) {
 	case ETH_64_POOLS:
-- 
1.9.3

Re: [dpdk-stable] [DPDK] net/ixgbe: fix VF RX hang

[Luca Boccassi]

On Mon, 2017-11-20 at 11:26 +0800, Wenzhuo Lu wrote:
> The datasheet says, if using MSI-X mode, the PBA support
> bit of the GPIE register must be set to 1.
> DPDK uses polling mode, we cannot hit this issue in the
> scenario DPDK PF + DPDK VF. If we use DPDK PF + kernel VF,
> as the kernel driver uses interrpt mode, VF may hit RX hang
> after running hours.
> 
> Fixes: 00e30184daa0 ("ixgbe: add PF support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_pf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c
> b/drivers/net/ixgbe/ixgbe_pf.c
> index 676e92c..0114694 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -273,7 +273,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev
> *eth_dev)
>  
>  	gpie = IXGBE_READ_REG(hw, IXGBE_GPIE);
>  	gpie &= ~IXGBE_GPIE_VTMODE_MASK;
> -	gpie |= IXGBE_GPIE_MSIX_MODE;
> +	gpie |= IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT;
>  
>  	switch (RTE_ETH_DEV_SRIOV(eth_dev).active) {
>  	case ETH_64_POOLS:

Thanks, merged in dpdk-stable/16.11

-- 
Kind regards,
Luca Boccassi