From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B47FC235 for ; Tue, 21 Nov 2017 14:25:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 685FC20AFD; Tue, 21 Nov 2017 08:25:44 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PIa+qeAYCnfVdm/ZO ywjUKtD/iwrv58AVGIC7Pir0b0=; b=T37DJwBxm6mDoeUPiMnRIryLGTVCtJV3l 6GEo0VhD5ZkQmNbBB2MBWqg1MebkCvChDLLVNvqCN43hVgxR1SVmmVyNcRJzYnyP LgkmWK8dG1Tqd/FuBHc/HJvn0R6BOQWk70puc7R4rWWNKNHQMgXKKka2e7uhGhAn 2tPMU+5ICM74quKjvykA0BSanK45pn2P71ZS7Pri3aZk0/AErcVN69XXLMwBtcMZ MhUmT6rAWeyXrsDdRMzNMxkEw9RhJvzAvFMj8B3/2nQZVCRY8ABwDwqf8Iy/wTUz z/c20XbqSlD/gesryFG0ctkcx9iJAUNhuZ1c6eQBcIRgaITZbjTdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=PIa+qeAYCnfVdm/ZOywjUKtD/iwrv58AVGIC7Pir0b0=; b=ps+9qIsf jhG+4TYuobUcPAJUKQcmlmoNy4zmeNXlR+AX+kWFg6lowEnp78JVPjRnFX/zbb5n r2nAZ1i8aqSEVTpMrTy2A6hCaVnDvq4tSbclYpax8Biw+JgUZjK8Q4pxOuchrtdx dWY0G9v+RM9T9v8pyYBKpvXx4X8dsGvLOvnmTcZRtmn07T/jl0ETatLgC6A8HPsn frkxptjl0wkj+Nscws5A4Vdi0pOp7oI4SNpxzqJHfo7ZZfoBfdRLP9lBnfn9aTUC uLuonjmb5yy6HJ9eXdDrgZcQbAuFqyxYbx5xQ0B23wBT/0yLFq+x60VZ0ZrVznFD 1+FbDYBlyQz4sQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id F23732486C; Tue, 21 Nov 2017 08:25:41 -0500 (EST) From: Yuanhan Liu To: =?UTF-8?q?N=C3=A9lio=20Laranjeiro?= Cc: Yongseok Koh , dpdk stable Date: Tue, 21 Nov 2017 21:17:23 +0800 Message-Id: <1511270333-31002-101-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix clang compilation error' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:25:45 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 06d7391151d805f4a6d4989e6943645a3d3b4e42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?N=C3=A9lio=20Laranjeiro?= Date: Mon, 9 Oct 2017 16:44:52 +0200 Subject: [PATCH] net/mlx5: fix clang compilation error [ upstream commit 35a010ad48cd6aba911f9c05fc7b5d3d86bf2094 ] drivers/net/mlx5/mlx5_rxq.c:606:6: error: comparison of constant 4 with expression of type 'enum hash_rxq_flow_type' is always true [-Werror,-Wtautological-constant-out-of-range-compare] i != (int)RTE_DIM((*priv->hash_rxqs)[0].special_flow); ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Clang expects to have an index going upto special_flow size which is defined by MLX5_MAX_SPECIAL_FLOWS and value is 4. Comparing to an unrelated enum where index my be lower cause this compilation issue. Fixes: 36351ea34b92 ("net/mlx: fix build with icc") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 74387a7..f6b1d55 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -614,11 +614,9 @@ priv_allow_flow_type(struct priv *priv, enum hash_rxq_flow_type type) int priv_rehash_flows(struct priv *priv) { - enum hash_rxq_flow_type i; + size_t i; - for (i = HASH_RXQ_FLOW_TYPE_PROMISC; - i != RTE_DIM((*priv->hash_rxqs)[0].special_flow); - ++i) + for (i = 0; i != RTE_DIM((*priv->hash_rxqs)[0].special_flow); ++i) if (!priv_allow_flow_type(priv, i)) { priv_special_flow_disable(priv, i); } else { -- 2.7.4