From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 10D72237 for ; Tue, 21 Nov 2017 14:27:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A3D3420AAF; Tue, 21 Nov 2017 08:27:01 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1vfYOj7vSK0iZA9V2 q/cVJd3s4IQwE9cM+g1R38qoSY=; b=SIvi4f6yhhuisCIp3vE+tkcAC088jrmB8 iYZT4Jc97OPfZc9TpyiU7ombA7JCdL+XcxYiiPYeJ+JnPXd8ZLRvAPSL+qqJrabS yrGzU7vt4iGLmC51n9e/H8cI9zYesVTkeQsW3EEWyLe1yUDEGTmAYw3V83TTRUsG du2A9btseXWmqMUGszxU9zsKpuEEgZ0tjE3XNbsrxSvEJRghdhN30mAJGuXu1e8x hEuNK2uCGGpcg/225ddVzZJpcqHU528mbpVS9awz6IxJ/euhhg2dRp/bL8+jb7C5 O7qJjlcxMlkagbFlXlZp+qgpLxrAsFhNPzaAWPmoVM0O+rNoaFmZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=1vfYOj7vSK0iZA9V2q/cVJd3s4IQwE9cM+g1R38qoSY=; b=VboTuVkS 86tryktvkeoUtIMy/ID7MjKnVnlHy0FPqtHheiqvFtDosXLVdKHRb7G4Ywp7tPu+ xqSmRMTQ6JC31qnv7YQdB2Q4J3eIq470d294TsirT48xWeKO0zKHV2ol97gqQp8j ffBpME0HKB7rKIv5mcHRTWh5EtY/G2PFDwa4bB+60l+Bk4B0g1hB6XYQ5td+0pY1 htcbvjwJS9l5x1jeiAedTXqz72CtEBDPSmBhlrGTMBsLoauO3q8OTjrH0zu2XZy8 V+YhKQSnTCUc5s+5t4ccjlwYiSMMHQJ2s7qVhigW8H8DWVoqnEKVxW42AtJM4lV2 ao+90JhaLCc4LQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id AB8FF243B9; Tue, 21 Nov 2017 08:26:59 -0500 (EST) From: Yuanhan Liu To: Xueming Li Cc: dpdk stable Date: Tue, 21 Nov 2017 21:17:43 +0800 Message-Id: <1511270333-31002-121-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'examples/l2fwd_fork: fix message pool init' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:27:02 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 565b0213735eb4e2a25b4660caf69f96796801a3 Mon Sep 17 00:00:00 2001 From: Xueming Li Date: Fri, 15 Sep 2017 23:37:21 +0800 Subject: [PATCH] examples/l2fwd_fork: fix message pool init [ upstream commit 9b85b871cc52d1219f5a68131059e539f7ee9916 ] Some invalid callback functions are provided to rte_pktmbuf_pool_init() without their associated data causing a segmentation fault when the function tries to use it. In this example, those callbacks are not necessary, they can be safely replaced by NULL pointers. Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") Signed-off-by: Xueming Li --- examples/multi_process/l2fwd_fork/main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/examples/multi_process/l2fwd_fork/main.c b/examples/multi_process/l2fwd_fork/main.c index f8a626b..2e70c2f 100644 --- a/examples/multi_process/l2fwd_fork/main.c +++ b/examples/multi_process/l2fwd_fork/main.c @@ -1204,10 +1204,7 @@ main(int argc, char **argv) message_pool = rte_mempool_create("ms_msg_pool", NB_CORE_MSGBUF * RTE_MAX_LCORE, sizeof(enum l2fwd_cmd), NB_CORE_MSGBUF / 2, - 0, - rte_pktmbuf_pool_init, NULL, - rte_pktmbuf_init, NULL, - rte_socket_id(), 0); + 0, NULL, NULL, NULL, NULL, rte_socket_id(), 0); if (message_pool == NULL) rte_exit(EXIT_FAILURE, "Create msg mempool failed\n"); -- 2.7.4