From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 73835237 for ; Tue, 21 Nov 2017 14:27:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 28592207F5; Tue, 21 Nov 2017 08:27:14 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:27:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jZKz3HqCDfkA1/9aC TjOb+JaoR7/Z49QtQ+9cr5T4NY=; b=q/fCIpCz7I5zEGwabZp+nseUw3ZaVWhdF 74rMQ8jteHCld0X/IZSgTySg452g0w5KgZEYnk92fE/tlz1ZyJQbcI9zjKAtTgnG tQCC3Y+V9tWoGRG+p9Tc5PXRDdOXpn4oi6kbrTDUywSLXeg2kD7V/Hu0QMKZsXpF b8cY7C8jYPEfkN+z4/kVA3u5t2BxQAA3zu1JVlW/7xx/CYPI2hG2jnutvN9Z6Rue nNmrU329GIbJx+IV6TuXWE9g5dhLEi27/eNbzr6USEW639Fg9GpGDhCJwu2d5FdP BfTNNCDtsrW2VOB2iuqlxi48SS04V8jsa7vfhBbQPuP7RsWjl0b4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=jZKz3HqCDfkA1/9aCTjOb+JaoR7/Z49QtQ+9cr5T4NY=; b=OUDWUEY3 XeYo0CisKK+FPKW7bhjXTyrfeb/8nZRiBU81sC4HkvZLT/m3z1/lw3PoyLJ/L17I bASs2K7XiTG4aoPo6IW/xn1UQqIfZCm+kakXZHgU6YdjhkVjjwzXUtmKM/PJv5lZ 58r7BUxpwL9F7Wp5YuZ2Q8S3HGC3lTmXWw6BhqLQeiwmhJRfk/9Hxfdq+6+xApn1 JnuS8HSdO5cGhE9JLg+e/agQFcpbFR5QaR3bIzvF7oeKOQ5Sh46uw6VUL87W4u/K 5ZLVpLcYKwcOCZfXGJeE4Zos6HXtovMmrPmOGDwXhe//0DQxaTrLY+uKvVfinXPz /OF9KN59eoME/w== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 4ADD9243B9; Tue, 21 Nov 2017 08:27:10 -0500 (EST) From: Yuanhan Liu To: Sebastian Basierski Cc: Jianfeng Tan , Yuanhan Liu , dpdk stable Date: Tue, 21 Nov 2017 21:17:46 +0800 Message-Id: <1511270333-31002-124-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/virtio: check error on setting non block flag' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:27:14 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From f7f178534c5cb2c582a8e8b6d0e774947fba19fe Mon Sep 17 00:00:00 2001 From: Sebastian Basierski Date: Tue, 24 Oct 2017 10:17:38 +0200 Subject: [PATCH] net/virtio: check error on setting non block flag [ upstream commit 2fd826a301b5a872cad0b67c807d3011693321c7 ] Report an error message if the flag O_NONBLOCK setting fails, then return from function. Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Signed-off-by: Sebastian Basierski Acked-by: Jianfeng Tan Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_user_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index c961444..52582de 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -86,7 +86,11 @@ virtio_user_read_dev_config(struct virtio_hw *hw, size_t offset, int flags; flags = fcntl(dev->vhostfd, F_GETFL); - fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK); + if (fcntl(dev->vhostfd, F_SETFL, + flags | O_NONBLOCK) == -1) { + PMD_DRV_LOG(ERR, "error setting O_NONBLOCK flag"); + return; + } r = recv(dev->vhostfd, buf, 128, MSG_PEEK); if (r == 0 || (r < 0 && errno != EAGAIN)) { dev->status &= (~VIRTIO_NET_S_LINK_UP); -- 2.7.4