From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B60DB237 for ; Tue, 21 Nov 2017 14:27:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6A0CE20B3E; Tue, 21 Nov 2017 08:27:18 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:27:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wZPYb6GOijDa4xYwj jCZrnjlHXvI7GnlrpnVc7/Eie4=; b=AKVeN+CL/ijAd9imwqTTFuj2yUktOsOGB Ru88LoweGx7PjrCE6Y7GDap6a2BMhtZdDHCf1XJi6rDM9alVxegxQt4UR0kjypFZ 9QCnAvfDdHTkrDeZJFFbHuU0DLhCo78t7umhlXPN0JDxidp4znPxIsVQeVySiPo1 X3Mb0BoyCJ2gNcsjb0aAJBpASY0egSFpJH8lsgRgdWUQIlhn6I29h/cpF5TvvbIL 23GYabpdJaCe8nyzpIoD4Bccw7VEkrsxHKpeVBASwCOw7EpwSGlfFft2EIsXUVKr mdmSeL/OOnUXyz0bO9CI6W8Us/8+xREoBRqwLvAC93Jdn0TQ0QKvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=wZPYb6GOijDa4xYwjjCZrnjlHXvI7GnlrpnVc7/Eie4=; b=cfNHHc2Q iVHPsiBrdtwgpq7BaNiUgZewhOHaOK+LajuMDzR6t8hnrh/BbYUsLFIb0qUJk4no zmRILleZPKlDSzzowfFV0EziNPpPfr97KvB7MYGlyPxD5YSVZHWEvB6lLxWW4twT N5MlfRx5HwlwpWekeZDenIipM6UYdk58GoTgm2dX+BGTMnSwDD9YWKgCCPfprLD3 gZEv8aiejD9GnYhxYAml4jAlyBg3dDMxWSOTI8HzG32HXbbr78PivttqzPWNloxi qNSd6T4l9GRgoijhpbERBEZTafWEPslJh5+hjxwH8ZyvCj8m9FySnqi4gW4b56lt Rk5efmzBKXgouw== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id D7C8B243B9; Tue, 21 Nov 2017 08:27:14 -0500 (EST) From: Yuanhan Liu To: Zhiyong Yang Cc: Maxime Coquelin , Yuanhan Liu , dpdk stable Date: Tue, 21 Nov 2017 21:17:47 +0800 Message-Id: <1511270333-31002-125-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/virtio: fix Tx packet length stats' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:27:19 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 09c3348dee1c3aeb2564ee5a7055a33672c1691c Mon Sep 17 00:00:00 2001 From: Zhiyong Yang Date: Tue, 24 Oct 2017 11:06:14 +0800 Subject: [PATCH] net/virtio: fix Tx packet length stats [ upstream commit f1216c1eca5a54706af9f13133d06b3477099f8b ] In the function virtqueue_enqueue_xmit(), when can_push is true, vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. which is wrong for pkt stats, virtio header length should be subtracted before calling stats function. Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") Signed-off-by: Zhiyong Yang Reviewed-by: Maxime Coquelin Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 7d5b510..217677a 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -300,6 +300,10 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, /* prepend cannot fail, checked by caller */ hdr = (struct virtio_net_hdr *) rte_pktmbuf_prepend(cookie, head_size); + /* rte_pktmbuf_prepend() counts the hdr size to the pkt length, + * which is wrong. Below subtract restores correct pkt size. + */ + cookie->pkt_len -= head_size; /* if offload disabled, it is not zeroed below, do it now */ if (offload == 0) { ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0); -- 2.7.4