From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5A39F23B for ; Tue, 21 Nov 2017 14:27:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1008D20CB0; Tue, 21 Nov 2017 08:27:25 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:27:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gDlj0/M1UJdBkZJEy cXeCC4C6vpNG8zP9ONXvok336w=; b=qwmiDzSWoWSWjh/K5QXPNZTpkWw3zZ6Aw Q2vH4Fm4LHqbInL4awhW/DRTs4c2eowi6OXmtwbvodz2+m9tgHkpnQAB0f/Ymj7Y ZHnW12l3RDIxwRM+TfaADA9L2WmPEr8uDnwZOgI+diE+gxxd3JDlV3LsmMqu15Yv /C1KJoF71Xz7A/Jcx377i9j4cXycCL6BPpi6V+kOFCyECFC7s3fAfUQCNRUjt0Dr e+STK9WHKL4zhN9vevuavaYjCsFJvlwUrjRYBeLbUM1q4Id7bdDfMlsza7HcflAc uIW0xhQboa8v5u0fDxdPokd/o1yiPhib2GgH/4L4Mpc1FZ5zh/O1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=gDlj0/M1UJdBkZJEycXeCC4C6vpNG8zP9ONXvok336w=; b=jlm1FF5P 9FMV7Gkjz+4Xt4IhNYU+h+6jXZsLLp69Mr7DDaxoJJsI7wIFNtYrRM+9hfHfGPJM QOt1S/kPwqy8iTVSkn6p3J8I/pWDRKGxwPODq0zkbPa7cah1QoxV1QONxGVzgYZu TXe0+jvlDf7/ULeSQYqHe8ceTjk/fvvb26Hoq7Kn4A7qF75kJE4B8RL1r4judHFS FekF2DmbqnTLkQh2/VYEGxde8spr8qFMqYf9VK22dQ9XSOz7cb8pC+5mdrZrcz1p /ayRmC6GYLqkJ5ZTSC9i9z/rV9ae2ehX3bXiB1/bZSuCxtz0q0gWRxCFPDE6Y8FZ COdX/CoLS8MDdQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 065CE247A9; Tue, 21 Nov 2017 08:27:22 -0500 (EST) From: Yuanhan Liu To: Jasvinder Singh Cc: dpdk stable Date: Tue, 21 Nov 2017 21:17:49 +0800 Message-Id: <1511270333-31002-127-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'examples/qos_sched: fix uninitialized config' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:27:25 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 957ddc36fb18752b2b1920507817cb609cab3690 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Tue, 24 Oct 2017 10:09:57 +0100 Subject: [PATCH] examples/qos_sched: fix uninitialized config [ upstream commit 96b5077cfaf95cd38dc7644e39036ad94e6435c8 ] Fix problem with uninitialized rx/tx deferred_start flags of the struct rte_eth_rxconf/txconf by initializing with 0 value (deferred start of the rx/tx queues is turned off). This setting allows device rx/tx queues to start with rte_eth_dev_start(). Coverity issue: 194999, 195009 Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Jasvinder Singh --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index a82cbd7..7d54fdb 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -118,6 +118,7 @@ app_init_port(uint8_t portid, struct rte_mempool *mp) rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; rx_conf.rx_free_thresh = 32; rx_conf.rx_drop_en = 0; + rx_conf.rx_deferred_start = 0; tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; @@ -125,6 +126,7 @@ app_init_port(uint8_t portid, struct rte_mempool *mp) tx_conf.tx_free_thresh = 0; tx_conf.tx_rs_thresh = 0; tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS; + tx_conf.tx_deferred_start = 0; /* init port */ RTE_LOG(INFO, APP, "Initializing port %"PRIu8"... ", portid); -- 2.7.4