From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 809D9235 for ; Tue, 21 Nov 2017 14:27:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 357FA20CBF; Tue, 21 Nov 2017 08:27:28 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8h6bRaIkP5phz3PQM cUHWpqzs3OcJIGKfKkBwj0Tb5U=; b=hnAI5NqUx7yz5SU9tfi3vrTxluD/tnE01 plw1p2aFJqFgdhGW1b/ocHO2DNQcVVKD0ICNcEH58uRDzA8B4JngNuyO3faUppIg 8mrX4NxfB1K7ocAUVw24lXqLsyUX8/eXAv9h9gQ2rVhUMdZyBs5HTRmcoN6DWzTv 3Jc9HvU/dWhs2r7NaO8bhh4DUm1ZvnGk6JROzgHe0JsK1g8DqikjR0l71EhkeSs7 7cBLjSTiRvn5cw2VAQ3dAmx1htcmiYqZH8l+zjcYmbCa3hghh2oszyg9Xoce/6qb 38k4yCs+H28B+tT/eyQE8RV03meVLyyilDcLCr7QnPzqvSKVR4Mqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=8h6bRaIkP5phz3PQMcUHWpqzs3OcJIGKfKkBwj0Tb5U=; b=pwa0LA5b N7jfQqw7MwRTZu9GQDhLqd0QS+3dxfUIaRc+AogXw+gutZIkRrc7llx5fA2M+mUm 6dJDlY+mMn0ktfbuukyEW4c5rDZ4Q+IrfF8I2RMRc2hsL1mEJ7Fk2T1z9CqdvIrJ q+EKtw2+9b71cuU+oICoF0mIsAhpEpwgyNbXRHnHl0eEezECNdTVx9vIiHFqE19W kwimcnol0uVcsyY8RLIpCDwpMcM4eB9/w0h0TaCgny1dcaRrL80uocFjdwBV9GwN cDe23LFojh41Oy4YsAJSYgP+aQdWJrTIJQlxnQi3/vVsmasx+spxOW+SOhS2jp1C +ZMKsmHUkvBoGg== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id B593924810; Tue, 21 Nov 2017 08:27:25 -0500 (EST) From: Yuanhan Liu To: Jacek Piasecki Cc: Maxime Coquelin , dpdk stable Date: Tue, 21 Nov 2017 21:17:50 +0800 Message-Id: <1511270333-31002-128-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'examples/vhost_scsi: fix product id string termination' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:27:28 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From ed143fcf2f36820679cb7eb54603f717816b6341 Mon Sep 17 00:00:00 2001 From: Jacek Piasecki Date: Wed, 25 Oct 2017 12:07:18 +0200 Subject: [PATCH] examples/vhost_scsi: fix product id string termination [ upstream commit 681459bf9cd5778ada011e6d8d681436ec5394f0 ] Use snprintf instead strncpy to get safe null string termination. There was possible to get not terminated string after strncpy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Signed-off-by: Jacek Piasecki Acked-by: Maxime Coquelin --- examples/vhost_scsi/scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c index 54d3104..fd430ec 100644 --- a/examples/vhost_scsi/scsi.c +++ b/examples/vhost_scsi/scsi.c @@ -307,7 +307,9 @@ vhost_bdev_scsi_inquiry_command(struct vhost_block_dev *bdev, strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8); /* PRODUCT IDENTIFICATION */ - strncpy((char *)inqdata->product_id, bdev->product_name, 16); + snprintf((char *)inqdata->product_id, + RTE_DIM(inqdata->product_id), "%s", + bdev->product_name); /* PRODUCT REVISION LEVEL */ strncpy((char *)inqdata->product_rev, "0001", 4); -- 2.7.4