From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0968C239 for ; Tue, 21 Nov 2017 14:28:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B2D8B20CBF; Tue, 21 Nov 2017 08:28:56 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:28:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=L1z2JiqI3lN0t07rZ XZDWhCJUrOEVESMzjfQVpmFkjo=; b=W8H8A3/H7RcvjJ9BxyeNiadnC8yY3/HHY 7z1YWCTf8xpHPUDyQK95ojnSeknHx7qTPy7TK66AfJAsV38lBDOBYJYUPFsGg7Dq hf0Sa38GRDihmoCQkbJxZRdAWa5AAYVDdCSeZmVo7ZlBpvS/3wbkoKmNEpOHemIS bopMcILKGjdgKLctS6w1DWQwObH+Ov44Rd+iBOXXFdsbdjgG+nM4qX9ykSx6cOrA sh3pxP1r3MuV0CxZ9YX9gQkJcgX2CzjcorHmoy4si8qoyXnjwKu6OAsdj5kx7jIx Te7iq5alkfZwlrwGKa308s0sehebb6ElgeEh+ErGfC3BFJVTAuamQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=L1z2JiqI3lN0t07rZXZDWhCJUrOEVESMzjfQVpmFkjo=; b=aJsQQNgJ q4a8/q1joxzMng9rBE9ojdegn1yXch4ipg0KxkvqQhgYU0Ur65a1VYV/GtRlr96c g5jiVTmEwjl/X+pDZZrZwxX2YOiraRmuzSzoQC4YwBWKUJqhheTxFruFRNLIFMcT eKRtGpZmcvx5pFEqBLi2kEuMdXuZUsPRObb39JHIegJEzI9AZWvS7ESaoDXXsPFA yy6fGRPl1RrSWZkkp41wQtZIhXBaM7+Ns9Q4HhioLW3pCxvnZ/+h8I/tcHFfoqRu ZJgor6pFkL6aGSEXymlZ6P+d6zFYoS8OoDJLNDVOqlnvu4jCn2kfbUfW37AwpL3M v97kk5ijSmKukQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id EBD6F24810; Tue, 21 Nov 2017 08:28:49 -0500 (EST) From: Yuanhan Liu To: Harish Patil Cc: dpdk stable Date: Tue, 21 Nov 2017 21:18:09 +0800 Message-Id: <1511270333-31002-147-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/qede: fix to re-enable LRO during device start' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:28:57 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From d1afebc38dcb92056d92abcfffdbd8279de342dd Mon Sep 17 00:00:00 2001 From: Harish Patil Date: Wed, 18 Oct 2017 18:13:31 -0700 Subject: [PATCH] net/qede: fix to re-enable LRO during device start [ upstream commit daee4e07fc0cb6386cb8d6e84d811d2203699683 ] Move LRO configuration from dev_configure to dev_start so that LRO configuration can be re-enabled following a port restart. Fixes: 9a6d30ae6d46 ("net/qede: refactoring vport handling code") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 4d4a96d..b502551 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -520,7 +520,7 @@ int qede_enable_tpa(struct rte_eth_dev *eth_dev, bool flg) return -1; } } - + qdev->enable_lro = flg; DP_INFO(edev, "LRO is %s\n", flg ? "enabled" : "disabled"); return 0; @@ -1078,6 +1078,7 @@ static void qede_fastpath_start(struct ecore_dev *edev) static int qede_dev_start(struct rte_eth_dev *eth_dev) { + struct rte_eth_rxmode *rxmode = ð_dev->data->dev_conf.rxmode; struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); @@ -1088,10 +1089,15 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) if (qede_update_mtu(eth_dev, qdev->new_mtu)) goto err; qdev->mtu = qdev->new_mtu; - /* If MTU has changed then update TPA too */ - if (qdev->enable_lro) - if (qede_enable_tpa(eth_dev, true)) - goto err; + } + + /* Configure TPA parameters */ + if (rxmode->enable_lro) { + if (qede_enable_tpa(eth_dev, true)) + return -EINVAL; + /* Enable scatter mode for LRO */ + if (!rxmode->enable_scatter) + eth_dev->data->scattered_rx = 1; } /* Start queues */ @@ -1103,7 +1109,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) * Also, we would like to retain similar behavior in PF case, so we * don't do PF/VF specific check here. */ - if (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) + if (rxmode->mq_mode == ETH_MQ_RX_RSS) if (qede_config_rss(eth_dev)) goto err; @@ -1139,7 +1145,6 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) if (qdev->enable_lro) qede_enable_tpa(eth_dev, false); - /* TODO: Do we need disable LRO or RSS */ /* Stop queues */ qede_stop_queues(eth_dev); @@ -1226,16 +1231,6 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) qdev->mtu = rxmode->max_rx_pkt_len; qdev->new_mtu = qdev->mtu; - /* Configure TPA parameters */ - if (rxmode->enable_lro) { - if (qede_enable_tpa(eth_dev, true)) - return -EINVAL; - /* Enable scatter mode for LRO */ - if (!rxmode->enable_scatter) - eth_dev->data->scattered_rx = 1; - } - qdev->enable_lro = rxmode->enable_lro; - /* Enable VLAN offloads by default */ qede_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | -- 2.7.4