From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E5A97237 for ; Tue, 21 Nov 2017 14:29:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 95BCB20CC8; Tue, 21 Nov 2017 08:29:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:29:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=remoUquLHY79yZMuu TPWTJmBMPdPs+S8FaCM5I0Hi8E=; b=TLacFquAf1xvFPWAIc1eRWzs3uIFpP0W6 w0almt05jzYDlS9ZW44QS6mXZe5mcBRPxLrhgEsMsn44a0Dg+wUqzCbt3MNupCaj yE00Qd7G+2Ng37dUrzJIGVGq2gmWu/UpFDaoN5Z8w0Rh57e0ai0PJW10Ktx1/oAC bGTTBMW1spzOj8+3RNgSwkHUPWJyjkMPUF7nLRr4X2rvxu33MFtiJlObfY37SXS9 ryEkUxTRuadNpjlAmxVIvAXKX0p7empmJrKoTsb2g11rYYnRBf2ZghVeVEL430P3 UiCA996XmTRLbJy5g4YIe1IaDGonn/ABSju77Mz0u2QKUU/z1L9oQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=remoUquLHY79yZMuuTPWTJmBMPdPs+S8FaCM5I0Hi8E=; b=MUmdfnU+ zU5my1uekA+5bb+hh4Q7hCk5nl0ZiGJY6kjRJGCm6G3af94RjFav0s/XAOldigY7 CsRT30QI7Zoy9SqCYl/mURDRZ8YD1KNSywmCXfb+CLQxtu4vtl9yMKU1Vv1ZeAp5 aw+6yOlo83PbG8R0APxnhJGuFz9LWsWRnz0KAfytE7+HkZRTF5N5NZwgp1koPELJ kaoVnPnc7c/avT0suVONUNXjtgmbe0sTQeBZpioFpCyu+rNYd2YKTi002g5qpMPa tVTt0g9Ewei/uLMNTUksUihYfQFLsDVT2zRbojSVE+9pVb3dwjwpP8azobdlSPWZ s7j9PuG6BjSe6Q== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 551AD248B4; Tue, 21 Nov 2017 08:29:04 -0500 (EST) From: Yuanhan Liu To: John Daley Cc: dpdk stable Date: Tue, 21 Nov 2017 21:18:12 +0800 Message-Id: <1511270333-31002-150-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/enic: fix packet loss after MTU change' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:29:09 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 41a054797a3c2cd727ae4e3b2770ad042ce9004d Mon Sep 17 00:00:00 2001 From: John Daley Date: Mon, 23 Oct 2017 13:23:00 -0700 Subject: [PATCH] net/enic: fix packet loss after MTU change [ upstream commit ea5f15b1c49a687eaa57d435a8bf68e553b50b30 ] If multiple Rx queues and Rx Scatter are used and the MTU is modified so that the number of mbufs per packet changes, packet loss is possible. The enic completion queue index was miscalculated leaving the upper half of the queues uninitialized after an MTU change, possibly leading to completions on those queues not getting processed. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Signed-off-by: John Daley --- drivers/net/enic/enic_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index cac8b66..cc71bf2 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1117,11 +1117,12 @@ static int enic_reinit_rq(struct enic *enic, unsigned int rq_idx) { struct vnic_rq *sop_rq, *data_rq; - unsigned int cq_idx = enic_cq_rq(enic, rq_idx); + unsigned int cq_idx; int rc = 0; sop_rq = &enic->rq[enic_rte_rq_idx_to_sop_idx(rq_idx)]; data_rq = &enic->rq[enic_rte_rq_idx_to_data_idx(rq_idx)]; + cq_idx = rq_idx; vnic_cq_clean(&enic->cq[cq_idx]); vnic_cq_init(&enic->cq[cq_idx], -- 2.7.4