From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9BDE1236 for ; Tue, 21 Nov 2017 14:29:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 50E7520921; Tue, 21 Nov 2017 08:29:56 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:29:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rZyCcUPka36ysc5Cu mCEIm2KQOYpsCCRDR4hwdvZERQ=; b=qSDPaBl12zq0vTZ89Z1g4NaGGnOL05BTX nK4Y79CYIJQmVLhLMAxAiH4TEIY8IuMIduyEBXxyvOt9LPRwDFqUcItl7zha+V8h XKN+JyTm+UDCTjfT8yP/t8mJJikiYtfa30It9GrjHCoyKcqkA+cCei+GmRpMEJyL 8bnc3/tUzlqxVPZfCmpMhBkJ8HQ7SsdXG2uVXZrITTYpHc6IZgcbDppekLHsxOSi hULStP5GcuFDKDIC2F9Fqf+0K/pj4CA78KD+kstEJTIb4MTD3cqUg9rUZcFat5XN 1bN8oPtwVo1nSyc3MZo1SCuN2UjoiBSNi5QHEwkdXFFMbz1E1GvBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=rZyCcUPka36ysc5CumCEIm2KQOYpsCCRDR4hwdvZERQ=; b=hgZV5NXG 4V9YQ9EIgp97xDcNnN/Wcvi4oLGhS2q22XF6qrmRnvoWcVd268lgqm5voVzehxT5 Ot/K2MqLjI0Kfy60yhu80+qHg+zlepDbYGEUAWYRzO8Prb8+CseMXu9n0BuxU1a8 oM4z98yv7nME0pT0yH30QTt4O3sgTxyXR9XJsR49ngkRj2/LtzEBXENoBAG58Uw4 f//P392tBqfWmF95Ptnt/EpWfUD0Tu/12zKR7lN2fGEhBfMetnD4PLFwS0hp13HC M1y4DtR4XP6ludnuNxvwS0lHXmQO6Y9cJPJSAqsze7AEC5tyvUyJ+CZnQ8+ZyhFH 7dOrpiFOa+q7+Q== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id D3BA624810; Tue, 21 Nov 2017 08:29:53 -0500 (EST) From: Yuanhan Liu To: Tomasz Kulasek Cc: Ferruh Yigit , dpdk stable Date: Tue, 21 Nov 2017 21:18:27 +0800 Message-Id: <1511270333-31002-165-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bonding: fix check slaves link properties' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:29:56 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 880edabf1d1ad1a1be33aac10aba2f0f97032647 Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Fri, 20 Oct 2017 17:49:26 +0200 Subject: [PATCH] net/bonding: fix check slaves link properties [ upstream commit 6abd94d72ab5b6787391a823d246e0288bd3ace0 ] Result of slaves link properties validation is not used when new slave is added. This patch uses the value of link_properties_valid() to determinate if slave can be used in the bonding. If function fails, error is returned preventing to add slave with invalid link properties. Coverity issue: 158661 Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") Signed-off-by: Tomasz Kulasek Reviewed-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_api.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index de1d9e0..ecda494 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -302,8 +302,13 @@ __eth_bond_slave_add_lock_free(uint8_t bonded_port_id, uint8_t slave_port_id) internals->tx_offload_capa &= dev_info.tx_offload_capa; internals->flow_type_rss_offloads &= dev_info.flow_type_rss_offloads; - link_properties_valid(bonded_eth_dev, - &slave_eth_dev->data->dev_link); + if (link_properties_valid(bonded_eth_dev, + &slave_eth_dev->data->dev_link) != 0) { + RTE_BOND_LOG(ERR, "Invalid link properties for slave %d" + " in bonding mode %d", slave_port_id, + internals->mode); + return -1; + } /* RETA size is GCD of all slaves RETA sizes, so, if all sizes will be * the power of 2, the lower one is GCD -- 2.7.4